All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] MAINTAINERS: add keyword for devicetree overlay notifiers
@ 2018-04-28  1:31 frowand.list
  2018-05-08  0:16 ` Frank Rowand
  2018-05-09 18:31 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: frowand.list @ 2018-04-28  1:31 UTC (permalink / raw)
  To: Rob Herring, pantelis.antoniou, Pantelis Antoniou
  Cc: devicetree, linux-kernel, Jan Kiszka

From: Frank Rowand <frank.rowand@sony.com>

Devicetree overlay notifiers have a chance to potentially get
pointers into the overlay unflattened devicetree and overlay FDT.
The only protection against these pointers being accessed after
the underlying data has been released by kfree() is by source
code review of patches.  Add a keyword line to the devicetree
overlay maintainers entry to try to catch overlay notifier
related patches.

The keyword line is added to the devicetree overlay entry instead
of the devicetree entry so that not all maintainers will receive
the additional review traffic.  Add Frank Rowand (already a
maintainer in the devicetree entry) so that he will receive
the additional review traffic.

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---

changes from version 1:
   - removed extraneous "From:" tags at top of patch description


 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 92be777d060a..aca3956694f8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10422,12 +10422,14 @@ F:	drivers/infiniband/ulp/opa_vnic
 
 OPEN FIRMWARE AND DEVICE TREE OVERLAYS
 M:	Pantelis Antoniou <pantelis.antoniou@konsulko.com>
+M:	Frank Rowand <frowand.list@gmail.com>
 L:	devicetree@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/dynamic-resolution-notes.txt
 F:	Documentation/devicetree/overlay-notes.txt
 F:	drivers/of/overlay.c
 F:	drivers/of/resolver.c
+K:	of_overlay_notifier_
 
 OPEN FIRMWARE AND FLATTENED DEVICE TREE
 M:	Rob Herring <robh+dt@kernel.org>
-- 
Frank Rowand <frank.rowand@sony.com>

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] MAINTAINERS: add keyword for devicetree overlay notifiers
  2018-04-28  1:31 [PATCH v2] MAINTAINERS: add keyword for devicetree overlay notifiers frowand.list
@ 2018-05-08  0:16 ` Frank Rowand
  2018-05-09 18:31 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Frank Rowand @ 2018-05-08  0:16 UTC (permalink / raw)
  To: Rob Herring, pantelis.antoniou, Pantelis Antoniou
  Cc: devicetree, linux-kernel, Jan Kiszka

Hi Rob,

Do you want to take this or should I route it through Andrew?

-Frank


On 04/27/18 18:31, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
> 
> Devicetree overlay notifiers have a chance to potentially get
> pointers into the overlay unflattened devicetree and overlay FDT.
> The only protection against these pointers being accessed after
> the underlying data has been released by kfree() is by source
> code review of patches.  Add a keyword line to the devicetree
> overlay maintainers entry to try to catch overlay notifier
> related patches.
> 
> The keyword line is added to the devicetree overlay entry instead
> of the devicetree entry so that not all maintainers will receive
> the additional review traffic.  Add Frank Rowand (already a
> maintainer in the devicetree entry) so that he will receive
> the additional review traffic.
> 
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> 
> changes from version 1:
>    - removed extraneous "From:" tags at top of patch description
> 
> 
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92be777d060a..aca3956694f8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10422,12 +10422,14 @@ F:	drivers/infiniband/ulp/opa_vnic
>  
>  OPEN FIRMWARE AND DEVICE TREE OVERLAYS
>  M:	Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> +M:	Frank Rowand <frowand.list@gmail.com>
>  L:	devicetree@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/devicetree/dynamic-resolution-notes.txt
>  F:	Documentation/devicetree/overlay-notes.txt
>  F:	drivers/of/overlay.c
>  F:	drivers/of/resolver.c
> +K:	of_overlay_notifier_
>  
>  OPEN FIRMWARE AND FLATTENED DEVICE TREE
>  M:	Rob Herring <robh+dt@kernel.org>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] MAINTAINERS: add keyword for devicetree overlay notifiers
  2018-04-28  1:31 [PATCH v2] MAINTAINERS: add keyword for devicetree overlay notifiers frowand.list
  2018-05-08  0:16 ` Frank Rowand
@ 2018-05-09 18:31 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-05-09 18:31 UTC (permalink / raw)
  To: frowand.list
  Cc: pantelis.antoniou, Pantelis Antoniou, devicetree, linux-kernel,
	Jan Kiszka

On Fri, Apr 27, 2018 at 06:31:20PM -0700, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
> 
> Devicetree overlay notifiers have a chance to potentially get
> pointers into the overlay unflattened devicetree and overlay FDT.
> The only protection against these pointers being accessed after
> the underlying data has been released by kfree() is by source
> code review of patches.  Add a keyword line to the devicetree
> overlay maintainers entry to try to catch overlay notifier
> related patches.
> 
> The keyword line is added to the devicetree overlay entry instead
> of the devicetree entry so that not all maintainers will receive
> the additional review traffic.  Add Frank Rowand (already a
> maintainer in the devicetree entry) so that he will receive
> the additional review traffic.
> 
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> 
> changes from version 1:
>    - removed extraneous "From:" tags at top of patch description

Applied, sorry it fell thru the cracks.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-09 18:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-28  1:31 [PATCH v2] MAINTAINERS: add keyword for devicetree overlay notifiers frowand.list
2018-05-08  0:16 ` Frank Rowand
2018-05-09 18:31 ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.