From: David Miller <davem@davemloft.net>
To: mgamal@redhat.com
Cc: netdev@vger.kernel.org, sthemmin@microsoft.com,
kys@microsoft.com, haiyangz@microsoft.com,
devel@linuxdriverproject.org, vkuznets@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts
Date: Thu, 10 May 2018 15:37:30 -0400 (EDT) [thread overview]
Message-ID: <20180510.153730.348233195080672901.davem@davemloft.net> (raw)
In-Reply-To: <1525853854-8277-1-git-send-email-mgamal@redhat.com>
From: Mohammed Gamal <mgamal@redhat.com>
Date: Wed, 9 May 2018 10:17:34 +0200
> On older windows hosts the net_device instance is returned to
> the caller of rndis_filter_device_add() without having the presence
> bit set first. This would cause any subsequent calls to network device
> operations (e.g. MTU change, channel change) to fail after the device
> is detached once, returning -ENODEV.
>
> Instead of returning the device instabce, we take the exit path where
> we call netif_device_attach()
>
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
>
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
Applied.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: mgamal@redhat.com
Cc: sthemmin@microsoft.com, netdev@vger.kernel.org,
haiyangz@microsoft.com, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, vkuznets@redhat.com
Subject: Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts
Date: Thu, 10 May 2018 15:37:30 -0400 (EDT) [thread overview]
Message-ID: <20180510.153730.348233195080672901.davem@davemloft.net> (raw)
In-Reply-To: <1525853854-8277-1-git-send-email-mgamal@redhat.com>
From: Mohammed Gamal <mgamal@redhat.com>
Date: Wed, 9 May 2018 10:17:34 +0200
> On older windows hosts the net_device instance is returned to
> the caller of rndis_filter_device_add() without having the presence
> bit set first. This would cause any subsequent calls to network device
> operations (e.g. MTU change, channel change) to fail after the device
> is detached once, returning -ENODEV.
>
> Instead of returning the device instabce, we take the exit path where
> we call netif_device_attach()
>
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
>
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
Applied.
next prev parent reply other threads:[~2018-05-10 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 8:17 [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts Mohammed Gamal
2018-05-09 8:17 ` Mohammed Gamal
2018-05-09 15:07 ` Stephen Hemminger
2018-05-10 19:37 ` David Miller [this message]
2018-05-10 19:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510.153730.348233195080672901.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgamal@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.