All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: igor.russkikh@aquantia.com, pavel.belous@aquantia.com,
	weiyongjun1@huawei.com, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: aquantia: fix unsigned numvecs comparison with less than zero
Date: Thu, 10 May 2018 17:53:58 -0400 (EDT)	[thread overview]
Message-ID: <20180510.175358.1296757435086922873.davem@davemloft.net> (raw)
In-Reply-To: <20180510125201.19707-1-colin.king@canonical.com>

From: Colin King <colin.king@canonical.com>
Date: Thu, 10 May 2018 13:52:01 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The comparison of numvecs < 0 is always false because numvecs is a u32
> and hence the error return from a failed call to pci_alloc_irq_vectores
> is never detected.  Fix this by using the signed int ret to handle the
> error return and assign numvecs to err.
> 
> Detected by CoverityScan, CID#1468650 ("Unsigned compared against 0")
> 
> Fixes: a09bd81b5413 ("net: aquantia: Limit number of vectors to actually allocated irqs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This doesn't apply to net-next.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: igor.russkikh@aquantia.com, pavel.belous@aquantia.com,
	weiyongjun1@huawei.com, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: aquantia: fix unsigned numvecs comparison with less than zero
Date: Thu, 10 May 2018 21:53:58 +0000	[thread overview]
Message-ID: <20180510.175358.1296757435086922873.davem@davemloft.net> (raw)
In-Reply-To: <20180510125201.19707-1-colin.king@canonical.com>

From: Colin King <colin.king@canonical.com>
Date: Thu, 10 May 2018 13:52:01 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The comparison of numvecs < 0 is always false because numvecs is a u32
> and hence the error return from a failed call to pci_alloc_irq_vectores
> is never detected.  Fix this by using the signed int ret to handle the
> error return and assign numvecs to err.
> 
> Detected by CoverityScan, CID#1468650 ("Unsigned compared against 0")
> 
> Fixes: a09bd81b5413 ("net: aquantia: Limit number of vectors to actually allocated irqs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This doesn't apply to net-next.

  parent reply	other threads:[~2018-05-10 21:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 12:52 [PATCH][next] net: aquantia: fix unsigned numvecs comparison with less than zero Colin King
2018-05-10 12:52 ` Colin King
2018-05-10 15:36 ` Igor Russkikh
2018-05-10 15:36   ` Igor Russkikh
2018-05-10 21:53 ` David Miller [this message]
2018-05-10 21:53   ` David Miller
2018-05-11 12:40   ` Igor Russkikh
2018-05-11 12:40     ` Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180510.175358.1296757435086922873.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=colin.king@canonical.com \
    --cc=igor.russkikh@aquantia.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pavel.belous@aquantia.com \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.