* [PATCH] RFT gem_mmap_gtt/gdg Throw in a wmb
@ 2018-05-10 7:47 Chris Wilson
2018-05-10 8:04 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2018-05-10 7:47 UTC (permalink / raw)
To: intel-gfx
---
drivers/gpu/drm/i915/i915_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 89bf5d67cb74..4c26e1fed6c6 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2089,6 +2089,7 @@ int i915_gem_fault(struct vm_fault *vmf)
GEM_BUG_ON(!obj->userfault_count);
i915_vma_set_ggtt_write(vma);
+ wmb();
err_fence:
i915_vma_unpin_fence(vma);
--
2.17.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for RFT gem_mmap_gtt/gdg Throw in a wmb
2018-05-10 7:47 [PATCH] RFT gem_mmap_gtt/gdg Throw in a wmb Chris Wilson
@ 2018-05-10 8:04 ` Patchwork
2018-05-10 8:24 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-05-10 8:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: RFT gem_mmap_gtt/gdg Throw in a wmb
URL : https://patchwork.freedesktop.org/series/42988/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
36ebf10700bc RFT gem_mmap_gtt/gdg Throw in a wmb
-:15: WARNING:MEMORY_BARRIER: memory barrier without comment
#15: FILE: drivers/gpu/drm/i915/i915_gem.c:2092:
+ wmb();
-:18: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 1 warnings, 0 checks, 7 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for RFT gem_mmap_gtt/gdg Throw in a wmb
2018-05-10 7:47 [PATCH] RFT gem_mmap_gtt/gdg Throw in a wmb Chris Wilson
2018-05-10 8:04 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-05-10 8:24 ` Patchwork
2018-05-10 8:26 ` [PATCH] " Chris Wilson
2018-05-10 9:39 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-05-10 8:24 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: RFT gem_mmap_gtt/gdg Throw in a wmb
URL : https://patchwork.freedesktop.org/series/42988/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4163 -> Patchwork_8970 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42988/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_8970 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106248)
igt@kms_frontbuffer_tracking@basic:
{fi-hsw-peppy}: PASS -> DMESG-FAIL (fdo#106103, fdo#102614)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106097)
igt@prime_self_import@basic-with_one_bo_two_files:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#105719)
==== Possible fixes ====
igt@drv_module_reload@basic-reload-inject:
fi-glk-j4005: DMESG-WARN (fdo#106248) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-hsw-4770r: FAIL (fdo#100368) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
== Participating hosts (41 -> 37) ==
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4163 -> Patchwork_8970
CI_DRM_4163: 8e1dab6e913be7d014eb9bc355ec65b6b56dcd56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4468: 548a894dc904c4628522dbbc77cb179a4c965ebc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8970: 36ebf10700bc0ce26ff92db5755f0b649180b00c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4468: 1e60f1499e5b71b6d5a747189d7c28f57359a87f @ git://anongit.freedesktop.org/piglit
== Linux commits ==
36ebf10700bc RFT gem_mmap_gtt/gdg Throw in a wmb
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8970/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] RFT gem_mmap_gtt/gdg Throw in a wmb
2018-05-10 7:47 [PATCH] RFT gem_mmap_gtt/gdg Throw in a wmb Chris Wilson
2018-05-10 8:04 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-05-10 8:24 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-05-10 8:26 ` Chris Wilson
2018-05-10 9:39 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-05-10 8:26 UTC (permalink / raw)
To: intel-gfx
Quoting Chris Wilson (2018-05-10 08:47:31)
> ---
> drivers/gpu/drm/i915/i915_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 89bf5d67cb74..4c26e1fed6c6 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -2089,6 +2089,7 @@ int i915_gem_fault(struct vm_fault *vmf)
> GEM_BUG_ON(!obj->userfault_count);
>
> i915_vma_set_ggtt_write(vma);
> + wmb();
gdg still fails.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for RFT gem_mmap_gtt/gdg Throw in a wmb
2018-05-10 7:47 [PATCH] RFT gem_mmap_gtt/gdg Throw in a wmb Chris Wilson
` (2 preceding siblings ...)
2018-05-10 8:26 ` [PATCH] " Chris Wilson
@ 2018-05-10 9:39 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-05-10 9:39 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: RFT gem_mmap_gtt/gdg Throw in a wmb
URL : https://patchwork.freedesktop.org/series/42988/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4163_full -> Patchwork_8970_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8970_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8970_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42988/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8970_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-bsd2:
shard-kbl: SKIP -> PASS +1
igt@kms_force_connector_basic@force-connector-state:
shard-snb: PASS -> SKIP
igt@kms_properties@plane-properties-legacy:
shard-snb: SKIP -> PASS +4
== Known issues ==
Here are the changes found in Patchwork_8970_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#102887, fdo#105363)
igt@kms_flip@flip-vs-wf_vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#100368)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
shard-apl: PASS -> FAIL (fdo#104724, fdo#103167)
==== Possible fixes ====
igt@kms_flip@absolute-wf_vblank-interruptible:
shard-glk: FAIL (fdo#106087) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-apl: FAIL (fdo#102887, fdo#105363) -> PASS
shard-glk: FAIL (fdo#102887) -> PASS
igt@kms_flip@wf_vblank-ts-check-interruptible:
shard-apl: FAIL (fdo#100368) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106087 https://bugs.freedesktop.org/show_bug.cgi?id=106087
== Participating hosts (9 -> 9) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4163 -> Patchwork_8970
CI_DRM_4163: 8e1dab6e913be7d014eb9bc355ec65b6b56dcd56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4468: 548a894dc904c4628522dbbc77cb179a4c965ebc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8970: 36ebf10700bc0ce26ff92db5755f0b649180b00c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4468: 1e60f1499e5b71b6d5a747189d7c28f57359a87f @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8970/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-10 9:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10 7:47 [PATCH] RFT gem_mmap_gtt/gdg Throw in a wmb Chris Wilson
2018-05-10 8:04 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-05-10 8:24 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-10 8:26 ` [PATCH] " Chris Wilson
2018-05-10 9:39 ` ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.