All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Thomas Tai <thomas.tai@oracle.com>
Cc: mst@redhat.com, jasowang@redhat.com,
	virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org,
	rob.gardner@oracle.com
Subject: Re: [Qemu-devel] [virtio-dev] [PATCH V2 1/1] virtio-balloon: fix internal stat name array to match Linux kernel
Date: Thu, 10 May 2018 09:18:19 +0100	[thread overview]
Message-ID: <20180510081819.GB1296@stefanha-x1.localdomain> (raw)
In-Reply-To: <1525895585-79023-2-git-send-email-thomas.tai@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Wed, May 09, 2018 at 03:53:05PM -0400, Thomas Tai wrote:
> The Linux kernel commit b40000325044 ("virtio_balloon: add array
> of stat names") defines an array of stat name strings for consumers
> of the virtio interface to use via the virtio_balloon.h header
> file, rather than requiring each consumer to define its own. But at
> present, the stat names defined in this array by the Linux kernel
> do not match up with those defined internally by QEMU.
> 
> This patch fixes this inconsistency by importing the header file
> from linux and use the new macro to construct the balloon_stat_names
> array.
> 
> Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
> Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
> Cc: Rob Gardner <rob.gardner@oracle.com>
> ---
>  docs/virtio-balloon-stats.txt                   |  2 ++
>  hw/virtio/virtio-balloon.c                      | 13 ++-----------
>  include/standard-headers/linux/virtio_balloon.h | 19 ++++++++++++++++++-
>  3 files changed, 22 insertions(+), 12 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Thomas Tai <thomas.tai@oracle.com>
Cc: mst@redhat.com, jasowang@redhat.com,
	virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org,
	rob.gardner@oracle.com
Subject: Re: [virtio-dev] [PATCH V2 1/1] virtio-balloon: fix internal stat name array to match Linux kernel
Date: Thu, 10 May 2018 09:18:19 +0100	[thread overview]
Message-ID: <20180510081819.GB1296@stefanha-x1.localdomain> (raw)
In-Reply-To: <1525895585-79023-2-git-send-email-thomas.tai@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Wed, May 09, 2018 at 03:53:05PM -0400, Thomas Tai wrote:
> The Linux kernel commit b40000325044 ("virtio_balloon: add array
> of stat names") defines an array of stat name strings for consumers
> of the virtio interface to use via the virtio_balloon.h header
> file, rather than requiring each consumer to define its own. But at
> present, the stat names defined in this array by the Linux kernel
> do not match up with those defined internally by QEMU.
> 
> This patch fixes this inconsistency by importing the header file
> from linux and use the new macro to construct the balloon_stat_names
> array.
> 
> Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
> Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
> Cc: Rob Gardner <rob.gardner@oracle.com>
> ---
>  docs/virtio-balloon-stats.txt                   |  2 ++
>  hw/virtio/virtio-balloon.c                      | 13 ++-----------
>  include/standard-headers/linux/virtio_balloon.h | 19 ++++++++++++++++++-
>  3 files changed, 22 insertions(+), 12 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  parent reply	other threads:[~2018-05-10  8:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 19:53 [Qemu-devel] [PATCH V2 0/1] virtio-balloon: fix internal stat name array to match Linux kernel Thomas Tai
2018-05-09 19:53 ` [virtio-dev] " Thomas Tai
2018-05-09 19:23 ` [Qemu-devel] " no-reply
2018-05-09 19:53 ` [Qemu-devel] [PATCH V2 1/1] " Thomas Tai
2018-05-09 19:53   ` [virtio-dev] " Thomas Tai
2018-05-10  8:18   ` [Qemu-devel] " Stefan Hajnoczi
2018-05-10  8:18     ` Stefan Hajnoczi
2018-05-10  8:18   ` Stefan Hajnoczi [this message]
2018-05-10  8:18     ` Stefan Hajnoczi
2018-05-10 12:56     ` [Qemu-devel] " Thomas Tai
2018-05-10 12:56       ` Thomas Tai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180510081819.GB1296@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rob.gardner@oracle.com \
    --cc=thomas.tai@oracle.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.