[PATCH] brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag

[PATCH] brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

brcmfmac is a FullMAC driver and it implements/uses cfg80211 interface
for stations management. At the same time it doesn't receive or pass up
management frames.

This flag indicates that authenticator doesn't have to subscribe to or
handle management frames. Some authenticators (e.g. hostapd) were
working with brcmfmac thanks to some extra assumptions. This commit
clears up the situation.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index ff6b3514c501..a400a513dac2 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6512,6 +6512,7 @@ static int brcmf_setup_wiphy(struct wiphy *wiphy, struct brcmf_if *ifp)
 
 	wiphy->flags |= WIPHY_FLAG_NETNS_OK |
 			WIPHY_FLAG_PS_ON_BY_DEFAULT |
+			WIPHY_FLAG_HAVE_AP_SME |
 			WIPHY_FLAG_OFFCHAN_TX |
 			WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL;
 	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_TDLS))
-- 
2.13.6

Re: [PATCH] brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag

[Arend van Spriel]

On 5/10/2018 3:21 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> brcmfmac is a FullMAC driver and it implements/uses cfg80211 interface
> for stations management. At the same time it doesn't receive or pass up
> management frames.
>
> This flag indicates that authenticator doesn't have to subscribe to or
> handle management frames. Some authenticators (e.g. hostapd) were
> working with brcmfmac thanks to some extra assumptions. This commit
> clears up the situation.

Thanks for this patch.

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 1 +
>   1 file changed, 1 insertion(+)

Re: brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag

[Kalle Valo]

Rafał Miłecki wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> brcmfmac is a FullMAC driver and it implements/uses cfg80211 interface
> for stations management. At the same time it doesn't receive or pass up
> management frames.
> 
> This flag indicates that authenticator doesn't have to subscribe to or
> handle management frames. Some authenticators (e.g. hostapd) were
> working with brcmfmac thanks to some extra assumptions. This commit
> clears up the situation.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Patch applied to wireless-drivers-next.git, thanks.

1204aa17f3b4 brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag

-- 
https://patchwork.kernel.org/patch/10391817/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches