* [PATCH] mtd: Fix comparison in map_word_andequal()
@ 2018-05-10 18:20 Ben Hutchings
2018-05-12 15:16 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2018-05-10 18:20 UTC (permalink / raw)
To: linux-mtd
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
Commit 9e343e87d2c4 ("mtd: cfi: convert inline functions to macros")
changed map_word_andequal() into a macro, but also changed the right
hand side of the comparison from val3 to val2. Change it back to use
val3 on the right hand side.
Thankfully this did not cause a regression because all callers
currently pass the same argument for val2 and val3.
Fixes: 9e343e87d2c4 ("mtd: cfi: convert inline functions to macros")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
include/linux/mtd/map.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h
index b5b43f94f311..01b990e4b228 100644
--- a/include/linux/mtd/map.h
+++ b/include/linux/mtd/map.h
@@ -312,7 +312,7 @@ void map_destroy(struct mtd_info *mtd);
({ \
int i, ret = 1; \
for (i = 0; i < map_words(map); i++) { \
- if (((val1).x[i] & (val2).x[i]) != (val2).x[i]) { \
+ if (((val1).x[i] & (val2).x[i]) != (val3).x[i]) { \
ret = 0; \
break; \
} \
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: Fix comparison in map_word_andequal()
2018-05-10 18:20 [PATCH] mtd: Fix comparison in map_word_andequal() Ben Hutchings
@ 2018-05-12 15:16 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2018-05-12 15:16 UTC (permalink / raw)
To: Ben Hutchings; +Cc: linux-mtd
On Thu, 10 May 2018 19:20:54 +0100
Ben Hutchings <ben@decadent.org.uk> wrote:
> Commit 9e343e87d2c4 ("mtd: cfi: convert inline functions to macros")
> changed map_word_andequal() into a macro, but also changed the right
> hand side of the comparison from val3 to val2. Change it back to use
> val3 on the right hand side.
>
> Thankfully this did not cause a regression because all callers
> currently pass the same argument for val2 and val3.
>
> Fixes: 9e343e87d2c4 ("mtd: cfi: convert inline functions to macros")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Applied.
Thanks,
Boris
> ---
> include/linux/mtd/map.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h
> index b5b43f94f311..01b990e4b228 100644
> --- a/include/linux/mtd/map.h
> +++ b/include/linux/mtd/map.h
> @@ -312,7 +312,7 @@ void map_destroy(struct mtd_info *mtd);
> ({ \
> int i, ret = 1; \
> for (i = 0; i < map_words(map); i++) { \
> - if (((val1).x[i] & (val2).x[i]) != (val2).x[i]) { \
> + if (((val1).x[i] & (val2).x[i]) != (val3).x[i]) { \
> ret = 0; \
> break; \
> } \
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-12 15:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10 18:20 [PATCH] mtd: Fix comparison in map_word_andequal() Ben Hutchings
2018-05-12 15:16 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.