[PATCH] recipes-graphics/libsdl2: Add native and nativesdk support

[PATCH] recipes-graphics/libsdl2: Add native and nativesdk support

[Alistair Francis]

Allow building libsdl2 for native and nativesdk. This is required to use
libsdl2 in QEMU.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
index c0cf70d7fd..36508ec349 100644
--- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
+++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
@@ -42,6 +42,11 @@ PACKAGECONFIG ??= " \
     ${@bb.utils.filter('DISTRO_FEATURES', 'alsa directfb pulseaudio x11', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland gles2', '', d)} \
 "
+PACKAGECONFIG_class-native = "${PACKAGECONFIG_GL} x11"
+PACKAGECONFIG_class-nativesdk = "${PACKAGECONFIG_GL} \
+                                 ${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)} \
+"
+
 PACKAGECONFIG[alsa]       = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib,"
 PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb"
 PACKAGECONFIG[gles2]      = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
@@ -63,3 +68,5 @@ do_configure_prepend() {
 }
 
 FILES_${PN}-dev += "${libdir}/cmake"
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.17.0

Re: [PATCH] recipes-graphics/libsdl2: Add native and nativesdk support

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2224 bytes --]

See http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/qemu
 + http://git.openembedded.org/meta-openembedded-contrib/log/?h=jansa/spice
for more qemu related changes.

More info:
http://lists.openembedded.org/pipermail/openembedded-core/2017-September/142349.html

and that's basically where I'm still stuck (and why haven't sent most of
these patches yet), because it works fine "natively" but when the
qemu-native is running inside of chroot or docker, I didn't get the
acceleration working (from virt-viewer running "natively" - outside
chroot/docker).

I plan to separate libsdl2 changes from this and send them with updated
qemu upgrade as discussed with Ross.

On Thu, May 10, 2018 at 11:31 PM Alistair Francis <alistair.francis@wdc.com>
wrote:

> Allow building libsdl2 for native and nativesdk. This is required to use
> libsdl2 in QEMU.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> index c0cf70d7fd..36508ec349 100644
> --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> @@ -42,6 +42,11 @@ PACKAGECONFIG ??= " \
>      ${@bb.utils.filter('DISTRO_FEATURES', 'alsa directfb pulseaudio x11',
> d)} \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland gles2',
> '', d)} \
>  "
> +PACKAGECONFIG_class-native = "${PACKAGECONFIG_GL} x11"
> +PACKAGECONFIG_class-nativesdk = "${PACKAGECONFIG_GL} \
> +                                 ${@bb.utils.filter('DISTRO_FEATURES',
> 'x11', d)} \
> +"
> +
>  PACKAGECONFIG[alsa]       = "--enable-alsa
> --disable-alsatest,--disable-alsa,alsa-lib,"
>  PACKAGECONFIG[directfb]   =
> "--enable-video-directfb,--disable-video-directfb,directfb"
>  PACKAGECONFIG[gles2]      =
> "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
> @@ -63,3 +68,5 @@ do_configure_prepend() {
>  }
>
>  FILES_${PN}-dev += "${libdir}/cmake"
> +
> +BBCLASSEXTEND = "native nativesdk"
> --
> 2.17.0
>
>

[-- Attachment #2: Type: text/html, Size: 3501 bytes --]

Re: [PATCH] recipes-graphics/libsdl2: Add native and nativesdk support

[Alistair Francis]

On Thu, May 10, 2018 at 2:58 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> See http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/qemu
> + http://git.openembedded.org/meta-openembedded-contrib/log/?h=jansa/spice
> for more qemu related changes.
>
> More info:
> http://lists.openembedded.org/pipermail/openembedded-core/2017-September/142349.html
>
> and that's basically where I'm still stuck (and why haven't sent most of
> these patches yet), because it works fine "natively" but when the
> qemu-native is running inside of chroot or docker, I didn't get the
> acceleration working (from virt-viewer running "natively" - outside
> chroot/docker).
>
> I plan to separate libsdl2 changes from this and send them with updated qemu
> upgrade as discussed with Ross.

It looks like you beat me to it. Plus your patches look better then mine :)

It would be great if you could send the QEMU 2.12 patches seperatly.
Can you CC me when you do?

Alistair

>
> On Thu, May 10, 2018 at 11:31 PM Alistair Francis <alistair.francis@wdc.com>
> wrote:
>>
>> Allow building libsdl2 for native and nativesdk. This is required to use
>> libsdl2 in QEMU.
>>
>> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>> ---
>>  meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> index c0cf70d7fd..36508ec349 100644
>> --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> @@ -42,6 +42,11 @@ PACKAGECONFIG ??= " \
>>      ${@bb.utils.filter('DISTRO_FEATURES', 'alsa directfb pulseaudio x11',
>> d)} \
>>      ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland gles2',
>> '', d)} \
>>  "
>> +PACKAGECONFIG_class-native = "${PACKAGECONFIG_GL} x11"
>> +PACKAGECONFIG_class-nativesdk = "${PACKAGECONFIG_GL} \
>> +                                 ${@bb.utils.filter('DISTRO_FEATURES',
>> 'x11', d)} \
>> +"
>> +
>>  PACKAGECONFIG[alsa]       = "--enable-alsa
>> --disable-alsatest,--disable-alsa,alsa-lib,"
>>  PACKAGECONFIG[directfb]   =
>> "--enable-video-directfb,--disable-video-directfb,directfb"
>>  PACKAGECONFIG[gles2]      =
>> "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
>> @@ -63,3 +68,5 @@ do_configure_prepend() {
>>  }
>>
>>  FILES_${PN}-dev += "${libdir}/cmake"
>> +
>> +BBCLASSEXTEND = "native nativesdk"
>> --
>> 2.17.0
>>
>

Re: [PATCH] recipes-graphics/libsdl2: Add native and nativesdk support

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3119 bytes --]

On Thu, May 10, 2018 at 03:06:47PM -0700, Alistair Francis wrote:
> On Thu, May 10, 2018 at 2:58 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > See http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/qemu
> > + http://git.openembedded.org/meta-openembedded-contrib/log/?h=jansa/spice
> > for more qemu related changes.
> >
> > More info:
> > http://lists.openembedded.org/pipermail/openembedded-core/2017-September/142349.html
> >
> > and that's basically where I'm still stuck (and why haven't sent most of
> > these patches yet), because it works fine "natively" but when the
> > qemu-native is running inside of chroot or docker, I didn't get the
> > acceleration working (from virt-viewer running "natively" - outside
> > chroot/docker).
> >
> > I plan to separate libsdl2 changes from this and send them with updated qemu
> > upgrade as discussed with Ross.
> 
> It looks like you beat me to it. Plus your patches look better then mine :)
> 
> It would be great if you could send the QEMU 2.12 patches seperatly.
> Can you CC me when you do?

I've forgot to CC you, but the 2 patchsets I've sent today are:
http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150717.html
http://lists.openembedded.org/pipermail/openembedded-devel/2018-May/118144.html

that leaves only virglrenderer and glx support in jansa/qemu branch.

> >
> > On Thu, May 10, 2018 at 11:31 PM Alistair Francis <alistair.francis@wdc.com>
> > wrote:
> >>
> >> Allow building libsdl2 for native and nativesdk. This is required to use
> >> libsdl2 in QEMU.
> >>
> >> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> >> ---
> >>  meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> >> b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> >> index c0cf70d7fd..36508ec349 100644
> >> --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> >> +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> >> @@ -42,6 +42,11 @@ PACKAGECONFIG ??= " \
> >>      ${@bb.utils.filter('DISTRO_FEATURES', 'alsa directfb pulseaudio x11',
> >> d)} \
> >>      ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland gles2',
> >> '', d)} \
> >>  "
> >> +PACKAGECONFIG_class-native = "${PACKAGECONFIG_GL} x11"
> >> +PACKAGECONFIG_class-nativesdk = "${PACKAGECONFIG_GL} \
> >> +                                 ${@bb.utils.filter('DISTRO_FEATURES',
> >> 'x11', d)} \
> >> +"
> >> +
> >>  PACKAGECONFIG[alsa]       = "--enable-alsa
> >> --disable-alsatest,--disable-alsa,alsa-lib,"
> >>  PACKAGECONFIG[directfb]   =
> >> "--enable-video-directfb,--disable-video-directfb,directfb"
> >>  PACKAGECONFIG[gles2]      =
> >> "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
> >> @@ -63,3 +68,5 @@ do_configure_prepend() {
> >>  }
> >>
> >>  FILES_${PN}-dev += "${libdir}/cmake"
> >> +
> >> +BBCLASSEXTEND = "native nativesdk"
> >> --
> >> 2.17.0
> >>
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [PATCH] recipes-graphics/libsdl2: Add native and nativesdk support

[Alistair Francis]

On Fri, May 11, 2018 at 12:44 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, May 10, 2018 at 03:06:47PM -0700, Alistair Francis wrote:
>> On Thu, May 10, 2018 at 2:58 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> > See http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/qemu
>> > + http://git.openembedded.org/meta-openembedded-contrib/log/?h=jansa/spice
>> > for more qemu related changes.
>> >
>> > More info:
>> > http://lists.openembedded.org/pipermail/openembedded-core/2017-September/142349.html
>> >
>> > and that's basically where I'm still stuck (and why haven't sent most of
>> > these patches yet), because it works fine "natively" but when the
>> > qemu-native is running inside of chroot or docker, I didn't get the
>> > acceleration working (from virt-viewer running "natively" - outside
>> > chroot/docker).
>> >
>> > I plan to separate libsdl2 changes from this and send them with updated qemu
>> > upgrade as discussed with Ross.
>>
>> It looks like you beat me to it. Plus your patches look better then mine :)
>>
>> It would be great if you could send the QEMU 2.12 patches seperatly.
>> Can you CC me when you do?
>
> I've forgot to CC you, but the 2 patchsets I've sent today are:
> http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150717.html
> http://lists.openembedded.org/pipermail/openembedded-devel/2018-May/118144.html
>
> that leaves only virglrenderer and glx support in jansa/qemu branch.

Great, Thanks. I have reviewed them, although I'm not sure if that
matters for this project.

Alistair

>
>> >
>> > On Thu, May 10, 2018 at 11:31 PM Alistair Francis <alistair.francis@wdc.com>
>> > wrote:
>> >>
>> >> Allow building libsdl2 for native and nativesdk. This is required to use
>> >> libsdl2 in QEMU.
>> >>
>> >> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>> >> ---
>> >>  meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb | 7 +++++++
>> >>  1 file changed, 7 insertions(+)
>> >>
>> >> diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> >> b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> >> index c0cf70d7fd..36508ec349 100644
>> >> --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> >> +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> >> @@ -42,6 +42,11 @@ PACKAGECONFIG ??= " \
>> >>      ${@bb.utils.filter('DISTRO_FEATURES', 'alsa directfb pulseaudio x11',
>> >> d)} \
>> >>      ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland gles2',
>> >> '', d)} \
>> >>  "
>> >> +PACKAGECONFIG_class-native = "${PACKAGECONFIG_GL} x11"
>> >> +PACKAGECONFIG_class-nativesdk = "${PACKAGECONFIG_GL} \
>> >> +                                 ${@bb.utils.filter('DISTRO_FEATURES',
>> >> 'x11', d)} \
>> >> +"
>> >> +
>> >>  PACKAGECONFIG[alsa]       = "--enable-alsa
>> >> --disable-alsatest,--disable-alsa,alsa-lib,"
>> >>  PACKAGECONFIG[directfb]   =
>> >> "--enable-video-directfb,--disable-video-directfb,directfb"
>> >>  PACKAGECONFIG[gles2]      =
>> >> "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
>> >> @@ -63,3 +68,5 @@ do_configure_prepend() {
>> >>  }
>> >>
>> >>  FILES_${PN}-dev += "${libdir}/cmake"
>> >> +
>> >> +BBCLASSEXTEND = "native nativesdk"
>> >> --
>> >> 2.17.0
>> >>
>> >
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com