From: Keith Busch <keith.busch@linux.intel.com> To: Ming Lei <ming.lei@redhat.com> Cc: Jens Axboe <axboe@kernel.dk>, linux-block <linux-block@vger.kernel.org>, Sagi Grimberg <sagi@grimberg.me>, Ming Lei <tom.leiming@gmail.com>, linux-nvme <linux-nvme@lists.infradead.org>, Keith Busch <keith.busch@intel.com>, Jianchao Wang <jianchao.w.wang@oracle.com>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH 1/2] nvme: pci: simplify timeout handling Date: Thu, 10 May 2018 15:44:41 -0600 [thread overview] Message-ID: <20180510214441.GD4787@localhost.localdomain> (raw) In-Reply-To: <20180510212444.GC3515@ming.t460p> On Fri, May 11, 2018 at 05:24:46AM +0800, Ming Lei wrote: > Could you share me the link? The diff was in this reply here: http://lists.infradead.org/pipermail/linux-nvme/2018-April/017019.html > Firstly, the previous nvme_sync_queues() won't work reliably, so this > patch introduces blk_unquiesce_timeout() and blk_quiesce_timeout() for > this purpose. > > Secondly, I remembered that you only call nvme_sync_queues() at the > entry of nvme_reset_work(), but timeout(either admin or normal IO) > can happen again during resetting, that is another race addressed by > this patchset, but can't cover by your proposal. I sync the queues at the beginning because it ensures there is not a single in flight request for the entire controller (all namespaces plus admin queue) before transitioning to the connecting state. If a command times out during connecting state, we go to the dead state.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@linux.intel.com (Keith Busch) Subject: [PATCH 1/2] nvme: pci: simplify timeout handling Date: Thu, 10 May 2018 15:44:41 -0600 [thread overview] Message-ID: <20180510214441.GD4787@localhost.localdomain> (raw) In-Reply-To: <20180510212444.GC3515@ming.t460p> On Fri, May 11, 2018@05:24:46AM +0800, Ming Lei wrote: > Could you share me the link? The diff was in this reply here: http://lists.infradead.org/pipermail/linux-nvme/2018-April/017019.html > Firstly, the previous nvme_sync_queues() won't work reliably, so this > patch introduces blk_unquiesce_timeout() and blk_quiesce_timeout() for > this purpose. > > Secondly, I remembered that you only call nvme_sync_queues() at the > entry of nvme_reset_work(), but timeout(either admin or normal IO) > can happen again during resetting, that is another race addressed by > this patchset, but can't cover by your proposal. I sync the queues at the beginning because it ensures there is not a single in flight request for the entire controller (all namespaces plus admin queue) before transitioning to the connecting state. If a command times out during connecting state, we go to the dead state.
next prev parent reply other threads:[~2018-05-10 21:44 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-26 12:39 [PATCH 0/2] nvme: pci: fix & improve timeout handling Ming Lei 2018-04-26 12:39 ` Ming Lei 2018-04-26 12:39 ` [PATCH 1/2] nvme: pci: simplify " Ming Lei 2018-04-26 12:39 ` Ming Lei 2018-04-26 15:07 ` jianchao.wang 2018-04-26 15:07 ` jianchao.wang 2018-04-26 15:57 ` Ming Lei 2018-04-26 15:57 ` Ming Lei 2018-04-26 16:16 ` Ming Lei 2018-04-26 16:16 ` Ming Lei 2018-04-27 1:37 ` jianchao.wang 2018-04-27 1:37 ` jianchao.wang 2018-04-27 14:57 ` Ming Lei 2018-04-27 14:57 ` Ming Lei 2018-04-28 14:00 ` jianchao.wang 2018-04-28 14:00 ` jianchao.wang 2018-04-28 21:57 ` Ming Lei 2018-04-28 21:57 ` Ming Lei 2018-04-28 22:27 ` Ming Lei 2018-04-28 22:27 ` Ming Lei 2018-04-29 1:36 ` Ming Lei 2018-04-29 1:36 ` Ming Lei 2018-04-29 2:21 ` jianchao.wang 2018-04-29 2:21 ` jianchao.wang 2018-04-29 14:13 ` Ming Lei 2018-04-29 14:13 ` Ming Lei 2018-04-27 17:51 ` Keith Busch 2018-04-27 17:51 ` Keith Busch 2018-04-28 3:50 ` Ming Lei 2018-04-28 3:50 ` Ming Lei 2018-04-28 13:35 ` Keith Busch 2018-04-28 13:35 ` Keith Busch 2018-04-28 14:31 ` jianchao.wang 2018-04-28 14:31 ` jianchao.wang 2018-04-28 21:39 ` Ming Lei 2018-04-28 21:39 ` Ming Lei 2018-04-30 19:52 ` Keith Busch 2018-04-30 19:52 ` Keith Busch 2018-04-30 23:14 ` Ming Lei 2018-04-30 23:14 ` Ming Lei 2018-05-08 15:30 ` Keith Busch 2018-05-08 15:30 ` Keith Busch 2018-05-10 20:52 ` Ming Lei 2018-05-10 20:52 ` Ming Lei 2018-05-10 21:05 ` Keith Busch 2018-05-10 21:05 ` Keith Busch 2018-05-10 21:10 ` Ming Lei 2018-05-10 21:10 ` Ming Lei 2018-05-10 21:18 ` Keith Busch 2018-05-10 21:18 ` Keith Busch 2018-05-10 21:24 ` Ming Lei 2018-05-10 21:24 ` Ming Lei 2018-05-10 21:44 ` Keith Busch [this message] 2018-05-10 21:44 ` Keith Busch 2018-05-10 21:50 ` Ming Lei 2018-05-10 21:50 ` Ming Lei 2018-05-10 21:53 ` Ming Lei 2018-05-10 21:53 ` Ming Lei 2018-05-10 22:03 ` Ming Lei 2018-05-10 22:03 ` Ming Lei 2018-05-10 22:43 ` Keith Busch 2018-05-10 22:43 ` Keith Busch 2018-05-11 0:14 ` Ming Lei 2018-05-11 0:14 ` Ming Lei 2018-05-11 2:10 ` Ming Lei 2018-05-11 2:10 ` Ming Lei 2018-04-26 12:39 ` [PATCH 2/2] nvme: pci: guarantee EH can make progress Ming Lei 2018-04-26 12:39 ` Ming Lei 2018-04-26 16:24 ` Keith Busch 2018-04-26 16:24 ` Keith Busch 2018-04-28 3:28 ` Ming Lei 2018-04-28 3:28 ` Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180510214441.GD4787@localhost.localdomain \ --to=keith.busch@linux.intel.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=jianchao.w.wang@oracle.com \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=ming.lei@redhat.com \ --cc=sagi@grimberg.me \ --cc=tom.leiming@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.