* [cifs:for-next 12/12] fs/cifs/cifsfs.c:1056:5: sparse: symbol 'cifs_dir_fsync' was not declared. Should it be static?
@ 2018-05-11 0:50 kbuild test robot
2018-05-11 0:50 ` [RFC PATCH cifs] smb3: cifs_dir_fsync() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-05-11 0:50 UTC (permalink / raw)
To: Steve French
Cc: kbuild-all, linux-cifs, samba-technical, Ronnie Sahlberg,
Pavel Shilovsky, linux-kernel
tree: git://git.samba.org/sfrench/cifs-2.6.git for-next
head: c3d5c2a93abfc181d9f274dd5e4b18749dc0643f
commit: c3d5c2a93abfc181d9f274dd5e4b18749dc0643f [12/12] smb3: directory sync should not return an error
reproduce:
# apt-get install sparse
git checkout c3d5c2a93abfc181d9f274dd5e4b18749dc0643f
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
fs/cifs/cifsglob.h:1653:41: sparse: symbol 'cifs_tcp_ses_list' was not declared. Should it be static?
fs/cifs/cifsglob.h:1664:41: sparse: symbol 'cifs_tcp_ses_lock' was not declared. Should it be static?
fs/cifs/cifsglob.h:1676:28: sparse: symbol 'GlobalCurrentXid' was not declared. Should it be static?
fs/cifs/cifsglob.h:1677:28: sparse: symbol 'GlobalTotalActiveXid' was not declared. Should it be static?
fs/cifs/cifsglob.h:1678:28: sparse: symbol 'GlobalMaxActiveXid' was not declared. Should it be static?
fs/cifs/cifsglob.h:1679:26: sparse: symbol 'GlobalMid_Lock' was not declared. Should it be static?
fs/cifs/cifsglob.h:1684:24: sparse: symbol 'sesInfoAllocCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1685:24: sparse: symbol 'tconInfoAllocCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1686:24: sparse: symbol 'tcpSesAllocCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1687:24: sparse: symbol 'tcpSesReconnectCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1688:24: sparse: symbol 'tconInfoReconnectCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1691:24: sparse: symbol 'bufAllocCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1693:24: sparse: symbol 'totBufAllocCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1694:24: sparse: symbol 'totSmBufAllocCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1696:24: sparse: symbol 'smBufAllocCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1697:24: sparse: symbol 'midCount' was not declared. Should it be static?
fs/cifs/cifsglob.h:1700:20: sparse: symbol 'enable_oplocks' was not declared. Should it be static?
fs/cifs/cifsglob.h:1701:20: sparse: symbol 'lookupCacheEnabled' was not declared. Should it be static?
fs/cifs/cifsglob.h:1702:28: sparse: symbol 'global_secflags' was not declared. Should it be static?
fs/cifs/cifsglob.h:1704:28: sparse: symbol 'sign_CIFS_PDUs' was not declared. Should it be static?
fs/cifs/cifsglob.h:1705:20: sparse: symbol 'linuxExtEnabled' was not declared. Should it be static?
fs/cifs/cifsglob.h:1706:28: sparse: symbol 'CIFSMaxBufSize' was not declared. Should it be static?
fs/cifs/cifsglob.h:1707:28: sparse: symbol 'cifs_min_rcv' was not declared. Should it be static?
fs/cifs/cifsglob.h:1708:28: sparse: symbol 'cifs_min_small' was not declared. Should it be static?
fs/cifs/cifsglob.h:1709:28: sparse: symbol 'cifs_max_pending' was not declared. Should it be static?
fs/cifs/cifsglob.h:1712:30: sparse: symbol 'uidtree' was not declared. Should it be static?
fs/cifs/cifsglob.h:1713:30: sparse: symbol 'gidtree' was not declared. Should it be static?
fs/cifs/cifsglob.h:1714:26: sparse: symbol 'siduidlock' was not declared. Should it be static?
fs/cifs/cifsglob.h:1715:26: sparse: symbol 'sidgidlock' was not declared. Should it be static?
fs/cifs/cifsglob.h:1716:30: sparse: symbol 'siduidtree' was not declared. Should it be static?
fs/cifs/cifsglob.h:1717:30: sparse: symbol 'sidgidtree' was not declared. Should it be static?
fs/cifs/cifsglob.h:1718:26: sparse: symbol 'uidsidlock' was not declared. Should it be static?
fs/cifs/cifsglob.h:1719:26: sparse: symbol 'gidsidlock' was not declared. Should it be static?
>> fs/cifs/cifsfs.c:1056:5: sparse: symbol 'cifs_dir_fsync' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* [RFC PATCH cifs] smb3: cifs_dir_fsync() can be static
2018-05-11 0:50 [cifs:for-next 12/12] fs/cifs/cifsfs.c:1056:5: sparse: symbol 'cifs_dir_fsync' was not declared. Should it be static? kbuild test robot
@ 2018-05-11 0:50 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-05-11 0:50 UTC (permalink / raw)
To: Steve French
Cc: kbuild-all, linux-cifs, samba-technical, Ronnie Sahlberg,
Pavel Shilovsky, linux-kernel
Fixes: c3d5c2a93abf ("smb3: directory sync should not return an error")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
cifsfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 8e41186..62f1662 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -1053,7 +1053,7 @@ ssize_t cifs_file_copychunk_range(unsigned int xid,
* Directory operations under CIFS/SMB2/SMB3 are synchronous, so fsync()
* is a dummy operation.
*/
-int cifs_dir_fsync(struct file *file, loff_t start, loff_t end, int datasync)
+static int cifs_dir_fsync(struct file *file, loff_t start, loff_t end, int datasync)
{
cifs_dbg(FYI, "Sync directory - name: %pD datasync: 0x%x\n",
file, datasync);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-11 0:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-11 0:50 [cifs:for-next 12/12] fs/cifs/cifsfs.c:1056:5: sparse: symbol 'cifs_dir_fsync' was not declared. Should it be static? kbuild test robot
2018-05-11 0:50 ` [RFC PATCH cifs] smb3: cifs_dir_fsync() can be static kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.