* [U-Boot] [PATCH 1/1] tools/file2include: avoid incorrect comments
@ 2018-05-07 21:00 Heinrich Schuchardt
2018-05-11 11:08 ` [U-Boot] [U-Boot, " Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2018-05-07 21:00 UTC (permalink / raw)
To: u-boot
Avoid creating incorrect comments like /* ...*/... */ by printing
'.' instead of '*' inside comments.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
tools/file2include.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/file2include.c b/tools/file2include.c
index e602f937f15..b98af30a728 100644
--- a/tools/file2include.c
+++ b/tools/file2include.c
@@ -84,7 +84,7 @@ int main(int argc, char *argv[])
printf("\\x%02x", buf[j]);
printf("\"}, /* ");
for (j = i; j < i + BLOCK_SIZE && j < count; ++j) {
- if (buf[j] >= 0x20 && buf[j] <= 0x7e)
+ if (buf[j] != '*' && buf[j] >= 0x20 && buf[j] <= 0x7e)
printf("%c", buf[j]);
else
printf(".");
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [U-Boot, 1/1] tools/file2include: avoid incorrect comments
2018-05-07 21:00 [U-Boot] [PATCH 1/1] tools/file2include: avoid incorrect comments Heinrich Schuchardt
@ 2018-05-11 11:08 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-05-11 11:08 UTC (permalink / raw)
To: u-boot
On Mon, May 07, 2018 at 11:00:22PM +0200, Heinrich Schuchardt wrote:
> Avoid creating incorrect comments like /* ...*/... */ by printing
> '.' instead of '*' inside comments.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180511/002ba160/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-11 11:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 21:00 [U-Boot] [PATCH 1/1] tools/file2include: avoid incorrect comments Heinrich Schuchardt
2018-05-11 11:08 ` [U-Boot] [U-Boot, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.