All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] ARM: davinci: some dm646x related fixes
@ 2018-05-11 15:21 Sekhar Nori
  2018-05-11 15:21 ` [PATCH 1/3] ARM: davinci: dm646x: fix timer interrupt generation Sekhar Nori
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Sekhar Nori @ 2018-05-11 15:21 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

Here are some DM646x related fixes for issues I found
while testing the platform.

Sekhar Nori (3):
  ARM: davinci: dm646x: fix timer interrupt generation
  ARM: davinci: board-dm646x-evm: pass correct I2C adapter id for VPIF
  ARM: davinci: board-dm646x-evm: set VPIF capture card name

 arch/arm/mach-davinci/board-dm646x-evm.c | 5 ++++-
 arch/arm/mach-davinci/dm646x.c           | 3 ++-
 2 files changed, 6 insertions(+), 2 deletions(-)

-- 
2.16.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] ARM: davinci: dm646x: fix timer interrupt generation
  2018-05-11 15:21 [PATCH 0/3] ARM: davinci: some dm646x related fixes Sekhar Nori
@ 2018-05-11 15:21 ` Sekhar Nori
  2018-05-11 15:21 ` [PATCH 2/3] ARM: davinci: board-dm646x-evm: pass correct I2C adapter id for VPIF Sekhar Nori
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Sekhar Nori @ 2018-05-11 15:21 UTC (permalink / raw)
  To: linux-arm-kernel

commit b38434145b34 ("ARM: davinci: irqs: Correct McASP1 TX
interrupt definition for DM646x") inadvertently removed
setting for priority for timer0_12 (bottom half of timer0).
This timer is used as clockevent.

When INTPRIn register setting for an interrupt is left at 0,
it is mapped to FIQ by the AINTC causing the timer interrupt to
not get generated.

Fix it by including an entry for timer0_12 in interrupt
priority map array. While at it, move the clockevent comment to
the right place.

Fixes: b38434145b34 ("ARM: davinci: irqs: Correct McASP1 TX interrupt definition for DM646x")
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/mach-davinci/dm646x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-davinci/dm646x.c b/arch/arm/mach-davinci/dm646x.c
index 54a4299030de..6bd2ed069d0d 100644
--- a/arch/arm/mach-davinci/dm646x.c
+++ b/arch/arm/mach-davinci/dm646x.c
@@ -178,7 +178,8 @@ static u8 dm646x_default_priorities[DAVINCI_N_AINTC_IRQ] = {
 	[IRQ_DM646X_MCASP0TXINT]        = 7,
 	[IRQ_DM646X_MCASP0RXINT]        = 7,
 	[IRQ_DM646X_RESERVED_3]         = 7,
-	[IRQ_DM646X_MCASP1TXINT]        = 7,    /* clockevent */
+	[IRQ_DM646X_MCASP1TXINT]        = 7,
+	[IRQ_TINT0_TINT12]              = 7,    /* clockevent */
 	[IRQ_TINT0_TINT34]              = 7,    /* clocksource */
 	[IRQ_TINT1_TINT12]              = 7,    /* DSP timer */
 	[IRQ_TINT1_TINT34]              = 7,    /* system tick */
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] ARM: davinci: board-dm646x-evm: pass correct I2C adapter id for VPIF
  2018-05-11 15:21 [PATCH 0/3] ARM: davinci: some dm646x related fixes Sekhar Nori
  2018-05-11 15:21 ` [PATCH 1/3] ARM: davinci: dm646x: fix timer interrupt generation Sekhar Nori
@ 2018-05-11 15:21 ` Sekhar Nori
  2018-05-11 15:21 ` [PATCH 3/3] ARM: davinci: board-dm646x-evm: set VPIF capture card name Sekhar Nori
  2018-05-15  9:22 ` [PATCH 0/3] ARM: davinci: some dm646x related fixes Sekhar Nori
  3 siblings, 0 replies; 5+ messages in thread
From: Sekhar Nori @ 2018-05-11 15:21 UTC (permalink / raw)
  To: linux-arm-kernel

commit a16cb91ad9c4 ("[media] media: vpif: use a configurable
i2c_adapter_id for vpif display") removed hardcoded I2C adaptor
setting in VPIF driver, but missed updating platform data passed
from DM646x board.

Fix it.

Fixes: a16cb91ad9c4 ("[media] media: vpif: use a configurable i2c_adapter_id for vpif display")
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/mach-davinci/board-dm646x-evm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
index 37c9e0ee4dcc..bf6f85048d17 100644
--- a/arch/arm/mach-davinci/board-dm646x-evm.c
+++ b/arch/arm/mach-davinci/board-dm646x-evm.c
@@ -533,6 +533,7 @@ static struct vpif_display_config dm646x_vpif_display_config = {
 	.set_clock	= set_vpif_clock,
 	.subdevinfo	= dm646x_vpif_subdev,
 	.subdev_count	= ARRAY_SIZE(dm646x_vpif_subdev),
+	.i2c_adapter_id = 1,
 	.chan_config[0] = {
 		.outputs = dm6467_ch0_outputs,
 		.output_count = ARRAY_SIZE(dm6467_ch0_outputs),
@@ -675,6 +676,7 @@ static struct vpif_capture_config dm646x_vpif_capture_cfg = {
 	.setup_input_channel_mode = setup_vpif_input_channel_mode,
 	.subdev_info = vpif_capture_sdev_info,
 	.subdev_count = ARRAY_SIZE(vpif_capture_sdev_info),
+	.i2c_adapter_id = 1,
 	.chan_config[0] = {
 		.inputs = dm6467_ch0_inputs,
 		.input_count = ARRAY_SIZE(dm6467_ch0_inputs),
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] ARM: davinci: board-dm646x-evm: set VPIF capture card name
  2018-05-11 15:21 [PATCH 0/3] ARM: davinci: some dm646x related fixes Sekhar Nori
  2018-05-11 15:21 ` [PATCH 1/3] ARM: davinci: dm646x: fix timer interrupt generation Sekhar Nori
  2018-05-11 15:21 ` [PATCH 2/3] ARM: davinci: board-dm646x-evm: pass correct I2C adapter id for VPIF Sekhar Nori
@ 2018-05-11 15:21 ` Sekhar Nori
  2018-05-15  9:22 ` [PATCH 0/3] ARM: davinci: some dm646x related fixes Sekhar Nori
  3 siblings, 0 replies; 5+ messages in thread
From: Sekhar Nori @ 2018-05-11 15:21 UTC (permalink / raw)
  To: linux-arm-kernel

VPIF capture driver expects card name to be set since it
uses it without checking for NULL. The commit which
introduced VPIF display and capture support added card
name only for display, not for capture.

Set it in platform data to probe driver successfully.

While at it, also fix the display card name to something more
appropriate.

Fixes: 85609c1ccda6 ("DaVinci: DM646x - platform changes for vpif capture and display drivers")
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/mach-davinci/board-dm646x-evm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
index bf6f85048d17..867ab2fa6cfd 100644
--- a/arch/arm/mach-davinci/board-dm646x-evm.c
+++ b/arch/arm/mach-davinci/board-dm646x-evm.c
@@ -538,7 +538,7 @@ static struct vpif_display_config dm646x_vpif_display_config = {
 		.outputs = dm6467_ch0_outputs,
 		.output_count = ARRAY_SIZE(dm6467_ch0_outputs),
 	},
-	.card_name	= "DM646x EVM",
+	.card_name	= "DM646x EVM Video Display",
 };
 
 /**
@@ -697,6 +697,7 @@ static struct vpif_capture_config dm646x_vpif_capture_cfg = {
 			.fid_pol = 0,
 		},
 	},
+	.card_name = "DM646x EVM Video Capture",
 };
 
 static void __init evm_init_video(void)
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 0/3] ARM: davinci: some dm646x related fixes
  2018-05-11 15:21 [PATCH 0/3] ARM: davinci: some dm646x related fixes Sekhar Nori
                   ` (2 preceding siblings ...)
  2018-05-11 15:21 ` [PATCH 3/3] ARM: davinci: board-dm646x-evm: set VPIF capture card name Sekhar Nori
@ 2018-05-15  9:22 ` Sekhar Nori
  3 siblings, 0 replies; 5+ messages in thread
From: Sekhar Nori @ 2018-05-15  9:22 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 11 May 2018 08:51 PM, Sekhar Nori wrote:
> Hi,
> 
> Here are some DM646x related fixes for issues I found
> while testing the platform.

Applied and pull request to ARM-SoC maintainers sent.

Thanks,
Sekhar

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-05-15  9:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-11 15:21 [PATCH 0/3] ARM: davinci: some dm646x related fixes Sekhar Nori
2018-05-11 15:21 ` [PATCH 1/3] ARM: davinci: dm646x: fix timer interrupt generation Sekhar Nori
2018-05-11 15:21 ` [PATCH 2/3] ARM: davinci: board-dm646x-evm: pass correct I2C adapter id for VPIF Sekhar Nori
2018-05-11 15:21 ` [PATCH 3/3] ARM: davinci: board-dm646x-evm: set VPIF capture card name Sekhar Nori
2018-05-15  9:22 ` [PATCH 0/3] ARM: davinci: some dm646x related fixes Sekhar Nori

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.