From: Keith Busch <keith.busch@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Jesse Vincent <jesse@fsck.com>, Sagi Grimberg <sagi@grimberg.me>,
linux-pci@vger.kernel.org, Andrew Lutomirski <amluto@gmail.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Jens Axboe <axboe@fb.com>, Bjorn Helgaas <bhelgaas@google.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: Another NVMe failure, this time with AER info
Date: Fri, 11 May 2018 11:42:42 -0600 [thread overview]
Message-ID: <20180511174241.GC7344@localhost.localdomain> (raw)
In-Reply-To: <20180511172610.GB7344@localhost.localdomain>
On Fri, May 11, 2018 at 11:26:11AM -0600, Keith Busch wrote:
> I trust you know the offsets here, but it's hard to tell what this
> is doing with hard-coded addresses. Just to be safe and for clarity,
> I recommend the 'CAP_*+<offset>' with a mask.
>
> For example, disabling ASPM L1.2 can look like:
>
> # setpci -s <B:D.f> CAP_PM+8.l=0:4
My mistake above: CAP_PM is a different capability, not the intended
one. It looks like setpci doesn't even have a convenient symbol for the
L1 PM extended capability, so the hard-coded offsets are the only way
for this setting. Sorry about the mistake.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@linux.intel.com (Keith Busch)
Subject: Another NVMe failure, this time with AER info
Date: Fri, 11 May 2018 11:42:42 -0600 [thread overview]
Message-ID: <20180511174241.GC7344@localhost.localdomain> (raw)
In-Reply-To: <20180511172610.GB7344@localhost.localdomain>
On Fri, May 11, 2018@11:26:11AM -0600, Keith Busch wrote:
> I trust you know the offsets here, but it's hard to tell what this
> is doing with hard-coded addresses. Just to be safe and for clarity,
> I recommend the 'CAP_*+<offset>' with a mask.
>
> For example, disabling ASPM L1.2 can look like:
>
> # setpci -s <B:D.f> CAP_PM+8.l=0:4
My mistake above: CAP_PM is a different capability, not the intended
one. It looks like setpci doesn't even have a convenient symbol for the
L1 PM extended capability, so the hard-coded offsets are the only way
for this setting. Sorry about the mistake.
next prev parent reply other threads:[~2018-05-11 17:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAObL_7G5k7XNqXqDZASChiQd1mt+AJPAdNKz-DE+xQawhUy6ZA@mail.gmail.com>
2018-05-11 16:57 ` Another NVMe failure, this time with AER info Bjorn Helgaas
2018-05-11 16:57 ` Bjorn Helgaas
2018-05-11 16:57 ` Bjorn Helgaas
2018-05-11 17:26 ` Keith Busch
2018-05-11 17:26 ` Keith Busch
2018-05-11 17:42 ` Keith Busch [this message]
2018-05-11 17:42 ` Keith Busch
2018-05-11 17:55 ` Bjorn Helgaas
2018-05-11 17:55 ` Bjorn Helgaas
2018-05-11 17:55 ` Bjorn Helgaas
2018-05-12 2:38 ` Ming Lei
2018-05-12 2:38 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511174241.GC7344@localhost.localdomain \
--to=keith.busch@linux.intel.com \
--cc=amluto@gmail.com \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=jesse@fsck.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.