All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] igt/gem_eio: Exercise banning
@ 2018-05-12  9:03 ` Chris Wilson
  0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-05-12  9:03 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

If we trigger "too many" resets, the context and even the file, will be
banend and subsequent execbufs should fail with -EIO.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_eio.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/tests/gem_eio.c b/tests/gem_eio.c
index 6455c6acd..4720b47b5 100644
--- a/tests/gem_eio.c
+++ b/tests/gem_eio.c
@@ -250,6 +250,52 @@ static int __check_wait(int fd, uint32_t bo, unsigned int wait)
 	return ret;
 }
 
+static void __test_banned(int fd)
+{
+	struct drm_i915_gem_exec_object2 obj = {
+		.handle = gem_create(fd, 4096),
+	};
+	struct drm_i915_gem_execbuffer2 execbuf = {
+		.buffers_ptr = to_user_pointer(&obj),
+		.buffer_count = 1,
+	};
+	const uint32_t bbe = MI_BATCH_BUFFER_END;
+	unsigned long count = 0;
+
+	gem_write(fd, obj.handle, 0, &bbe, sizeof(bbe));
+
+	gem_quiescent_gpu(fd);
+	igt_require(i915_reset_control(true));
+
+	igt_until_timeout(5) {
+		igt_spin_t *hang;
+
+		if (__gem_execbuf(fd, &execbuf) == -EIO) {
+			igt_info("Banned after causing %lu hangs\n", count);
+			igt_assert(count > 1);
+			return;
+		}
+
+		/* Trigger a reset, making sure we are detected as guilty */
+		hang = spin_sync(fd, 0, 0);
+		trigger_reset(fd);
+		igt_spin_batch_free(fd, hang);
+
+		count++;
+	}
+
+	igt_assert_f(false,
+		     "Ran for 5s, %lu hangs without being banned\n",
+		     count);
+}
+
+static void test_banned(int fd)
+{
+	fd = gem_reopen_driver(fd);
+	__test_banned(fd);
+	close(fd);
+}
+
 #define TEST_WEDGE (1)
 
 static void test_wait(int fd, unsigned int flags, unsigned int wait)
@@ -693,6 +739,9 @@ igt_main
 	igt_subtest("execbuf")
 		test_execbuf(fd);
 
+	igt_subtest("banned")
+		test_banned(fd);
+
 	igt_subtest("suspend")
 		test_suspend(fd, SUSPEND_STATE_MEM);
 
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning
@ 2018-05-12  9:03 ` Chris Wilson
  0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-05-12  9:03 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

If we trigger "too many" resets, the context and even the file, will be
banend and subsequent execbufs should fail with -EIO.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_eio.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/tests/gem_eio.c b/tests/gem_eio.c
index 6455c6acd..4720b47b5 100644
--- a/tests/gem_eio.c
+++ b/tests/gem_eio.c
@@ -250,6 +250,52 @@ static int __check_wait(int fd, uint32_t bo, unsigned int wait)
 	return ret;
 }
 
+static void __test_banned(int fd)
+{
+	struct drm_i915_gem_exec_object2 obj = {
+		.handle = gem_create(fd, 4096),
+	};
+	struct drm_i915_gem_execbuffer2 execbuf = {
+		.buffers_ptr = to_user_pointer(&obj),
+		.buffer_count = 1,
+	};
+	const uint32_t bbe = MI_BATCH_BUFFER_END;
+	unsigned long count = 0;
+
+	gem_write(fd, obj.handle, 0, &bbe, sizeof(bbe));
+
+	gem_quiescent_gpu(fd);
+	igt_require(i915_reset_control(true));
+
+	igt_until_timeout(5) {
+		igt_spin_t *hang;
+
+		if (__gem_execbuf(fd, &execbuf) == -EIO) {
+			igt_info("Banned after causing %lu hangs\n", count);
+			igt_assert(count > 1);
+			return;
+		}
+
+		/* Trigger a reset, making sure we are detected as guilty */
+		hang = spin_sync(fd, 0, 0);
+		trigger_reset(fd);
+		igt_spin_batch_free(fd, hang);
+
+		count++;
+	}
+
+	igt_assert_f(false,
+		     "Ran for 5s, %lu hangs without being banned\n",
+		     count);
+}
+
+static void test_banned(int fd)
+{
+	fd = gem_reopen_driver(fd);
+	__test_banned(fd);
+	close(fd);
+}
+
 #define TEST_WEDGE (1)
 
 static void test_wait(int fd, unsigned int flags, unsigned int wait)
@@ -693,6 +739,9 @@ igt_main
 	igt_subtest("execbuf")
 		test_execbuf(fd);
 
+	igt_subtest("banned")
+		test_banned(fd);
+
 	igt_subtest("suspend")
 		test_suspend(fd, SUSPEND_STATE_MEM);
 
-- 
2.17.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_eio: Exercise banning
  2018-05-12  9:03 ` [igt-dev] " Chris Wilson
  (?)
@ 2018-05-12  9:44 ` Patchwork
  -1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-05-12  9:44 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/gem_eio: Exercise banning
URL   : https://patchwork.freedesktop.org/series/43083/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4171 -> IGTPW_1349 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1349 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1349, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/43083/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1349:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1349 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_mmap_gtt@basic-small-bo-tiledx:
      fi-gdg-551:         PASS -> FAIL (fdo#102575)

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-hsw-4200u:       PASS -> FAIL (fdo#103928)

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-4200u:       PASS -> DMESG-FAIL (fdo#102614, fdo#106103)

    igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
      fi-hsw-4200u:       PASS -> FAIL (fdo#103481)

    
    ==== Possible fixes ====

    igt@drv_module_reload@basic-reload:
      fi-glk-j4005:       DMESG-WARN (fdo#106248) -> PASS

    igt@kms_chamelium@hdmi-hpd-fast:
      fi-kbl-7500u:       FAIL (fdo#103841, fdo#102672) -> SKIP

    
  fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
  fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248


== Participating hosts (40 -> 36) ==

  Missing    (4): fi-byt-squawks fi-ilk-m540 fi-cnl-y3 fi-skl-6700hq 


== Build changes ==

    * IGT: IGT_4475 -> IGTPW_1349

  CI_DRM_4171: fe5bde58dca53de7b615789c69ed83c6420d2d1a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1349: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1349/
  IGT_4475: 35f08c12aa216d5b62a5b9984b575cee6905098f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4475: 3ba0657bff4216d1ec7179935590261855f1651e @ git://anongit.freedesktop.org/piglit



== Testlist changes ==

+igt@gem_eio@banned

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1349/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for igt/gem_eio: Exercise banning
  2018-05-12  9:03 ` [igt-dev] " Chris Wilson
  (?)
  (?)
@ 2018-05-12 10:50 ` Patchwork
  -1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-05-12 10:50 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/gem_eio: Exercise banning
URL   : https://patchwork.freedesktop.org/series/43083/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4475_full -> IGTPW_1349_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1349_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1349_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/43083/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1349_full:

  === IGT changes ===

    ==== Possible regressions ====

    {igt@gem_eio@banned}:
      shard-glk:          NOTRUN -> DMESG-WARN
      shard-hsw:          NOTRUN -> DMESG-WARN
      shard-kbl:          NOTRUN -> DMESG-WARN
      shard-snb:          NOTRUN -> DMESG-WARN
      shard-apl:          NOTRUN -> DMESG-WARN

    
    ==== Warnings ====

    igt@gem_exec_schedule@deep-vebox:
      shard-kbl:          SKIP -> PASS +1

    igt@gem_mocs_settings@mocs-rc6-bsd2:
      shard-kbl:          PASS -> SKIP

    igt@gem_pwrite@big-cpu-random:
      shard-glk:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1349_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_addfb_basic@basic-x-tiled:
      shard-kbl:          PASS -> DMESG-WARN (fdo#103558, fdo#105602) +3

    igt@kms_flip@dpms-vs-vblank-race:
      shard-hsw:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105363, fdo#102887)

    igt@kms_rotation_crc@primary-rotation-270:
      shard-apl:          PASS -> FAIL (fdo#103925, fdo#104724)

    
    ==== Possible fixes ====

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#106023, fdo#103665) -> PASS +1

    igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
      shard-apl:          FAIL -> PASS

    igt@kms_flip@modeset-vs-vblank-race-interruptible:
      shard-glk:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@plain-flip-ts-check:
      shard-glk:          FAIL (fdo#100368) -> PASS +1

    igt@kms_flip@plain-flip-ts-check-interruptible:
      shard-kbl:          FAIL (fdo#100368) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925, fdo#104724) -> PASS

    igt@kms_sysfs_edid_timing:
      shard-apl:          WARN (fdo#100047) -> PASS

    igt@pm_rps@min-max-config-idle:
      shard-hsw:          FAIL -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023


== Participating hosts (9 -> 5) ==

  Missing    (4): pig-snb-2600 pig-glk-j5005 pig-skl-6600 pig-hsw-4770r 


== Build changes ==

    * IGT: IGT_4475 -> IGTPW_1349
    * Linux: CI_DRM_4163 -> CI_DRM_4171

  CI_DRM_4163: 8e1dab6e913be7d014eb9bc355ec65b6b56dcd56 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4171: fe5bde58dca53de7b615789c69ed83c6420d2d1a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1349: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1349/
  IGT_4475: 35f08c12aa216d5b62a5b9984b575cee6905098f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4475: 3ba0657bff4216d1ec7179935590261855f1651e @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1349/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning
  2018-05-12  9:03 ` [igt-dev] " Chris Wilson
                   ` (2 preceding siblings ...)
  (?)
@ 2018-05-14  8:50 ` Katarzyna Dec
  -1 siblings, 0 replies; 11+ messages in thread
From: Katarzyna Dec @ 2018-05-14  8:50 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

On Sat, May 12, 2018 at 10:03:42AM +0100, Chris Wilson wrote:
> If we trigger "too many" resets, the context and even the file, will be
> banend and subsequent execbufs should fail with -EIO.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
LGTM :)
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning
  2018-05-12  9:03 ` [igt-dev] " Chris Wilson
@ 2018-05-14 14:51   ` Antonio Argenziano
  -1 siblings, 0 replies; 11+ messages in thread
From: Antonio Argenziano @ 2018-05-14 14:51 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev



On 12/05/18 02:03, Chris Wilson wrote:
> If we trigger "too many" resets, the context and even the file, will be
> banend and subsequent execbufs should fail with -EIO.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Does this replace gem_reset_stats@test_ban?

Thanks,
Antonio
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning
@ 2018-05-14 14:51   ` Antonio Argenziano
  0 siblings, 0 replies; 11+ messages in thread
From: Antonio Argenziano @ 2018-05-14 14:51 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev



On 12/05/18 02:03, Chris Wilson wrote:
> If we trigger "too many" resets, the context and even the file, will be
> banend and subsequent execbufs should fail with -EIO.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Does this replace gem_reset_stats@test_ban?

Thanks,
Antonio
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning
  2018-05-14 14:51   ` Antonio Argenziano
@ 2018-05-14 15:02     ` Chris Wilson
  -1 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-05-14 15:02 UTC (permalink / raw)
  To: Antonio Argenziano, intel-gfx; +Cc: igt-dev

Quoting Antonio Argenziano (2018-05-14 15:51:04)
> 
> 
> On 12/05/18 02:03, Chris Wilson wrote:
> > If we trigger "too many" resets, the context and even the file, will be
> > banend and subsequent execbufs should fail with -EIO.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Does this replace gem_reset_stats@test_ban?

gem_reset_stats was queued to be rewritten from scratch a few years ago.

In short, no it doesn't replace as they are asking slightly different
questions. gem_eio is asking that if banned we get EIO. I have no idea
what API gem_reset_stats is supposed to be asking about, since banning
is not an aspect of DRM_IOCTL_I915_GET_RESET_STATS and so should be
treated very lightly to avoid over-specificity. (Banning is an internal
kernel policy in the name of DoS prevention and not a rigorous defense
or subject to user control.)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning
@ 2018-05-14 15:02     ` Chris Wilson
  0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-05-14 15:02 UTC (permalink / raw)
  To: Antonio Argenziano, intel-gfx; +Cc: igt-dev

Quoting Antonio Argenziano (2018-05-14 15:51:04)
> 
> 
> On 12/05/18 02:03, Chris Wilson wrote:
> > If we trigger "too many" resets, the context and even the file, will be
> > banend and subsequent execbufs should fail with -EIO.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Does this replace gem_reset_stats@test_ban?

gem_reset_stats was queued to be rewritten from scratch a few years ago.

In short, no it doesn't replace as they are asking slightly different
questions. gem_eio is asking that if banned we get EIO. I have no idea
what API gem_reset_stats is supposed to be asking about, since banning
is not an aspect of DRM_IOCTL_I915_GET_RESET_STATS and so should be
treated very lightly to avoid over-specificity. (Banning is an internal
kernel policy in the name of DoS prevention and not a rigorous defense
or subject to user control.)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning
  2018-05-14 15:02     ` Chris Wilson
@ 2018-05-14 20:39       ` Antonio Argenziano
  -1 siblings, 0 replies; 11+ messages in thread
From: Antonio Argenziano @ 2018-05-14 20:39 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev



On 14/05/18 08:02, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-05-14 15:51:04)
>>
>>
>> On 12/05/18 02:03, Chris Wilson wrote:
>>> If we trigger "too many" resets, the context and even the file, will be
>>> banend and subsequent execbufs should fail with -EIO.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>
>> Does this replace gem_reset_stats@test_ban?
> 
> gem_reset_stats was queued to be rewritten from scratch a few years ago.
> 
> In short, no it doesn't replace as they are asking slightly different
> questions. gem_eio is asking that if banned we get EIO. I have no idea
> what API gem_reset_stats is supposed to be asking about, since banning
> is not an aspect of DRM_IOCTL_I915_GET_RESET_STATS and so should be
> treated very lightly to avoid over-specificity. (Banning is an internal
> kernel policy in the name of DoS prevention and not a rigorous defense
> or subject to user control.)

I am not sure how much the intention of the tests are different :), but 
if that is the case then we need to check that other contexts are not 
being affected after a ban and they do not report -EIO on submission.

Thanks,
Antonio

> -Chris
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning
@ 2018-05-14 20:39       ` Antonio Argenziano
  0 siblings, 0 replies; 11+ messages in thread
From: Antonio Argenziano @ 2018-05-14 20:39 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev



On 14/05/18 08:02, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-05-14 15:51:04)
>>
>>
>> On 12/05/18 02:03, Chris Wilson wrote:
>>> If we trigger "too many" resets, the context and even the file, will be
>>> banend and subsequent execbufs should fail with -EIO.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>
>> Does this replace gem_reset_stats@test_ban?
> 
> gem_reset_stats was queued to be rewritten from scratch a few years ago.
> 
> In short, no it doesn't replace as they are asking slightly different
> questions. gem_eio is asking that if banned we get EIO. I have no idea
> what API gem_reset_stats is supposed to be asking about, since banning
> is not an aspect of DRM_IOCTL_I915_GET_RESET_STATS and so should be
> treated very lightly to avoid over-specificity. (Banning is an internal
> kernel policy in the name of DoS prevention and not a rigorous defense
> or subject to user control.)

I am not sure how much the intention of the tests are different :), but 
if that is the case then we need to check that other contexts are not 
being affected after a ban and they do not report -EIO on submission.

Thanks,
Antonio

> -Chris
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-05-14 20:39 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-12  9:03 [PATCH i-g-t] igt/gem_eio: Exercise banning Chris Wilson
2018-05-12  9:03 ` [igt-dev] " Chris Wilson
2018-05-12  9:44 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-05-12 10:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-05-14  8:50 ` [igt-dev] [PATCH i-g-t] " Katarzyna Dec
2018-05-14 14:51 ` Antonio Argenziano
2018-05-14 14:51   ` Antonio Argenziano
2018-05-14 15:02   ` Chris Wilson
2018-05-14 15:02     ` Chris Wilson
2018-05-14 20:39     ` Antonio Argenziano
2018-05-14 20:39       ` Antonio Argenziano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.