[PATCH 1/3] ALSA: hda: Add Acer Aspire 5930G to the power_save blacklist

[PATCH 1/3] ALSA: hda: Add Acer Aspire 5930G to the power_save blacklist

[Hans de Goede]

Power-saving is causing plopping sounds on the Acer Aspire 5930G, add it
to the blacklist.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/pci/hda/hda_intel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index b0c8c79848a9..7ca29b890425 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2206,6 +2206,8 @@ static int azx_probe(struct pci_dev *pci,
  * to causes problems on these devices.
  */
 static struct snd_pci_quirk power_save_blacklist[] = {
+	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
+	SND_PCI_QUIRK(0x1025, 0x013f, "Acer Aspire 5930G", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1849, 0x0c0c, "Asrock B85M-ITX", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
-- 
2.17.0

[PATCH 2/3] ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist

[Hans de Goede]

Power-saving is causing a humming sound when active on the Intel
NUC5i7RY, add it to the blacklist.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199607
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/pci/hda/hda_intel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 7ca29b890425..0981c3c64d87 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2212,6 +2212,8 @@ static struct snd_pci_quirk power_save_blacklist[] = {
 	SND_PCI_QUIRK(0x1849, 0x0c0c, "Asrock B85M-ITX", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
+	/* https://bugzilla.kernel.org/show_bug.cgi?id=199607 */
+	SND_PCI_QUIRK(0x8086, 0x2057, "Intel NUC5i7RYB", 0),
 	/* https://bugzilla.kernel.org/show_bug.cgi?id=198611 */
 	SND_PCI_QUIRK(0x17aa, 0x2227, "Lenovo X1 Carbon 3rd Gen", 0),
 	{}
-- 
2.17.0

[PATCH 3/3] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[Hans de Goede]

Power-saving is causing loud plops on the Lenovo C50 All in one, add it
to the blacklist.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/pci/hda/hda_intel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 0981c3c64d87..9a16af179503 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2214,6 +2214,8 @@ static struct snd_pci_quirk power_save_blacklist[] = {
 	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
 	/* https://bugzilla.kernel.org/show_bug.cgi?id=199607 */
 	SND_PCI_QUIRK(0x8086, 0x2057, "Intel NUC5i7RYB", 0),
+	/* https://bugzilla.redhat.com/show_bug.cgi?id=1572975 */
+	SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0),
 	/* https://bugzilla.kernel.org/show_bug.cgi?id=198611 */
 	SND_PCI_QUIRK(0x17aa, 0x2227, "Lenovo X1 Carbon 3rd Gen", 0),
 	{}
-- 
2.17.0

Re: [PATCH 1/3] ALSA: hda: Add Acer Aspire 5930G to the power_save blacklist

[Takashi Iwai]

On Sun, 13 May 2018 15:48:12 +0200,
Hans de Goede wrote:
> 
> Power-saving is causing plopping sounds on the Acer Aspire 5930G, add it
> to the blacklist.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Let's check whether the other workaround helps for this device at
first.


Takashi

Re: [PATCH 2/3] ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist

[Takashi Iwai]

On Sun, 13 May 2018 15:48:13 +0200,
Hans de Goede wrote:
> 
> Power-saving is causing a humming sound when active on the Intel
> NUC5i7RY, add it to the blacklist.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199607
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

The reporter sets "Loopback Mixing" and this can be the cause, too.
But no reaction in the upstream bug report.


Takashi

Re: [PATCH 3/3] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[Takashi Iwai]

On Sun, 13 May 2018 15:48:14 +0200,
Hans de Goede wrote:
> 
> Power-saving is causing loud plops on the Lenovo C50 All in one, add it
> to the blacklist.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I applied this one.


thanks,

Takashi

Re: [PATCH 2/3] ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist

[Hans de Goede]

Hi Takashi,

On 13-05-18 15:48, Hans de Goede wrote:
> Power-saving is causing a humming sound when active on the Intel
> NUC5i7RY, add it to the blacklist.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199607

The reporter has provided the requested info now,
disabling "Loopback Mixing" doesn't help.

Can we get this patch applied now?

Let me know if you want me to send a rebased version.

Regards,

Hans




> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>   sound/pci/hda/hda_intel.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 7ca29b890425..0981c3c64d87 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2212,6 +2212,8 @@ static struct snd_pci_quirk power_save_blacklist[] = {
>   	SND_PCI_QUIRK(0x1849, 0x0c0c, "Asrock B85M-ITX", 0),
>   	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
>   	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
> +	/* https://bugzilla.kernel.org/show_bug.cgi?id=199607 */
> +	SND_PCI_QUIRK(0x8086, 0x2057, "Intel NUC5i7RYB", 0),
>   	/* https://bugzilla.kernel.org/show_bug.cgi?id=198611 */
>   	SND_PCI_QUIRK(0x17aa, 0x2227, "Lenovo X1 Carbon 3rd Gen", 0),
>   	{}
> 

Re: [PATCH 2/3] ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist

[Takashi Iwai]

On Tue, 29 May 2018 09:09:07 +0200,
Hans de Goede wrote:
> 
> Hi Takashi,
> 
> On 13-05-18 15:48, Hans de Goede wrote:
> > Power-saving is causing a humming sound when active on the Intel
> > NUC5i7RY, add it to the blacklist.
> >
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199607
> 
> The reporter has provided the requested info now,
> disabling "Loopback Mixing" doesn't help.
> 
> Can we get this patch applied now?
> 
> Let me know if you want me to send a rebased version.

No need for that, I applied manually.


thanks,

Takashi