[Buildroot] [PATCH 1/1] woff2: fix build on m68k

[Buildroot] [PATCH 1/1] woff2: fix build on m68k

[Fabrice Fontaine]

Same issue on woff2 than in some other packages such as lcdapi: see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509

Fixes:
 - http://autobuild.buildroot.net/results/6c97a08e6ca2e914d54fbb525b3f0bb90023ef07

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/woff2/woff2.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/woff2/woff2.mk b/package/woff2/woff2.mk
index b2ff33fe98..2f0206c82b 100644
--- a/package/woff2/woff2.mk
+++ b/package/woff2/woff2.mk
@@ -21,4 +21,10 @@ ifneq ($(BR2_SHARED_LIBS),y)
 WOFF2_CONF_OPTS += -DCMAKE_SKIP_RPATH=ON
 endif
 
+# Internal error, aborting at dw2gencfi.c:215 in emit_expr_encoded
+# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509
+ifeq ($(BR2_m68k_cf),y)
+WOFF2_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -fno-dwarf2-cfi-asm"
+endif
+
 $(eval $(cmake-package))
-- 
2.14.1

[Buildroot] [PATCH 1/1] woff2: fix build on m68k

[Yann E. MORIN]

Fabrice, All,

On 2018-05-10 12:11 +0200, Fabrice Fontaine spake thusly:
> Same issue on woff2 than in some other packages such as lcdapi: see
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509

Since we now have at least 5 packages affected by this bug, can't we
just include this into the CFLAGS uncoditionally, i.e.:

    diff --git a/package/Makefile.in b/package/Makefile.in
    index 4325f7b3a9..584c7fafb1 100644
    --- a/package/Makefile.in
    +++ b/package/Makefile.in
    @@ -173,6 +173,12 @@ TARGET_CFLAGS = $(TARGET_CPPFLAGS) $(TARGET_ABI) $(TARGET_OPTIMIZATION) $(TARGET
     TARGET_CXXFLAGS = $(TARGET_CFLAGS)
     TARGET_FCFLAGS = $(TARGET_ABI) $(TARGET_OPTIMIZATION) $(TARGET_DEBUGGING)
     
    +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509
    +ifeq ($(BR2_m68k_cf),y)
    +TARGET_CFLAGS += -fno-dwarf2-cfi-asm
    +TARGET_CXXFLAGS += -fno-dwarf2-cfi-asm
    +endif
    +
     ifeq ($(BR2_BINFMT_FLAT),y)
     TARGET_CFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE),\
        -Wl$(comma)-elf2flt)

...with the workaround removed from the 4 affected packages: berkeleydb,
kmsxx, lcdapi, and libasplib?

Regards,
Yann E. MORIN.

> Fixes:
>  - http://autobuild.buildroot.net/results/6c97a08e6ca2e914d54fbb525b3f0bb90023ef07
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/woff2/woff2.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/woff2/woff2.mk b/package/woff2/woff2.mk
> index b2ff33fe98..2f0206c82b 100644
> --- a/package/woff2/woff2.mk
> +++ b/package/woff2/woff2.mk
> @@ -21,4 +21,10 @@ ifneq ($(BR2_SHARED_LIBS),y)
>  WOFF2_CONF_OPTS += -DCMAKE_SKIP_RPATH=ON
>  endif
>  
> +# Internal error, aborting at dw2gencfi.c:215 in emit_expr_encoded
> +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509
> +ifeq ($(BR2_m68k_cf),y)
> +WOFF2_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -fno-dwarf2-cfi-asm"
> +endif
> +
>  $(eval $(cmake-package))
> -- 
> 2.14.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] woff2: fix build on m68k

[Thomas Petazzoni]

Hello,

+Waldemar in Cc, since he reported this issue to gcc.

On Thu, 10 May 2018 12:11:01 +0200, Fabrice Fontaine wrote:
> Same issue on woff2 than in some other packages such as lcdapi: see
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/6c97a08e6ca2e914d54fbb525b3f0bb90023ef07
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/woff2/woff2.mk | 6 ++++++
>  1 file changed, 6 insertions(+)

I've applied to master, but as Yann pointed out, it starts to be a
problem affecting a number of packages.

The bug report you point out at
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509 has been closed,
because they say the issue is on binutils side. Has the issue been
reported to binutils ? Could you try to make this issue move forward ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] woff2: fix build on m68k

[Waldemar Brodkorb]

Hi,
Thomas Petazzoni wrote,

> Hello,
> 
> +Waldemar in Cc, since he reported this issue to gcc.
> 
> On Thu, 10 May 2018 12:11:01 +0200, Fabrice Fontaine wrote:
> > Same issue on woff2 than in some other packages such as lcdapi: see
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509
> > 
> > Fixes:
> >  - http://autobuild.buildroot.net/results/6c97a08e6ca2e914d54fbb525b3f0bb90023ef07
> > 
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/woff2/woff2.mk | 6 ++++++
> >  1 file changed, 6 insertions(+)
> 
> I've applied to master, but as Yann pointed out, it starts to be a
> problem affecting a number of packages.
> 
> The bug report you point out at
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509 has been closed,
> because they say the issue is on binutils side. Has the issue been
> reported to binutils ? Could you try to make this issue move forward ?

I recently added the binutils report for this bug on my TODO list,
but if Fabrice have fun to do it, I have'nt started with it, yet.
For binutils/gcc bugs you need to be responsive if you ignite a
fire, otherwise an issue might take 4-6 years to be resolved.  This
is only valid for so popular architectures like m68k or bfin and
hackers not able to provide a patch ;)

best regards
 Waldemar

[Buildroot] [PATCH 1/1] woff2: fix build on m68k

[Fabrice Fontaine]

Dear all,

2018-05-14 7:19 GMT+02:00 Waldemar Brodkorb <wbx@openadk.org>:

> Hi,
> Thomas Petazzoni wrote,
>
> > Hello,
> >
> > +Waldemar in Cc, since he reported this issue to gcc.
> >
> > On Thu, 10 May 2018 12:11:01 +0200, Fabrice Fontaine wrote:
> > > Same issue on woff2 than in some other packages such as lcdapi: see
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509
> > >
> > > Fixes:
> > >  - http://autobuild.buildroot.net/results/6c97a08e6ca2e914d54fb
> b525b3f0bb90023ef07
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > > ---
> > >  package/woff2/woff2.mk | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> >
> > I've applied to master, but as Yann pointed out, it starts to be a
> > problem affecting a number of packages.
> >
> > The bug report you point out at
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509 has been closed,
> > because they say the issue is on binutils side. Has the issue been
> > reported to binutils ? Could you try to make this issue move forward ?
>
> I recently added the binutils report for this bug on my TODO list,
> but if Fabrice have fun to do it, I have'nt started with it, yet.
> For binutils/gcc bugs you need to be responsive if you ignite a
> fire, otherwise an issue might take 4-6 years to be resolved.  This
> is only valid for so popular architectures like m68k or bfin and
> hackers not able to provide a patch ;)

I can let you report the bug as you're the one who found the issue as well
as the workaround. I'm not used to report bugs to the binutils folks.
As a side note, the issue was also raised by log4cplus:
*http://autobuild.buildroot.net/results/035/035cc60c0fd44a5a44de64bfadfe3788ef3c6576/build-end.log
<http://autobuild.buildroot.net/results/035/035cc60c0fd44a5a44de64bfadfe3788ef3c6576/build-end.log>*.
However, after applying the patch that removed compilation on toolchains
with the gcc bug 64735, the issue was "hidden".

>


> best regards
>  Waldemar
>
Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180514/c63f08d3/attachment.html>