All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Hans de Goede <hdegoede@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jun Li <jun.li@nxp.com>, Mats Karrman <mats.dev.list@gmail.com>,
	USB <linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v3 5/5] usb: typec: tcpm: Support for Alternate Modes
Date: Mon, 14 May 2018 13:40:14 +0300	[thread overview]
Message-ID: <20180514104014.GB21435@kuha.fi.intel.com> (raw)
In-Reply-To: <CAHp75VfFPiWM8LRwmXU-jugouBWStTnQBqU=FyyPP2s9dnY97g@mail.gmail.com>

On Sun, May 13, 2018 at 12:30:51AM +0300, Andy Shevchenko wrote:
> On Fri, May 11, 2018 at 4:18 PM, Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> > This adds more complete handling of VDMs and registration of
> > partner alternate modes, and introduces callbacks for
> > alternate mode operations.
> >
> > Only DFP role is supported for now.
> 
> > +       for (i = 0; i < cnt; i++)
> > +               p[i] = le32_to_cpu(payload[i]);
> 
> I would recommend to consider to use le32_to_cpu_array().
> 
> Though, actually we have slightly different API for BE and LE cases.
> For LE existing would be renamed to rather le32_to_cpus_array() and
> establishing the former one in the similar way how be32_to_cpu_array()
> is implemented.

OK. I'll check it.


Thanks Andy,

-- 
heikki

WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Hans de Goede <hdegoede@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jun Li <jun.li@nxp.com>, Mats Karrman <mats.dev.list@gmail.com>,
	USB <linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [RFC,v3,5/5] usb: typec: tcpm: Support for Alternate Modes
Date: Mon, 14 May 2018 13:40:14 +0300	[thread overview]
Message-ID: <20180514104014.GB21435@kuha.fi.intel.com> (raw)

On Sun, May 13, 2018 at 12:30:51AM +0300, Andy Shevchenko wrote:
> On Fri, May 11, 2018 at 4:18 PM, Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> > This adds more complete handling of VDMs and registration of
> > partner alternate modes, and introduces callbacks for
> > alternate mode operations.
> >
> > Only DFP role is supported for now.
> 
> > +       for (i = 0; i < cnt; i++)
> > +               p[i] = le32_to_cpu(payload[i]);
> 
> I would recommend to consider to use le32_to_cpu_array().
> 
> Though, actually we have slightly different API for BE and LE cases.
> For LE existing would be renamed to rather le32_to_cpus_array() and
> establishing the former one in the similar way how be32_to_cpu_array()
> is implemented.

OK. I'll check it.


Thanks Andy,

  reply	other threads:[~2018-05-14 10:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11 13:18 [RFC PATCH v3 0/5] usb: typec: Support for Alternate Modes Heikki Krogerus
2018-05-11 13:18 ` [RFC PATCH v3 1/5] usb: typec: mux: Get the mux identifier from function parameter Heikki Krogerus
2018-05-11 13:18   ` [RFC,v3,1/5] " Heikki Krogerus
2018-05-11 13:18 ` [RFC PATCH v3 2/5] usb: typec: Register a device for every mode Heikki Krogerus
2018-05-11 13:18   ` [RFC,v3,2/5] " Heikki Krogerus
2018-05-11 13:18 ` [RFC PATCH v3 3/5] usb: typec: Bus type for alternate modes Heikki Krogerus
2018-05-11 13:18   ` [RFC,v3,3/5] " Heikki Krogerus
2018-05-13  1:25   ` [RFC PATCH v3 3/5] " Randy Dunlap
2018-05-13  1:25     ` [RFC,v3,3/5] " Randy Dunlap
2018-05-14 10:42     ` [RFC PATCH v3 3/5] " Heikki Krogerus
2018-05-14 10:42       ` [RFC,v3,3/5] " Heikki Krogerus
2018-05-11 13:18 ` [RFC PATCH v3 4/5] usb: typec: pi3usb30532: Start using generic state values Heikki Krogerus
2018-05-11 13:18   ` [RFC,v3,4/5] " Heikki Krogerus
2018-05-11 13:18 ` [RFC PATCH v3 5/5] usb: typec: tcpm: Support for Alternate Modes Heikki Krogerus
2018-05-11 13:18   ` [RFC,v3,5/5] " Heikki Krogerus
2018-05-12 21:30   ` [RFC PATCH v3 5/5] " Andy Shevchenko
2018-05-12 21:30     ` [RFC,v3,5/5] " Andy Shevchenko
2018-05-14 10:40     ` Heikki Krogerus [this message]
2018-05-14 10:40       ` Heikki Krogerus
2018-05-12 21:42 ` [RFC PATCH v3 0/5] usb: typec: " Guenter Roeck
2018-05-14 10:56   ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514104014.GB21435@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=jun.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mats.dev.list@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.