[PATCH] staging: bcm2835-camera: Add TODO for removing overlay support

[PATCH] staging: bcm2835-camera: Add TODO for removing overlay support

[Stefan Schake]

The overlay code is non-functional since it relies on firmware control
of the HVS.

Signed-off-by: Stefan Schake <stschake@gmail.com>
---
Dave, does this match your understanding?

 drivers/staging/vc04_services/bcm2835-camera/TODO | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
index 0ab9e88..770fea6 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/TODO
+++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
@@ -32,3 +32,11 @@ We should have VCHI create a platform device once it's initialized,
 and have this driver bind to it, so that we automatically load the
 v4l2 module after VCHI loads.
 
+5) Remove overlay support.
+
+We advertise support for a V4L2 overlay implemented through the
+ril.video_render component. This component is non-functional with an
+upstream kernel since the VC4 DRM driver controls the HVS, not the
+firmware. Once we have dma-buf support, the same functionality with
+improved control can be achieved through the DRM interface. We should
+therefore remove all V4L2 overlay functionality from the driver.
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support

[Dave Stevenson]

On 11 May 2018 at 00:12, Stefan Schake <stschake@gmail.com> wrote:
> The overlay code is non-functional since it relies on firmware control
> of the HVS.
>
> Signed-off-by: Stefan Schake <stschake@gmail.com>
> ---
> Dave, does this match your understanding?

Yes, the overlay only works if you are not running the vc4 driver,
therefore dropping it is sensible for the mainline kernel.

>  drivers/staging/vc04_services/bcm2835-camera/TODO | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
> index 0ab9e88..770fea6 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/TODO
> +++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
> @@ -32,3 +32,11 @@ We should have VCHI create a platform device once it's initialized,
>  and have this driver bind to it, so that we automatically load the
>  v4l2 module after VCHI loads.
>
> +5) Remove overlay support.
> +
> +We advertise support for a V4L2 overlay implemented through the
> +ril.video_render component. This component is non-functional with an
> +upstream kernel since the VC4 DRM driver controls the HVS, not the
> +firmware. Once we have dma-buf support, the same functionality with
> +improved control can be achieved through the DRM interface. We should
> +therefore remove all V4L2 overlay functionality from the driver.
> --
> 2.7.4
>

Re: [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support

[Greg KH]

On Fri, May 11, 2018 at 01:12:44AM +0200, Stefan Schake wrote:
> The overlay code is non-functional since it relies on firmware control
> of the HVS.
> 
> Signed-off-by: Stefan Schake <stschake@gmail.com>
> ---
> Dave, does this match your understanding?

This doesn't apply to my tree, can you rebase and resend?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel