[PATCH] staging: sm750fb: add SPDX license identifier

[PATCH] staging: sm750fb: add SPDX license identifier

[Sumit Kumar]

SPDX licencse identifier is missing in header file. Add a SPDX license
identifier with correct format. Issue found by checkpatch.

Signed-off-by: Sumit Kumar <sumit686215@example.com>
---
 drivers/staging/sm750fb/ddk750.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/sm750fb/ddk750.h b/drivers/staging/sm750fb/ddk750.h
index 7340103..482c1c6 100644
--- a/drivers/staging/sm750fb/ddk750.h
+++ b/drivers/staging/sm750fb/ddk750.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  *         Copyright (c) 2007 by Silicon Motion, Inc. (SMI)
  *
-- 
2.7.4

Re: [PATCH] staging: sm750fb: add SPDX license identifier

[Greg Kroah-Hartman]

On Wed, May 09, 2018 at 12:21:02AM +0530, Sumit Kumar wrote:
> SPDX licencse identifier is missing in header file. Add a SPDX license
> identifier with correct format. Issue found by checkpatch.
> 
> Signed-off-by: Sumit Kumar <sumit686215@example.com>
> ---
>  drivers/staging/sm750fb/ddk750.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/sm750fb/ddk750.h b/drivers/staging/sm750fb/ddk750.h
> index 7340103..482c1c6 100644
> --- a/drivers/staging/sm750fb/ddk750.h
> +++ b/drivers/staging/sm750fb/ddk750.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

How do you know that is what this license is?

thanks,

greg k-h

Re: [PATCH] staging: sm750fb: add SPDX license identifier

[Sumit Kumar]

On Friday 11 May 2018 03:13 PM, Greg Kroah-Hartman wrote:
> On Wed, May 09, 2018 at 12:21:02AM +0530, Sumit Kumar wrote:
>> SPDX licencse identifier is missing in header file. Add a SPDX license
>> identifier with correct format. Issue found by checkpatch.
>>
>> Signed-off-by: Sumit Kumar <sumit686215@example.com>
>> ---
>>   drivers/staging/sm750fb/ddk750.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/sm750fb/ddk750.h b/drivers/staging/sm750fb/ddk750.h
>> index 7340103..482c1c6 100644
>> --- a/drivers/staging/sm750fb/ddk750.h
>> +++ b/drivers/staging/sm750fb/ddk750.h
>> @@ -1,3 +1,4 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
> How do you know that is what this license is?
>
> thanks,
>
> greg k-h

ddk750_chip.h had this license : /* SPDX-License-Identifier: GPL-2.0 */
So I thought that maybe this header should also have the same license.

--
Thanks and Regards,
Sumit

Re: [PATCH] staging: sm750fb: add SPDX license identifier

[Greg Kroah-Hartman]

On Sat, May 12, 2018 at 03:37:12AM +0530, Sumit Kumar wrote:
> 
> 
> On Friday 11 May 2018 03:13 PM, Greg Kroah-Hartman wrote:
> > On Wed, May 09, 2018 at 12:21:02AM +0530, Sumit Kumar wrote:
> > > SPDX licencse identifier is missing in header file. Add a SPDX license
> > > identifier with correct format. Issue found by checkpatch.
> > > 
> > > Signed-off-by: Sumit Kumar <sumit686215@example.com>
> > > ---
> > >   drivers/staging/sm750fb/ddk750.h | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/staging/sm750fb/ddk750.h b/drivers/staging/sm750fb/ddk750.h
> > > index 7340103..482c1c6 100644
> > > --- a/drivers/staging/sm750fb/ddk750.h
> > > +++ b/drivers/staging/sm750fb/ddk750.h
> > > @@ -1,3 +1,4 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > How do you know that is what this license is?
> > 
> > thanks,
> > 
> > greg k-h
> 
> ddk750_chip.h had this license : /* SPDX-License-Identifier: GPL-2.0 */
> So I thought that maybe this header should also have the same license.

You need a bit more background information here in order to make this
decision in the patch.  Please see other patches that have added
licenses to files without them for what is needed.

thanks,

greg k-h