All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Keith Busch <keith.busch@intel.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
	Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
	paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] nvme: fix lockdep warning in nvme_mpath_clear_current_path
Date: Mon, 14 May 2018 05:42:30 -0700	[thread overview]
Message-ID: <20180514124230.GA654@infradead.org> (raw)
In-Reply-To: <20180514121312.13624-1-jthumshirn@suse.de>

>  extern unsigned int nvme_io_timeout;
>  #define NVME_IO_TIMEOUT	(nvme_io_timeout * HZ)
> @@ -454,7 +455,9 @@ static inline void nvme_mpath_clear_current_path(struct nvme_ns *ns)
>  {
>  	struct nvme_ns_head *head = ns->head;
>  
> -	if (head && ns == srcu_dereference(head->current_path, &head->srcu))
> +	if (head &&
> +	    ns == rcu_dereference_protected(head->current_path,
> +				lockdep_is_held(&ns->ctrl->subsys->lock)))
>  		rcu_assign_pointer(head->current_path, NULL);
>  }
>  struct nvme_ns *nvme_find_path(struct nvme_ns_head *head);

We don't really dereference it at all in fact, but just check the
pointers for equality.  I wonder if there is a better way to do this,
as my ANA patches add a caller without the lock (and withou SRU
protection either now that I think of it) - for a pure pointer compare
we really should not need any sort of protection.

WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme: fix lockdep warning in nvme_mpath_clear_current_path
Date: Mon, 14 May 2018 05:42:30 -0700	[thread overview]
Message-ID: <20180514124230.GA654@infradead.org> (raw)
In-Reply-To: <20180514121312.13624-1-jthumshirn@suse.de>

>  extern unsigned int nvme_io_timeout;
>  #define NVME_IO_TIMEOUT	(nvme_io_timeout * HZ)
> @@ -454,7 +455,9 @@ static inline void nvme_mpath_clear_current_path(struct nvme_ns *ns)
>  {
>  	struct nvme_ns_head *head = ns->head;
>  
> -	if (head && ns == srcu_dereference(head->current_path, &head->srcu))
> +	if (head &&
> +	    ns == rcu_dereference_protected(head->current_path,
> +				lockdep_is_held(&ns->ctrl->subsys->lock)))
>  		rcu_assign_pointer(head->current_path, NULL);
>  }
>  struct nvme_ns *nvme_find_path(struct nvme_ns_head *head);

We don't really dereference it at all in fact, but just check the
pointers for equality.  I wonder if there is a better way to do this,
as my ANA patches add a caller without the lock (and withou SRU
protection either now that I think of it) - for a pure pointer compare
we really should not need any sort of protection.

  reply	other threads:[~2018-05-14 12:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 12:13 [PATCH] nvme: fix lockdep warning in nvme_mpath_clear_current_path Johannes Thumshirn
2018-05-14 12:13 ` Johannes Thumshirn
2018-05-14 12:42 ` Christoph Hellwig [this message]
2018-05-14 12:42   ` Christoph Hellwig
2018-05-14 12:57   ` Johannes Thumshirn
2018-05-14 12:57     ` Johannes Thumshirn
2018-05-14 13:38     ` Paul E. McKenney
2018-05-14 13:38       ` Paul E. McKenney
2018-05-14 13:56       ` Johannes Thumshirn
2018-05-14 13:56         ` Johannes Thumshirn
2018-05-14 16:08         ` Paul E. McKenney
2018-05-14 16:08           ` Paul E. McKenney
2018-05-14 13:31   ` Paul E. McKenney
2018-05-14 13:31     ` Paul E. McKenney
2018-05-14 13:34     ` Christoph Hellwig
2018-05-14 13:34       ` Christoph Hellwig
2018-05-14 13:34     ` Johannes Thumshirn
2018-05-14 13:34       ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514124230.GA654@infradead.org \
    --to=hch@infradead.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.