* [PATCH] pinctrl: sh-pfc: rcar-gen3: Fix grammar in static pin comments
@ 2018-05-14 19:44 Geert Uytterhoeven
2018-05-14 20:08 ` Niklas Söderlund
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-05-14 19:44 UTC (permalink / raw)
To: Laurent Pinchart, Linus Walleij
Cc: linux-renesas-soc, linux-gpio, Geert Uytterhoeven
The comment block explaining the rationale for static pins contains
grammar errors. It appeared first in the pin control driver for R-Car
H3 ES1.x, and spread to R-Car M3-W, H3 ES2.0, and M3-N later.
Fix the grammar in all copies at once.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in sh-pfc-for-v4.18.
drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 6 +++---
drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 6 +++---
drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 6 +++---
drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 6 +++---
4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
index 82a1c411c952a63e..a6c5d50557e676de 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
@@ -1432,10 +1432,10 @@ static const u16 pinmux_data[] = {
/*
* Static pins can not be muxed between different functions but
- * still needs a mark entry in the pinmux list. Add each static
+ * still need mark entries in the pinmux list. Add each static
* pin to the list without an associated function. The sh-pfc
- * core will do the right thing and skip trying to mux then pin
- * while still applying configuration to it
+ * core will do the right thing and skip trying to mux the pin
+ * while still applying configuration to it.
*/
#define FM(x) PINMUX_DATA(x##_MARK, 0),
PINMUX_STATIC
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 34626898f757a13a..4f55b1562ad4878a 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -1493,10 +1493,10 @@ static const u16 pinmux_data[] = {
/*
* Static pins can not be muxed between different functions but
- * still needs a mark entry in the pinmux list. Add each static
+ * still need mark entries in the pinmux list. Add each static
* pin to the list without an associated function. The sh-pfc
- * core will do the right thing and skip trying to mux then pin
- * while still applying configuration to it
+ * core will do the right thing and skip trying to mux the pin
+ * while still applying configuration to it.
*/
#define FM(x) PINMUX_DATA(x##_MARK, 0),
PINMUX_STATIC
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
index 764afa13a8c63658..3ea133cfb241a3df 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
@@ -1499,10 +1499,10 @@ static const u16 pinmux_data[] = {
/*
* Static pins can not be muxed between different functions but
- * still needs a mark entry in the pinmux list. Add each static
+ * still need mark entries in the pinmux list. Add each static
* pin to the list without an associated function. The sh-pfc
- * core will do the right thing and skip trying to mux then pin
- * while still applying configuration to it
+ * core will do the right thing and skip trying to mux the pin
+ * while still applying configuration to it.
*/
#define FM(x) PINMUX_DATA(x##_MARK, 0),
PINMUX_STATIC
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
index 4d944e3c73e91b61..5caecb6a844180ee 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
@@ -1501,10 +1501,10 @@ static const u16 pinmux_data[] = {
/*
* Static pins can not be muxed between different functions but
- * still needs a mark entry in the pinmux list. Add each static
+ * still need mark entries in the pinmux list. Add each static
* pin to the list without an associated function. The sh-pfc
- * core will do the right thing and skip trying to mux then pin
- * while still applying configuration to it
+ * core will do the right thing and skip trying to mux the pin
+ * while still applying configuration to it.
*/
#define FM(x) PINMUX_DATA(x##_MARK, 0),
PINMUX_STATIC
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: rcar-gen3: Fix grammar in static pin comments
2018-05-14 19:44 [PATCH] pinctrl: sh-pfc: rcar-gen3: Fix grammar in static pin comments Geert Uytterhoeven
@ 2018-05-14 20:08 ` Niklas Söderlund
0 siblings, 0 replies; 2+ messages in thread
From: Niklas Söderlund @ 2018-05-14 20:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Laurent Pinchart, Linus Walleij, linux-renesas-soc, linux-gpio
Hi Geert,
Thanks for your work.
On 2018-05-14 21:44:02 +0200, Geert Uytterhoeven wrote:
> The comment block explaining the rationale for static pins contains
> grammar errors. It appeared first in the pin control driver for R-Car
> H3 ES1.x, and spread to R-Car M3-W, H3 ES2.0, and M3-N later.
>
> Fix the grammar in all copies at once.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
Not sure a review tag from the one who made the grammar errors in the
first place is worth much... :-)
> ---
> To be queued in sh-pfc-for-v4.18.
>
> drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 6 +++---
> drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 6 +++---
> drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 6 +++---
> drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 6 +++---
> 4 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> index 82a1c411c952a63e..a6c5d50557e676de 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> @@ -1432,10 +1432,10 @@ static const u16 pinmux_data[] = {
>
> /*
> * Static pins can not be muxed between different functions but
> - * still needs a mark entry in the pinmux list. Add each static
> + * still need mark entries in the pinmux list. Add each static
> * pin to the list without an associated function. The sh-pfc
> - * core will do the right thing and skip trying to mux then pin
> - * while still applying configuration to it
> + * core will do the right thing and skip trying to mux the pin
> + * while still applying configuration to it.
> */
> #define FM(x) PINMUX_DATA(x##_MARK, 0),
> PINMUX_STATIC
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> index 34626898f757a13a..4f55b1562ad4878a 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> @@ -1493,10 +1493,10 @@ static const u16 pinmux_data[] = {
>
> /*
> * Static pins can not be muxed between different functions but
> - * still needs a mark entry in the pinmux list. Add each static
> + * still need mark entries in the pinmux list. Add each static
> * pin to the list without an associated function. The sh-pfc
> - * core will do the right thing and skip trying to mux then pin
> - * while still applying configuration to it
> + * core will do the right thing and skip trying to mux the pin
> + * while still applying configuration to it.
> */
> #define FM(x) PINMUX_DATA(x##_MARK, 0),
> PINMUX_STATIC
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
> index 764afa13a8c63658..3ea133cfb241a3df 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
> @@ -1499,10 +1499,10 @@ static const u16 pinmux_data[] = {
>
> /*
> * Static pins can not be muxed between different functions but
> - * still needs a mark entry in the pinmux list. Add each static
> + * still need mark entries in the pinmux list. Add each static
> * pin to the list without an associated function. The sh-pfc
> - * core will do the right thing and skip trying to mux then pin
> - * while still applying configuration to it
> + * core will do the right thing and skip trying to mux the pin
> + * while still applying configuration to it.
> */
> #define FM(x) PINMUX_DATA(x##_MARK, 0),
> PINMUX_STATIC
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
> index 4d944e3c73e91b61..5caecb6a844180ee 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
> @@ -1501,10 +1501,10 @@ static const u16 pinmux_data[] = {
>
> /*
> * Static pins can not be muxed between different functions but
> - * still needs a mark entry in the pinmux list. Add each static
> + * still need mark entries in the pinmux list. Add each static
> * pin to the list without an associated function. The sh-pfc
> - * core will do the right thing and skip trying to mux then pin
> - * while still applying configuration to it
> + * core will do the right thing and skip trying to mux the pin
> + * while still applying configuration to it.
> */
> #define FM(x) PINMUX_DATA(x##_MARK, 0),
> PINMUX_STATIC
> --
> 2.7.4
>
--
Regards,
Niklas S�derlund
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-14 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 19:44 [PATCH] pinctrl: sh-pfc: rcar-gen3: Fix grammar in static pin comments Geert Uytterhoeven
2018-05-14 20:08 ` Niklas Söderlund
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.