* [Qemu-devel] [PATCH] ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed
@ 2018-05-07 13:42 Tomeu Vizoso
2018-05-15 8:36 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Tomeu Vizoso @ 2018-05-07 13:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Tomeu Vizoso
The commit referenced below changed the logic by causing the gtk-egl
backend to be initialized regardless of whether GtkGlArea initialization
succeeded. This causes eglInitialize to crash in Wayland systems without
XWayland.
This patch restores the previous logic.
Fixes: 4c70280592f5 ("ui/gtk: use GtkGlArea on wayland only")
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
ui/gtk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index ef5bc42094a3..72e2e246244d 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -2448,7 +2448,7 @@ static void early_gtk_display_init(DisplayOptions *opts)
if (GDK_IS_WAYLAND_DISPLAY(gdk_display_get_default())) {
gtk_use_gl_area = true;
gtk_gl_area_init();
- }
+ } else
#endif
{
gtk_egl_init();
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed
2018-05-07 13:42 [Qemu-devel] [PATCH] ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed Tomeu Vizoso
@ 2018-05-15 8:36 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2018-05-15 8:36 UTC (permalink / raw)
To: Tomeu Vizoso; +Cc: qemu-devel
On Mon, May 07, 2018 at 03:42:37PM +0200, Tomeu Vizoso wrote:
> The commit referenced below changed the logic by causing the gtk-egl
> backend to be initialized regardless of whether GtkGlArea initialization
> succeeded. This causes eglInitialize to crash in Wayland systems without
> XWayland.
>
> This patch restores the previous logic.
Added to ui patch queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-15 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 13:42 [Qemu-devel] [PATCH] ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed Tomeu Vizoso
2018-05-15 8:36 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.