From: Mark Rutland <mark.rutland@arm.com> To: Dominik Brodowski <linux@dominikbrodowski.net> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, dave.martin@arm.com, james.morse@arm.com, linux-fsdevel@vger.kernel.org, marc.zyngier@arm.com, viro@zeniv.linux.org.uk, will.deacon@arm.com Subject: Re: [PATCH 13/18] kernel: add kcompat_sys_{f,}statfs64() Date: Tue, 15 May 2018 10:53:51 +0100 [thread overview] Message-ID: <20180515095351.lw5gxap4ii5iobtb@lakrids.cambridge.arm.com> (raw) In-Reply-To: <20180514203414.GB26773@light.dominikbrodowski.net> On Mon, May 14, 2018 at 10:34:14PM +0200, Dominik Brodowski wrote: > On Mon, May 14, 2018 at 06:14:28PM +0100, Mark Rutland wrote: > > On Mon, May 14, 2018 at 10:46:35AM +0100, Mark Rutland wrote: > > > +#ifdef CONFIG_COMPAT > > > +int kcompat_sys_statfs64(const char __user * pathname, compat_size_t sz, > > > + struct compat_statfs64 __user * buf); > > > +int kcompat_sys_fstatfs64(unsigned int fd, compat_size_t sz, > > > + struct compat_statfs64 __user * buf); > > > +#endif > > > > I've moved these to <linux/compat.h>, so that they live with the rest of > > the compat syscall stuff. That should avoid build failures the kbuild > > test robot picked up where compat_size_t wasn't dfined. > > Please add a comment there, similar to what is in syscalls.h: > > /* > * Kernel code should not call syscalls (i.e., sys_xyzyyz()) directly. > * Instead, use one of the functions which work equivalently, such as > * the ksys_xyzyyz() functions prototyped below. > */ To make the kcompat_sys_* naming scheme clearer, I've added compat references to the above, i.e. /* * Kernel code should not call compat syscalls (i.e., compat_sys_xyzyyz()) * directly. Instead, use one of the functions which work equivalently, such * as the kcompat_sys_xyzyyz() functions prototyped below. */ > Once you have done so, feel free to add my > > Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net> I hope that this still stands with the changes above? Thanks, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 13/18] kernel: add kcompat_sys_{f,}statfs64() Date: Tue, 15 May 2018 10:53:51 +0100 [thread overview] Message-ID: <20180515095351.lw5gxap4ii5iobtb@lakrids.cambridge.arm.com> (raw) In-Reply-To: <20180514203414.GB26773@light.dominikbrodowski.net> On Mon, May 14, 2018 at 10:34:14PM +0200, Dominik Brodowski wrote: > On Mon, May 14, 2018 at 06:14:28PM +0100, Mark Rutland wrote: > > On Mon, May 14, 2018 at 10:46:35AM +0100, Mark Rutland wrote: > > > +#ifdef CONFIG_COMPAT > > > +int kcompat_sys_statfs64(const char __user * pathname, compat_size_t sz, > > > + struct compat_statfs64 __user * buf); > > > +int kcompat_sys_fstatfs64(unsigned int fd, compat_size_t sz, > > > + struct compat_statfs64 __user * buf); > > > +#endif > > > > I've moved these to <linux/compat.h>, so that they live with the rest of > > the compat syscall stuff. That should avoid build failures the kbuild > > test robot picked up where compat_size_t wasn't dfined. > > Please add a comment there, similar to what is in syscalls.h: > > /* > * Kernel code should not call syscalls (i.e., sys_xyzyyz()) directly. > * Instead, use one of the functions which work equivalently, such as > * the ksys_xyzyyz() functions prototyped below. > */ To make the kcompat_sys_* naming scheme clearer, I've added compat references to the above, i.e. /* * Kernel code should not call compat syscalls (i.e., compat_sys_xyzyyz()) * directly. Instead, use one of the functions which work equivalently, such * as the kcompat_sys_xyzyyz() functions prototyped below. */ > Once you have done so, feel free to add my > > Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net> I hope that this still stands with the changes above? Thanks, Mark.
next prev parent reply other threads:[~2018-05-15 9:54 UTC|newest] Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-14 9:46 [PATCH 00/18] arm64: invoke syscalls with pt_regs Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 01/18] arm64: consistently use unsigned long for thread flags Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 9:57 ` Dave Martin 2018-05-14 9:57 ` Dave Martin 2018-05-14 9:46 ` [PATCH 02/18] arm64: move SCTLR_EL{1,2} assertions to <asm/sysreg.h> Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 10:00 ` Dave Martin 2018-05-14 10:00 ` Dave Martin 2018-05-14 10:08 ` Mark Rutland 2018-05-14 10:08 ` Mark Rutland 2018-05-14 11:20 ` Dave Martin 2018-05-14 11:20 ` Dave Martin 2018-05-14 11:56 ` Robin Murphy 2018-05-14 11:56 ` Robin Murphy 2018-05-14 12:06 ` Mark Rutland 2018-05-14 12:06 ` Mark Rutland 2018-05-14 12:41 ` Dave Martin 2018-05-14 12:41 ` Dave Martin 2018-05-14 13:10 ` Mark Rutland 2018-05-14 13:10 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 03/18] arm64: introduce sysreg_clear_set() Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 10:04 ` Dave Martin 2018-05-14 10:04 ` Dave Martin 2018-05-14 9:46 ` [PATCH 04/18] arm64: kill config_sctlr_el1() Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 10:05 ` Dave Martin 2018-05-14 10:05 ` Dave Martin 2018-05-14 9:46 ` [PATCH 05/18] arm64: kill change_cpacr() Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 10:06 ` Dave Martin 2018-05-14 10:06 ` Dave Martin 2018-05-14 9:46 ` [PATCH 06/18] arm64: move sve_user_{enable,disable} to <asm/fpsimd.h> Mark Rutland 2018-05-14 9:46 ` [PATCH 06/18] arm64: move sve_user_{enable, disable} " Mark Rutland 2018-05-14 11:06 ` Dave Martin 2018-05-14 11:06 ` Dave Martin 2018-05-15 10:39 ` Mark Rutland 2018-05-15 10:39 ` Mark Rutland 2018-05-15 12:19 ` Dave Martin 2018-05-15 12:19 ` Dave Martin 2018-05-15 16:33 ` Mark Rutland 2018-05-15 16:33 ` Mark Rutland 2018-05-16 9:01 ` Dave Martin 2018-05-16 9:01 ` Dave Martin 2018-06-01 10:29 ` Mark Rutland 2018-06-01 10:29 ` Mark Rutland 2018-06-01 10:42 ` Dave Martin 2018-06-01 10:42 ` Dave Martin 2018-05-14 9:46 ` [PATCH 07/18] arm64: remove sigreturn wrappers Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 11:07 ` Dave Martin 2018-05-14 11:07 ` Dave Martin 2018-05-14 9:46 ` [PATCH 08/18] arm64: convert raw syscall invocation to C Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 11:07 ` Dave Martin 2018-05-14 11:07 ` Dave Martin 2018-05-14 11:41 ` Mark Rutland 2018-05-14 11:41 ` Mark Rutland 2018-05-14 12:53 ` Dave Martin 2018-05-14 12:53 ` Dave Martin 2018-05-14 20:24 ` Dominik Brodowski 2018-05-14 20:24 ` Dominik Brodowski 2018-05-15 8:22 ` Mark Rutland 2018-05-15 8:22 ` Mark Rutland 2018-05-15 10:01 ` Dominik Brodowski 2018-05-15 10:01 ` Dominik Brodowski 2018-05-15 10:13 ` Mark Rutland 2018-05-15 10:13 ` Mark Rutland 2018-05-14 18:00 ` Dominik Brodowski 2018-05-14 18:00 ` Dominik Brodowski 2018-05-15 8:18 ` Mark Rutland 2018-05-15 8:18 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 09/18] arm64: convert syscall trace logic " Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 10/18] arm64: convert native/compat syscall entry " Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 11:07 ` Dave Martin 2018-05-14 11:07 ` Dave Martin 2018-05-14 11:58 ` Mark Rutland 2018-05-14 11:58 ` Mark Rutland 2018-05-14 14:43 ` Dave Martin 2018-05-14 14:43 ` Dave Martin 2018-05-14 15:01 ` Mark Rutland 2018-05-14 15:01 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 11/18] arm64: zero GPRs upon entry from EL0 Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 11:07 ` Dave Martin 2018-05-14 11:07 ` Dave Martin 2018-05-14 9:46 ` [PATCH 12/18] kernel: add ksys_personality() Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 11:08 ` Dave Martin 2018-05-14 11:08 ` Dave Martin 2018-05-14 12:07 ` Christoph Hellwig 2018-05-14 12:07 ` Christoph Hellwig 2018-05-15 9:56 ` Mark Rutland 2018-05-15 9:56 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 13/18] kernel: add kcompat_sys_{f,}statfs64() Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 17:14 ` Mark Rutland 2018-05-14 17:14 ` Mark Rutland 2018-05-14 20:34 ` Dominik Brodowski 2018-05-14 20:34 ` Dominik Brodowski 2018-05-15 9:53 ` Mark Rutland [this message] 2018-05-15 9:53 ` Mark Rutland 2018-05-15 9:58 ` Dominik Brodowski 2018-05-15 9:58 ` Dominik Brodowski 2018-05-14 9:46 ` [PATCH 14/18] arm64: remove in-kernel call to sys_personality() Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 15/18] arm64: use {COMPAT,}SYSCALL_DEFINE0 for sigreturn Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 16/18] arm64: use SYSCALL_DEFINE6() for mmap Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 17/18] arm64: convert compat wrappers to C Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 12:10 ` Christoph Hellwig 2018-05-14 12:10 ` Christoph Hellwig 2018-05-14 12:43 ` Mark Rutland 2018-05-14 12:43 ` Mark Rutland 2018-05-14 9:46 ` [PATCH 18/18] arm64: implement syscall wrappers Mark Rutland 2018-05-14 9:46 ` Mark Rutland 2018-05-14 20:57 ` Dominik Brodowski 2018-05-14 20:57 ` Dominik Brodowski 2018-05-15 8:37 ` Mark Rutland 2018-05-15 8:37 ` Mark Rutland
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180515095351.lw5gxap4ii5iobtb@lakrids.cambridge.arm.com \ --to=mark.rutland@arm.com \ --cc=catalin.marinas@arm.com \ --cc=dave.martin@arm.com \ --cc=james.morse@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@dominikbrodowski.net \ --cc=marc.zyngier@arm.com \ --cc=viro@zeniv.linux.org.uk \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.