From: Joerg Roedel <joro@8bytes.org>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: mhocko@suse.com, akpm@linux-foundation.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, cpandya@codeaurora.org,
linux-mm@kvack.org, x86@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/mm: add TLB purge to free pmd/pte page interfaces
Date: Tue, 15 May 2018 16:05:49 +0200 [thread overview]
Message-ID: <20180515140549.GE18595@8bytes.org> (raw)
In-Reply-To: <20180430175925.2657-3-toshi.kani@hpe.com>
On Mon, Apr 30, 2018 at 11:59:24AM -0600, Toshi Kani wrote:
> int pud_free_pmd_page(pud_t *pud, unsigned long addr)
> {
> - pmd_t *pmd;
> + pmd_t *pmd, *pmd_sv;
> + pte_t *pte;
> int i;
>
> if (pud_none(*pud))
> return 1;
>
> pmd = (pmd_t *)pud_page_vaddr(*pud);
> + pmd_sv = (pmd_t *)__get_free_page(GFP_KERNEL);
So you need to allocate a page to free a page? It is better to put the
pages into a list with a list_head on the stack.
I am still on favour of just reverting the broken commit and do a
correct and working fix for the/a merge window.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] x86/mm: add TLB purge to free pmd/pte page interfaces
Date: Tue, 15 May 2018 16:05:49 +0200 [thread overview]
Message-ID: <20180515140549.GE18595@8bytes.org> (raw)
In-Reply-To: <20180430175925.2657-3-toshi.kani@hpe.com>
On Mon, Apr 30, 2018 at 11:59:24AM -0600, Toshi Kani wrote:
> int pud_free_pmd_page(pud_t *pud, unsigned long addr)
> {
> - pmd_t *pmd;
> + pmd_t *pmd, *pmd_sv;
> + pte_t *pte;
> int i;
>
> if (pud_none(*pud))
> return 1;
>
> pmd = (pmd_t *)pud_page_vaddr(*pud);
> + pmd_sv = (pmd_t *)__get_free_page(GFP_KERNEL);
So you need to allocate a page to free a page? It is better to put the
pages into a list with a list_head on the stack.
I am still on favour of just reverting the broken commit and do a
correct and working fix for the/a merge window.
Joerg
next prev parent reply other threads:[~2018-05-15 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 17:59 [PATCH 0/3] fix free pmd/pte page handlings on x86 Toshi Kani
2018-04-30 17:59 ` Toshi Kani
2018-04-30 17:59 ` [PATCH 1/3] ioremap: Update pgtable free interfaces with addr Toshi Kani
2018-04-30 17:59 ` Toshi Kani
2018-04-30 17:59 ` [PATCH 2/3] x86/mm: add TLB purge to free pmd/pte page interfaces Toshi Kani
2018-04-30 17:59 ` Toshi Kani
2018-05-15 14:05 ` Joerg Roedel [this message]
2018-05-15 14:05 ` Joerg Roedel
2018-05-15 16:34 ` Kani, Toshi
2018-05-15 16:34 ` Kani, Toshi
2018-04-30 17:59 ` [PATCH 3/3] x86/mm: disable ioremap free page handling on x86-PAE Toshi Kani
2018-04-30 17:59 ` Toshi Kani
2018-05-09 15:47 ` Kani, Toshi
2018-05-09 15:47 ` Kani, Toshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515140549.GE18595@8bytes.org \
--to=joro@8bytes.org \
--cc=akpm@linux-foundation.org \
--cc=cpandya@codeaurora.org \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.