All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1
Date: Tue, 15 May 2018 17:16:55 +0300	[thread overview]
Message-ID: <20180515141655.idzuh2jfdkuu5grs@mwanda> (raw)
In-Reply-To: <20180515085953.65bfa107@vento.lan>

On Tue, May 15, 2018 at 08:59:53AM -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 14 May 2018 22:31:37 -0500
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> escreveu:
> 
> > Hi Mauro,
> > 
> > On 04/26/2018 06:42 PM, Mauro Carvalho Chehab wrote:
> > 
> > >>
> > >> I noticed you changed the status of this series from rejected to new.
> > > 
> > > Yes.
> > > 
> > >> Also, there are other similar issues in media/pci/
> > > 
> > > Well, the issues will be there everywhere on all media drivers.
> > > 
> > > I marked your patches because I need to study it carefully, after
> > > Peter's explanations. My plan is to do it next week. Still not
> > > sure if the approach you took is the best one or not.
> > > 
> > > As I said, one possibility is to change the way v4l2-core handles
> > > VIDIOC_ENUM_foo ioctls, but that would be make harder to -stable
> > > backports.
> > > 
> > > I need a weekend to sleep on it.
> > > 
> > 
> > I'm curious about how you finally resolved to handle these issues.
> > 
> > I noticed Smatch is no longer reporting them.
> 
> There was no direct fix for it, but maybe this patch has something
> to do with the smatch error report cleanup:
> 
> commit 3ad3b7a2ebaefae37a7eafed0779324987ca5e56
> Author: Sami Tolvanen <samitolvanen@google.com>
> Date:   Tue May 8 13:56:12 2018 -0400
> 
>     media: v4l2-ioctl: replace IOCTL_INFO_STD with stub functions
>     
>     This change removes IOCTL_INFO_STD and adds stub functions where
>     needed using the DEFINE_V4L_STUB_FUNC macro. This fixes indirect call
>     mismatches with Control-Flow Integrity, caused by calling standard
>     ioctls using a function pointer that doesn't match the function type.
>     
>     Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
>     Signed-off-by: Hans Verkuil <hansverk@cisco.com>
>     Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> 

Possibly...  There was an ancient bug in Smatch's function pointer
handling.  I just pushed a fix for it now so the warning is there on
linux-next.

regards,
dan carpenter

  reply	other threads:[~2018-05-15 14:17 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 17:37 [PATCH 00/11] fix potential Spectre variant 1 issues Gustavo A. R. Silva
2018-04-23 17:37 ` Gustavo A. R. Silva
2018-04-23 17:38 ` [PATCH 01/11] media: tm6000: fix potential Spectre variant 1 Gustavo A. R. Silva
2018-04-23 18:24   ` Mauro Carvalho Chehab
2018-04-23 19:11     ` Gustavo A. R. Silva
2018-04-23 19:17       ` Mauro Carvalho Chehab
2018-04-23 19:22         ` Gustavo A. R. Silva
2018-04-26 21:41         ` Gustavo A. R. Silva
2018-04-26 23:42           ` Mauro Carvalho Chehab
2018-05-15  3:31             ` Gustavo A. R. Silva
2018-05-15 11:59               ` Mauro Carvalho Chehab
2018-05-15 14:16                 ` Dan Carpenter [this message]
2018-05-15 17:29                   ` Gustavo A. R. Silva
2018-05-15 19:00                     ` Mauro Carvalho Chehab
2018-05-16 13:11                       ` Dan Carpenter
2018-05-16 13:36                         ` Mauro Carvalho Chehab
2018-05-15 19:39                     ` Dan Carpenter
2018-05-17  1:14                       ` Gustavo A. R. Silva
2018-05-17 10:36                         ` Gustavo A. R. Silva
2018-05-17 11:34                           ` Mauro Carvalho Chehab
2018-05-17 11:43                             ` Mauro Carvalho Chehab
2018-05-17 12:13                               ` Mauro Carvalho Chehab
2018-05-17 18:08                                 ` Gustavo A. R. Silva
2018-05-21 16:18                                   ` Gustavo A. R. Silva
2018-04-24  9:35     ` Dan Carpenter
2018-04-24 10:11       ` Mauro Carvalho Chehab
2018-04-24 10:36       ` Peter Zijlstra
2018-04-24 11:21         ` Peter Zijlstra
2018-04-24 17:47         ` Mauro Carvalho Chehab
2018-04-24 18:48           ` Peter Zijlstra
2018-04-23 17:38 ` [PATCH 02/11] exynos4-is: mipi-csis: " Gustavo A. R. Silva
2018-04-23 17:38   ` Gustavo A. R. Silva
2018-04-23 17:39 ` [PATCH 03/11] fsl-viu: " Gustavo A. R. Silva
2018-04-23 17:40 ` [PATCH 04/11] marvell-ccic: mcam-core: " Gustavo A. R. Silva
2018-04-23 17:41 ` [PATCH 05/11] omap_vout: " Gustavo A. R. Silva
2018-04-23 17:47 ` [PATCH 06/11] rcar-v4l2: " Gustavo A. R. Silva
2018-04-23 17:48 ` [PATCH 07/11] rcar_drif: " Gustavo A. R. Silva
2018-04-23 17:48 ` [PATCH 08/11] sh_vou: " Gustavo A. R. Silva
2018-04-23 17:50 ` [PATCH 09/11] vimc-debayer: " Gustavo A. R. Silva
2018-04-23 17:51 ` [PATCH 10/11] vivid-sdr-cap: " Gustavo A. R. Silva
2018-04-23 17:52 ` [PATCH 11/11] vsp1_rwpf: " Gustavo A. R. Silva
2018-04-23 19:13 ` [PATCH 00/11] fix potential Spectre variant 1 issues Gustavo A. R. Silva
2018-04-23 19:13   ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515141655.idzuh2jfdkuu5grs@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.