From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1
Date: Mon, 21 May 2018 11:18:52 -0500 [thread overview]
Message-ID: <b3c23490-4113-c56f-8511-eea6cb054c48@embeddedor.com> (raw)
In-Reply-To: <5921004a-a7d3-59c9-2ef4-b6a490390d3f@embeddedor.com>
On 05/17/2018 01:08 PM, Gustavo A. R. Silva wrote:
>
> BTW, Mauro, you sent a patch to fix an spectre v1 issue in this file
> yesterday: dvb_ca_en50221.c:1480, but it seems there is another instance
> of the same issue some lines above:
>
> diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
> b/drivers/media/dvb-core/dvb_ca_en50221.c
> index 1310526..7edd9db 100644
> --- a/drivers/media/dvb-core/dvb_ca_en50221.c
> +++ b/drivers/media/dvb-core/dvb_ca_en50221.c
> @@ -1398,6 +1398,7 @@ static int dvb_ca_en50221_io_do_ioctl(struct file
> *file,
>
> info->type = CA_CI_LINK;
> info->flags = 0;
> + slot = array_index_nospec(slot, ca->slot_count + 1);
> sl = &ca->slot_info[slot];
> if ((sl->slot_state != DVB_CA_SLOTSTATE_NONE) &&
> (sl->slot_state != DVB_CA_SLOTSTATE_INVALID)) {
>
>
Hi Mauro,
Just to let you know, I was running smatch during the weekend and the
tool is still reporting all these Spectre media warnings (and a lot more):
https://patchwork.linuxtv.org/project/linux-media/list/?submitter=7277
Thanks
--
Gustavo
next prev parent reply other threads:[~2018-05-21 16:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 17:37 [PATCH 00/11] fix potential Spectre variant 1 issues Gustavo A. R. Silva
2018-04-23 17:37 ` Gustavo A. R. Silva
2018-04-23 17:38 ` [PATCH 01/11] media: tm6000: fix potential Spectre variant 1 Gustavo A. R. Silva
2018-04-23 18:24 ` Mauro Carvalho Chehab
2018-04-23 19:11 ` Gustavo A. R. Silva
2018-04-23 19:17 ` Mauro Carvalho Chehab
2018-04-23 19:22 ` Gustavo A. R. Silva
2018-04-26 21:41 ` Gustavo A. R. Silva
2018-04-26 23:42 ` Mauro Carvalho Chehab
2018-05-15 3:31 ` Gustavo A. R. Silva
2018-05-15 11:59 ` Mauro Carvalho Chehab
2018-05-15 14:16 ` Dan Carpenter
2018-05-15 17:29 ` Gustavo A. R. Silva
2018-05-15 19:00 ` Mauro Carvalho Chehab
2018-05-16 13:11 ` Dan Carpenter
2018-05-16 13:36 ` Mauro Carvalho Chehab
2018-05-15 19:39 ` Dan Carpenter
2018-05-17 1:14 ` Gustavo A. R. Silva
2018-05-17 10:36 ` Gustavo A. R. Silva
2018-05-17 11:34 ` Mauro Carvalho Chehab
2018-05-17 11:43 ` Mauro Carvalho Chehab
2018-05-17 12:13 ` Mauro Carvalho Chehab
2018-05-17 18:08 ` Gustavo A. R. Silva
2018-05-21 16:18 ` Gustavo A. R. Silva [this message]
2018-04-24 9:35 ` Dan Carpenter
2018-04-24 10:11 ` Mauro Carvalho Chehab
2018-04-24 10:36 ` Peter Zijlstra
2018-04-24 11:21 ` Peter Zijlstra
2018-04-24 17:47 ` Mauro Carvalho Chehab
2018-04-24 18:48 ` Peter Zijlstra
2018-04-23 17:38 ` [PATCH 02/11] exynos4-is: mipi-csis: " Gustavo A. R. Silva
2018-04-23 17:38 ` Gustavo A. R. Silva
2018-04-23 17:39 ` [PATCH 03/11] fsl-viu: " Gustavo A. R. Silva
2018-04-23 17:40 ` [PATCH 04/11] marvell-ccic: mcam-core: " Gustavo A. R. Silva
2018-04-23 17:41 ` [PATCH 05/11] omap_vout: " Gustavo A. R. Silva
2018-04-23 17:47 ` [PATCH 06/11] rcar-v4l2: " Gustavo A. R. Silva
2018-04-23 17:48 ` [PATCH 07/11] rcar_drif: " Gustavo A. R. Silva
2018-04-23 17:48 ` [PATCH 08/11] sh_vou: " Gustavo A. R. Silva
2018-04-23 17:50 ` [PATCH 09/11] vimc-debayer: " Gustavo A. R. Silva
2018-04-23 17:51 ` [PATCH 10/11] vivid-sdr-cap: " Gustavo A. R. Silva
2018-04-23 17:52 ` [PATCH 11/11] vsp1_rwpf: " Gustavo A. R. Silva
2018-04-23 19:13 ` [PATCH 00/11] fix potential Spectre variant 1 issues Gustavo A. R. Silva
2018-04-23 19:13 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c23490-4113-c56f-8511-eea6cb054c48@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.