* [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, ...
@ 2018-05-15 10:40 Igor Mammedov
2018-05-15 14:24 ` Andrew Jones
0 siblings, 1 reply; 3+ messages in thread
From: Igor Mammedov @ 2018-05-15 10:40 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, he.chen
When using following CLI:
-numa dist,src=128,dst=1,val=20
user getsi a rather confusing error message:
"Invalid node 128, max possible could be 128"
Where 128 is number of nodes that QEMU supports (MAX_NODES),
while src/dst is an index up to that limit, so it should be
MAX_NODES - 1 in error message.
Make error message to explicitly state valid range for node
index to be more clear.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
numa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/numa.c b/numa.c
index a3637cc..dedc149 100644
--- a/numa.c
+++ b/numa.c
@@ -142,8 +142,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp)
if (src >= MAX_NODES || dst >= MAX_NODES) {
error_setg(errp,
- "Invalid node %d, max possible could be %d",
- MAX(src, dst), MAX_NODES);
+ "Invalid node %d, should be in range [0 - %d]",
+ MAX(src, dst), MAX_NODES - 1);
return;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, ...
2018-05-15 10:40 [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, Igor Mammedov
@ 2018-05-15 14:24 ` Andrew Jones
2018-05-15 14:48 ` Igor Mammedov
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jones @ 2018-05-15 14:24 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, ehabkost, he.chen
Pretty long patch summary line. Do we not try to limit that?
On Tue, May 15, 2018 at 12:40:58PM +0200, Igor Mammedov wrote:
> When using following CLI:
> -numa dist,src=128,dst=1,val=20
> user getsi a rather confusing error message:
gets
> "Invalid node 128, max possible could be 128"
>
> Where 128 is number of nodes that QEMU supports (MAX_NODES),
> while src/dst is an index up to that limit, so it should be
> MAX_NODES - 1 in error message.
> Make error message to explicitly state valid range for node
> index to be more clear.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> numa.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/numa.c b/numa.c
> index a3637cc..dedc149 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -142,8 +142,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp)
>
> if (src >= MAX_NODES || dst >= MAX_NODES) {
> error_setg(errp,
> - "Invalid node %d, max possible could be %d",
> - MAX(src, dst), MAX_NODES);
> + "Invalid node %d, should be in range [0 - %d]",
How about "Invalid node %d. The valid node range is [0, %d]." ?
> + MAX(src, dst), MAX_NODES - 1);
> return;
> }
>
> --
> 2.7.4
>
>
Besides the nits
Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks,
drew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, ...
2018-05-15 14:24 ` Andrew Jones
@ 2018-05-15 14:48 ` Igor Mammedov
0 siblings, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2018-05-15 14:48 UTC (permalink / raw)
To: Andrew Jones; +Cc: he.chen, qemu-devel, ehabkost
On Tue, 15 May 2018 16:24:50 +0200
Andrew Jones <drjones@redhat.com> wrote:
> Pretty long patch summary line. Do we not try to limit that?
>
> On Tue, May 15, 2018 at 12:40:58PM +0200, Igor Mammedov wrote:
> > When using following CLI:
> > -numa dist,src=128,dst=1,val=20
> > user getsi a rather confusing error message:
>
> gets
>
> > "Invalid node 128, max possible could be 128"
> >
> > Where 128 is number of nodes that QEMU supports (MAX_NODES),
> > while src/dst is an index up to that limit, so it should be
> > MAX_NODES - 1 in error message.
> > Make error message to explicitly state valid range for node
> > index to be more clear.
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > numa.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/numa.c b/numa.c
> > index a3637cc..dedc149 100644
> > --- a/numa.c
> > +++ b/numa.c
> > @@ -142,8 +142,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp)
> >
> > if (src >= MAX_NODES || dst >= MAX_NODES) {
> > error_setg(errp,
> > - "Invalid node %d, max possible could be %d",
> > - MAX(src, dst), MAX_NODES);
> > + "Invalid node %d, should be in range [0 - %d]",
>
> How about "Invalid node %d. The valid node range is [0, %d]." ?
I'll fix up and resend v2
>
> > + MAX(src, dst), MAX_NODES - 1);
> > return;
> > }
> >
> > --
> > 2.7.4
> >
> >
>
> Besides the nits
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks!
>
> Thanks,
> drew
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-15 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 10:40 [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, Igor Mammedov
2018-05-15 14:24 ` Andrew Jones
2018-05-15 14:48 ` Igor Mammedov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.