All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/6] swiotlb: respect DMA_ATTR_NO_WARN in __swiotlb_map_page
Date: Tue, 15 May 2018 20:05:23 +0200	[thread overview]
Message-ID: <20180515180523.3038-7-hch@lst.de> (raw)
In-Reply-To: <20180515180523.3038-1-hch@lst.de>

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 lib/swiotlb.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index 5becc2fc680a..5cf88e090cb6 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -608,8 +608,11 @@ __swiotlb_map_page(struct device *dev, phys_addr_t phys, size_t size,
 
 	switch (swiotlb_force) {
 	case SWIOTLB_NO_FORCE:
-		dev_warn_ratelimited(dev,
-			"swiotlb: force disabled for address %pa\n", &phys);
+		if (!(attrs & DMA_ATTR_NO_WARN)) {
+			dev_warn_ratelimited(dev,
+				"swiotlb: force disabled for address %pa\n",
+				&phys);
+		}
 		return -EOPNOTSUPP;
 	case SWIOTLB_NORMAL:
 		/* can we address the memory directly? */
@@ -629,10 +632,12 @@ __swiotlb_map_page(struct device *dev, phys_addr_t phys, size_t size,
 	/* Ensure that the address returned is DMA'ble */
 	*dma_addr = __phys_to_dma(dev, map_addr);
 	if (unlikely(!dma_capable(dev, *dma_addr, size))) {
-		dev_err_ratelimited(dev,
-			"DMA: swiotlb buffer not addressable.\n");
+		if (!(attrs & DMA_ATTR_NO_WARN)) {
+			dev_err_ratelimited(dev,
+				"DMA: swiotlb buffer not addressable.\n");
+		}
 		swiotlb_tbl_unmap_single(dev, map_addr, size, dir,
-			attrs | DMA_ATTR_SKIP_CPU_SYNC);
+				attrs | DMA_ATTR_SKIP_CPU_SYNC);
 		return -EINVAL;
 	}
 	return 0;
-- 
2.17.0

  parent reply	other threads:[~2018-05-15 18:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 18:05 swiotlb cleanup Christoph Hellwig
2018-05-15 18:05 ` Christoph Hellwig
2018-05-15 18:05 ` [PATCH 1/6] swiotlb: remove a pointless comment Christoph Hellwig
2018-05-15 18:05   ` Christoph Hellwig
2018-05-18 20:22   ` Konrad Rzeszutek Wilk
2018-05-15 18:05 ` [PATCH 2/6] swiotlb: do not panic on mapping failures Christoph Hellwig
2018-05-15 18:05   ` Christoph Hellwig
     [not found]   ` <20180515180523.3038-3-hch-jcswGhMUV9g@public.gmane.org>
2018-05-16  9:24     ` Yisheng Xie
2018-05-18 20:21   ` Konrad Rzeszutek Wilk
2018-05-18 20:21     ` Konrad Rzeszutek Wilk
2018-05-15 18:05 ` [PATCH 3/6] swiotlb: merge swiotlb_unmap_page and unmap_single Christoph Hellwig
2018-05-15 18:05   ` Christoph Hellwig
2018-05-18 20:27   ` Konrad Rzeszutek Wilk
2018-05-18 20:27     ` Konrad Rzeszutek Wilk
2018-05-15 18:05 ` [PATCH 4/6] swiotlb: mark is_swiotlb_buffer static Christoph Hellwig
2018-05-15 18:05 ` [PATCH 5/6] swiotlb: share more code between map_page and map_sg Christoph Hellwig
2018-05-15 18:05 ` Christoph Hellwig [this message]
2018-07-25 11:37 swiotlb cleanup (resend) Christoph Hellwig
2018-07-25 11:38 ` [PATCH 6/6] swiotlb: respect DMA_ATTR_NO_WARN in __swiotlb_map_page Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515180523.3038-7-hch@lst.de \
    --to=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.