From: Christoph Hellwig <hch@lst.de> To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] swiotlb: remove a pointless comment Date: Tue, 15 May 2018 20:05:18 +0200 [thread overview] Message-ID: <20180515180523.3038-2-hch@lst.de> (raw) In-Reply-To: <20180515180523.3038-1-hch@lst.de> This comments describes an aspect of the map_sg interface that isn't even exploited by swiotlb. Signed-off-by: Christoph Hellwig <hch@lst.de> --- lib/swiotlb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 16ace0e25d52..721f93677eee 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -927,12 +927,6 @@ swiotlb_sync_single_for_device(struct device *hwdev, dma_addr_t dev_addr, * appropriate dma address and length. They are obtained via * sg_dma_{address,length}(SG). * - * NOTE: An implementation may be able to use a smaller number of - * DMA address/length pairs than there are SG table elements. - * (for example via virtual mapping capabilities) - * The routine returns the number of addr/length pairs actually - * used, at most nents. - * * Device ownership issues as mentioned above for swiotlb_map_page are the * same here. */ -- 2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> To: Konrad Rzeszutek Wilk <konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH 1/6] swiotlb: remove a pointless comment Date: Tue, 15 May 2018 20:05:18 +0200 [thread overview] Message-ID: <20180515180523.3038-2-hch@lst.de> (raw) In-Reply-To: <20180515180523.3038-1-hch-jcswGhMUV9g@public.gmane.org> This comments describes an aspect of the map_sg interface that isn't even exploited by swiotlb. Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> --- lib/swiotlb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 16ace0e25d52..721f93677eee 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -927,12 +927,6 @@ swiotlb_sync_single_for_device(struct device *hwdev, dma_addr_t dev_addr, * appropriate dma address and length. They are obtained via * sg_dma_{address,length}(SG). * - * NOTE: An implementation may be able to use a smaller number of - * DMA address/length pairs than there are SG table elements. - * (for example via virtual mapping capabilities) - * The routine returns the number of addr/length pairs actually - * used, at most nents. - * * Device ownership issues as mentioned above for swiotlb_map_page are the * same here. */ -- 2.17.0
next prev parent reply other threads:[~2018-05-15 18:05 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-15 18:05 swiotlb cleanup Christoph Hellwig 2018-05-15 18:05 ` Christoph Hellwig 2018-05-15 18:05 ` Christoph Hellwig [this message] 2018-05-15 18:05 ` [PATCH 1/6] swiotlb: remove a pointless comment Christoph Hellwig 2018-05-18 20:22 ` Konrad Rzeszutek Wilk 2018-05-15 18:05 ` [PATCH 2/6] swiotlb: do not panic on mapping failures Christoph Hellwig 2018-05-15 18:05 ` Christoph Hellwig [not found] ` <20180515180523.3038-3-hch-jcswGhMUV9g@public.gmane.org> 2018-05-16 9:24 ` Yisheng Xie 2018-05-18 20:21 ` Konrad Rzeszutek Wilk 2018-05-18 20:21 ` Konrad Rzeszutek Wilk 2018-05-15 18:05 ` [PATCH 3/6] swiotlb: merge swiotlb_unmap_page and unmap_single Christoph Hellwig 2018-05-15 18:05 ` Christoph Hellwig 2018-05-18 20:27 ` Konrad Rzeszutek Wilk 2018-05-18 20:27 ` Konrad Rzeszutek Wilk 2018-05-15 18:05 ` [PATCH 4/6] swiotlb: mark is_swiotlb_buffer static Christoph Hellwig 2018-05-15 18:05 ` [PATCH 5/6] swiotlb: share more code between map_page and map_sg Christoph Hellwig 2018-05-15 18:05 ` [PATCH 6/6] swiotlb: respect DMA_ATTR_NO_WARN in __swiotlb_map_page Christoph Hellwig 2018-07-25 11:37 swiotlb cleanup (resend) Christoph Hellwig 2018-07-25 11:37 ` [PATCH 1/6] swiotlb: remove a pointless comment Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180515180523.3038-2-hch@lst.de \ --to=hch@lst.de \ --cc=iommu@lists.linux-foundation.org \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.