[MODERATED] Re: [patch 11/15] Hidden 11

From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [patch 11/15] Hidden 11
Date: Tue, 15 May 2018 23:35:37 -0400	[thread overview]
Message-ID: <20180516033537.GA26939@char.us.oracle.com> (raw)
In-Reply-To: <20180513140539.142157021@linutronix.de>

On Sun, May 13, 2018 at 04:00:59PM +0200, speck for Thomas Gleixner wrote:
> Subject: [patch 11/15] x86/bugs: Expose x86_spec_ctrl_base directly
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> x86_spec_ctrl_base is the system wide default value for MSR_SPEC_CTRL.
> x86_spec_ctrl_get_default() returns x86_spec_ctrl_base and was intended to
> prevent modification to that variable. Though the variable is read only
> after init and globaly visible already.
> 
> Remove the function and export the variable instead.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

..snip..
> --- a/arch/x86/kernel/cpu/bugs.c
> +++ b/arch/x86/kernel/cpu/bugs.c
> @@ -36,12 +36,13 @@ static void __init ssb_select_mitigation
>   * writes to SPEC_CTRL contain whatever reserved bits have been set.
>   */
>  u64 __ro_after_init x86_spec_ctrl_base;
> +EXPORT_SYMBOL_GPL(x86_spec_ctrl_base);
>  
>  /*
>   * The vendor and possibly platform specific bits which can be modified in
>   * x86_spec_ctrl_base.
>   */
> -static u64 __ro_after_init x86_spec_ctrl_mask = ~SPEC_CTRL_IBRS;
> +static u64 __ro_after_init x86_spec_ctrl_mask = SPEC_CTRL_IBRS;

Why the flip? The commit description does not talk about this at all?