* [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling
@ 2018-05-15 10:28 Mika Kahola
2018-05-15 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_tiling Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Mika Kahola @ 2018-05-15 10:28 UTC (permalink / raw)
To: igt-dev
Make sure framebuffer compression is disabled when running this test.
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
tests/kms_flip_tiling.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
index 5aae29a..8dde5c8 100644
--- a/tests/kms_flip_tiling.c
+++ b/tests/kms_flip_tiling.c
@@ -33,12 +33,23 @@
IGT_TEST_DESCRIPTION("Test page flips and tiling scenarios");
+#define fbc_enable() igt_set_module_param_int("enable_fbc", 1)
+#define fbc_disable() igt_set_module_param_int("enable_fbc", 0)
+
typedef struct {
int drm_fd;
igt_display_t display;
int gen;
} data_t;
+static bool fbc_is_enabled(int fd)
+{
+ char buf[128];
+
+ igt_debugfs_read(fd, "i915_fbc_status", buf);
+ return strstr(buf, "FBC enabled\n");
+}
+
static igt_pipe_crc_t *_pipe_crc;
static igt_pipe_crc_t *pipe_crc_new(data_t *data, int pipe)
@@ -88,6 +99,10 @@ test_flip_tiling(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t ti
igt_pipe_crc_t *pipe_crc;
igt_crc_t reference_crc, crc;
int fb_id, ret, width;
+ bool fbc_enabled = fbc_is_enabled(data->drm_fd);
+
+ if (fbc_enabled)
+ fbc_disable();
pipe_crc = pipe_crc_new(data, pipe);
igt_output_set_pipe(output, pipe);
@@ -153,6 +168,9 @@ test_flip_tiling(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t ti
igt_remove_fb(data->drm_fd, &fb[0]);
igt_remove_fb(data->drm_fd, &fb[1]);
+
+ if (fbc_enabled)
+ fbc_enable();
}
static data_t data;
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_tiling
2018-05-15 10:28 [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Mika Kahola
@ 2018-05-15 12:59 ` Patchwork
2018-05-15 21:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-05-16 11:36 ` [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Daniel Vetter
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-05-15 12:59 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_flip_tiling
URL : https://patchwork.freedesktop.org/series/43185/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4183 -> IGTPW_1366 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1366 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1366, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43185/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1366:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_gttfill@basic:
fi-pnv-d510: SKIP -> PASS
== Known issues ==
Here are the changes found in IGTPW_1366 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
igt@kms_psr_sink_crc@basic:
fi-hsw-4200u: NOTRUN -> FAIL (fdo#106346)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s4-devices:
fi-glk-j4005: DMESG-WARN (fdo#106097) -> PASS
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106346 https://bugs.freedesktop.org/show_bug.cgi?id=106346
== Participating hosts (38 -> 36) ==
Additional (2): fi-hsw-peppy fi-hsw-4200u
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-cnl-y3 fi-skl-6700hq
== Build changes ==
* IGT: IGT_4480 -> IGTPW_1366
* Piglit: piglit_4480 -> piglit_4481
CI_DRM_4183: 9d97c6e3fd3ac8dd73f107ca85e2a12c746a2ccc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1366: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1366/
IGT_4480: 18fa0c11012da6aa9a5511dc9b1736064a02b429 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4480: 3ba0657bff4216d1ec7179935590261855f1651e @ git://anongit.freedesktop.org/piglit
piglit_4481: 3ba0657bff4216d1ec7179935590261855f1651e @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1366/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_flip_tiling
2018-05-15 10:28 [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Mika Kahola
2018-05-15 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_tiling Patchwork
@ 2018-05-15 21:46 ` Patchwork
2018-05-16 11:36 ` [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Daniel Vetter
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-05-15 21:46 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_flip_tiling
URL : https://patchwork.freedesktop.org/series/43185/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4480_full -> IGTPW_1366_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1366_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1366_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43185/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1366_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-blt:
shard-kbl: SKIP -> PASS +1
igt@kms_cursor_legacy@flip-vs-cursor-atomic:
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1366_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_eio@execbuf:
shard-snb: PASS -> DMESG-WARN (fdo#106523)
igt@gem_eio@hibernate:
shard-apl: PASS -> DMESG-WARN (fdo#106523) +4
igt@gem_eio@in-flight-1us:
shard-glk: NOTRUN -> DMESG-WARN (fdo#106523)
igt@gem_eio@in-flight-suspend:
shard-kbl: PASS -> DMESG-WARN (fdo#106523) +2
igt@gem_eio@throttle:
shard-hsw: PASS -> DMESG-WARN (fdo#106523)
igt@kms_cursor_crc@cursor-256x256-suspend:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
shard-glk: NOTRUN -> FAIL (fdo#105454)
igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
shard-hsw: PASS -> FAIL (fdo#102670)
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-hsw: PASS -> FAIL (fdo#102887)
igt@kms_flip@modeset-vs-vblank-race-interruptible:
shard-hsw: PASS -> FAIL (fdo#103060)
igt@kms_flip_tiling@flip-to-y-tiled:
shard-glk: NOTRUN -> FAIL (fdo#103822, fdo#104724)
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: NOTRUN -> FAIL (fdo#104724) +1
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt:
shard-glk: PASS -> FAIL (fdo#104724, fdo#103167)
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: PASS -> FAIL (fdo#104724, fdo#103925)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
shard-glk: NOTRUN -> FAIL (fdo#99912)
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@gem_eio@execbuf:
shard-glk: DMESG-WARN (fdo#106523) -> PASS +5
igt@gem_eio@in-flight-contexts-immediate:
shard-hsw: DMESG-WARN (fdo#106523) -> PASS +5
igt@gem_eio@throttle:
shard-snb: DMESG-WARN (fdo#106523) -> PASS +6
igt@gem_eio@unwedge-stress:
shard-kbl: DMESG-WARN (fdo#106523) -> PASS
igt@gem_eio@wait-wedge-10ms:
shard-apl: DMESG-WARN (fdo#106523) -> PASS +3
igt@kms_cursor_crc@cursor-64x21-onscreen:
shard-kbl: DMESG-WARN (fdo#103313, fdo#103558, fdo#105602) -> PASS +9
igt@kms_fbcon_fbt@fbc-suspend:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_flip@flip-vs-panning-vs-hang:
shard-snb: DMESG-WARN (fdo#103821) -> PASS
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
shard-kbl: DMESG-WARN (fdo#103841, fdo#103558, fdo#105602) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-snb: FAIL (fdo#104724, fdo#103166) -> PASS
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: FAIL (fdo#104724, fdo#103925) -> PASS
igt@kms_rotation_crc@sprite-rotation-270:
shard-apl: FAIL (fdo#104724, fdo#103925) -> PASS
igt@kms_universal_plane@cursor-fb-leak-pipe-b:
shard-kbl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS +17
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103821 https://bugs.freedesktop.org/show_bug.cgi?id=103821
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106523 https://bugs.freedesktop.org/show_bug.cgi?id=106523
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4480 -> IGTPW_1366
* Linux: CI_DRM_4182 -> CI_DRM_4183
* Piglit: piglit_4480 -> piglit_4481
CI_DRM_4182: 74146e495c113f6cf8721bb55feec6b459199cd4 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4183: 9d97c6e3fd3ac8dd73f107ca85e2a12c746a2ccc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1366: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1366/
IGT_4480: 18fa0c11012da6aa9a5511dc9b1736064a02b429 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4480: 3ba0657bff4216d1ec7179935590261855f1651e @ git://anongit.freedesktop.org/piglit
piglit_4481: 3ba0657bff4216d1ec7179935590261855f1651e @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1366/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling
2018-05-15 10:28 [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Mika Kahola
2018-05-15 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_tiling Patchwork
2018-05-15 21:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-05-16 11:36 ` Daniel Vetter
2018-05-16 11:45 ` Arkadiusz Hiler
2 siblings, 1 reply; 7+ messages in thread
From: Daniel Vetter @ 2018-05-16 11:36 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
On Tue, May 15, 2018 at 01:28:19PM +0300, Mika Kahola wrote:
> Make sure framebuffer compression is disabled when running this test.
Why? Commit message shouldn't just explain what you're doing, but much
more important is why you're doing something.
-Daniel
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_flip_tiling.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
> index 5aae29a..8dde5c8 100644
> --- a/tests/kms_flip_tiling.c
> +++ b/tests/kms_flip_tiling.c
> @@ -33,12 +33,23 @@
>
> IGT_TEST_DESCRIPTION("Test page flips and tiling scenarios");
>
> +#define fbc_enable() igt_set_module_param_int("enable_fbc", 1)
> +#define fbc_disable() igt_set_module_param_int("enable_fbc", 0)
> +
> typedef struct {
> int drm_fd;
> igt_display_t display;
> int gen;
> } data_t;
>
> +static bool fbc_is_enabled(int fd)
> +{
> + char buf[128];
> +
> + igt_debugfs_read(fd, "i915_fbc_status", buf);
> + return strstr(buf, "FBC enabled\n");
> +}
> +
> static igt_pipe_crc_t *_pipe_crc;
>
> static igt_pipe_crc_t *pipe_crc_new(data_t *data, int pipe)
> @@ -88,6 +99,10 @@ test_flip_tiling(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t ti
> igt_pipe_crc_t *pipe_crc;
> igt_crc_t reference_crc, crc;
> int fb_id, ret, width;
> + bool fbc_enabled = fbc_is_enabled(data->drm_fd);
> +
> + if (fbc_enabled)
> + fbc_disable();
>
> pipe_crc = pipe_crc_new(data, pipe);
> igt_output_set_pipe(output, pipe);
> @@ -153,6 +168,9 @@ test_flip_tiling(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t ti
>
> igt_remove_fb(data->drm_fd, &fb[0]);
> igt_remove_fb(data->drm_fd, &fb[1]);
> +
> + if (fbc_enabled)
> + fbc_enable();
> }
>
> static data_t data;
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling
2018-05-16 11:36 ` [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Daniel Vetter
@ 2018-05-16 11:45 ` Arkadiusz Hiler
2018-05-16 12:48 ` Mika Kahola
0 siblings, 1 reply; 7+ messages in thread
From: Arkadiusz Hiler @ 2018-05-16 11:45 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
On Wed, May 16, 2018 at 01:36:31PM +0200, Daniel Vetter wrote:
> On Tue, May 15, 2018 at 01:28:19PM +0300, Mika Kahola wrote:
> > Make sure framebuffer compression is disabled when running this test.
>
> Why? Commit message shouldn't just explain what you're doing, but much
> more important is why you're doing something.
> -Daniel
Since CI_TEST tag is used in the title I assume it's just to see how the
change (mis)behaves, without any interest in having it reviewed/merged.
-Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling
2018-05-16 11:45 ` Arkadiusz Hiler
@ 2018-05-16 12:48 ` Mika Kahola
0 siblings, 0 replies; 7+ messages in thread
From: Mika Kahola @ 2018-05-16 12:48 UTC (permalink / raw)
To: Arkadiusz Hiler, Daniel Vetter; +Cc: igt-dev
On Wed, 2018-05-16 at 14:45 +0300, Arkadiusz Hiler wrote:
> On Wed, May 16, 2018 at 01:36:31PM +0200, Daniel Vetter wrote:
> >
> > On Tue, May 15, 2018 at 01:28:19PM +0300, Mika Kahola wrote:
> > >
> > > Make sure framebuffer compression is disabled when running this
> > > test.
> > Why? Commit message shouldn't just explain what you're doing, but
> > much
> > more important is why you're doing something.
> > -Daniel
> Since CI_TEST tag is used in the title I assume it's just to see how
> the
> change (mis)behaves, without any interest in having it
> reviewed/merged.
That's right. The patch was only meant to exclude that fbc has nothing
to do with crc mismatches that we keep receiving from CI runs. The
patch was not meant for a review.
> -Arek
--
Mika Kahola - Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling
@ 2018-05-16 11:57 Mika Kahola
0 siblings, 0 replies; 7+ messages in thread
From: Mika Kahola @ 2018-05-16 11:57 UTC (permalink / raw)
To: igt-dev
Make sure framebuffer compression is disabled when running this test.
This may or may not have an effect on pipe crc mismatch errors that
we keep receiving from our CI runs. This patch is all about excluding the
possibility that fbc would have an effect on these errors.
This patch is not for review!
References: https://bugs.freedesktop.org/show_bug.cgi?id=103166
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
tests/kms_flip_tiling.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
index 5aae29a..19be81d 100644
--- a/tests/kms_flip_tiling.c
+++ b/tests/kms_flip_tiling.c
@@ -33,6 +33,9 @@
IGT_TEST_DESCRIPTION("Test page flips and tiling scenarios");
+#define fbc_enable() igt_set_module_param_int("enable_fbc", 1)
+#define fbc_disable() igt_set_module_param_int("enable_fbc", 0)
+
typedef struct {
int drm_fd;
igt_display_t display;
@@ -170,6 +173,7 @@ igt_main
igt_require_pipe_crc(data.drm_fd);
igt_display_init(&data.display, data.drm_fd);
+ fbc_disable();
}
/*
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-05-16 12:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 10:28 [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Mika Kahola
2018-05-15 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_tiling Patchwork
2018-05-15 21:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-05-16 11:36 ` [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Daniel Vetter
2018-05-16 11:45 ` Arkadiusz Hiler
2018-05-16 12:48 ` Mika Kahola
2018-05-16 11:57 Mika Kahola
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.