* [PATCH] svcrdma: Fix incorrect return value/type in svc_rdma_post_recvs
@ 2018-05-14 17:20 Chuck Lever
2018-05-16 18:15 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Chuck Lever @ 2018-05-14 17:20 UTC (permalink / raw)
To: bfields; +Cc: linux-nfs, dan.carpenter
This crept in during the development process and wasn't caught
before I posted the "final" version.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 0b2613c5883f ('svcrdma: Allocate recv_ctxt's on CPU ... ')
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
index 09ce09b..841fca1 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
@@ -270,7 +270,7 @@ bool svc_rdma_post_recvs(struct svcxprt_rdma *rdma)
for (i = 0; i < rdma->sc_max_requests; i++) {
ctxt = svc_rdma_recv_ctxt_get(rdma);
if (!ctxt)
- return -ENOMEM;
+ return false;
ctxt->rc_temp = true;
ret = __svc_rdma_post_recv(rdma, ctxt);
if (ret) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] svcrdma: Fix incorrect return value/type in svc_rdma_post_recvs
2018-05-14 17:20 [PATCH] svcrdma: Fix incorrect return value/type in svc_rdma_post_recvs Chuck Lever
@ 2018-05-16 18:15 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2018-05-16 18:15 UTC (permalink / raw)
To: Chuck Lever; +Cc: linux-nfs, dan.carpenter
Thanks!
--b.
On Mon, May 14, 2018 at 01:20:06PM -0400, Chuck Lever wrote:
> This crept in during the development process and wasn't caught
> before I posted the "final" version.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 0b2613c5883f ('svcrdma: Allocate recv_ctxt's on CPU ... ')
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> index 09ce09b..841fca1 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> @@ -270,7 +270,7 @@ bool svc_rdma_post_recvs(struct svcxprt_rdma *rdma)
> for (i = 0; i < rdma->sc_max_requests; i++) {
> ctxt = svc_rdma_recv_ctxt_get(rdma);
> if (!ctxt)
> - return -ENOMEM;
> + return false;
> ctxt->rc_temp = true;
> ret = __svc_rdma_post_recv(rdma, ctxt);
> if (ret) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-16 18:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 17:20 [PATCH] svcrdma: Fix incorrect return value/type in svc_rdma_post_recvs Chuck Lever
2018-05-16 18:15 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.