[gabbayo:private 43/43] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:44:31: sparse: symbol 'amdgpu_amdkfd_if' was not declared. Should it be static?

[gabbayo:private 43/43] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:44:31: sparse: symbol 'amdgpu_amdkfd_if' was not declared. Should it be static?

[kbuild test robot]

tree:   git://people.freedesktop.org/~gabbayo/linux private
head:   da8a916b6b6da1142232a310ac78571701655dba
commit: da8a916b6b6da1142232a310ac78571701655dba [43/43] drm/amdgpu: conditionally compile amdgpu's amdkfd files
reproduce:
        # apt-get install sparse
        git checkout da8a916b6b6da1142232a310ac78571701655dba
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:44:31: sparse: symbol 'amdgpu_amdkfd_if' was not declared. Should it be static?
   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:171:39: sparse: expression using sizeof(void)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[RFC PATCH gabbayo] drm/amdgpu: amdgpu_amdkfd_if can be static

[kbuild test robot]

Fixes: da8a916b6b6d ("drm/amdgpu: conditionally compile amdgpu's amdkfd files")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 amdgpu_amdkfd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index 930d27d..f48dca2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -41,7 +41,7 @@ static const struct amdgpu_amdkfd_if amdkfd_if = {
 #endif
 
 const struct kgd2kfd_calls *kgd2kfd;
-const struct amdgpu_amdkfd_if *amdgpu_amdkfd_if;
+static const struct amdgpu_amdkfd_if *amdgpu_amdkfd_if;
 bool (*kgd2kfd_init_p)(unsigned int, const struct kgd2kfd_calls**);
 
 static const unsigned int compute_vmid_bitmap = 0xFF00;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel