From: Mark Brown <broonie@kernel.org>
To: Sergey Suloev <ssuloev@orpaltech.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] spi: sun6i: coding style/readability improvements
Date: Thu, 17 May 2018 16:03:07 +0900 [thread overview]
Message-ID: <20180517070307.GP20254@sirena.org.uk> (raw)
In-Reply-To: <20180330125047.13936-2-ssuloev@orpaltech.com>
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On Fri, Mar 30, 2018 at 03:50:42PM +0300, Sergey Suloev wrote:
> Minor changes to fulfill the coding style and improve
> the readability of the code.
>
> Changes in v2:
> 1) Fixed issue with misplacing a piece of code that requires access
> to the transfer structure into sun6i_spi_prepare_message() function
> where the transfer structure is not available.
Place inter-version changelogs after the --- as covered in
SubmittingPatches.
>
> Signed-off-by: Sergey Suloev <ssuloev@orpaltech.com>
>
> ---
> drivers/spi/spi-sun6i.c | 97 +++++++++++++++++++++++++++++--------------------
This is a *very* large change doing a whole bunch of different things,
including some fairly substantial changes like moving things into
different functions but the changelog doesn't provide any details at all
on what the changes are supposed to be. This makes it difficult to
review, it should be split into separate patches each doing one clerly
described thing (I'm guessing this might be part of why the AllWinner
maintainers haven't reviewed the series).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/6] spi: sun6i: coding style/readability improvements
Date: Thu, 17 May 2018 16:03:07 +0900 [thread overview]
Message-ID: <20180517070307.GP20254@sirena.org.uk> (raw)
In-Reply-To: <20180330125047.13936-2-ssuloev@orpaltech.com>
On Fri, Mar 30, 2018 at 03:50:42PM +0300, Sergey Suloev wrote:
> Minor changes to fulfill the coding style and improve
> the readability of the code.
>
> Changes in v2:
> 1) Fixed issue with misplacing a piece of code that requires access
> to the transfer structure into sun6i_spi_prepare_message() function
> where the transfer structure is not available.
Place inter-version changelogs after the --- as covered in
SubmittingPatches.
>
> Signed-off-by: Sergey Suloev <ssuloev@orpaltech.com>
>
> ---
> drivers/spi/spi-sun6i.c | 97 +++++++++++++++++++++++++++++--------------------
This is a *very* large change doing a whole bunch of different things,
including some fairly substantial changes like moving things into
different functions but the changelog doesn't provide any details at all
on what the changes are supposed to be. This makes it difficult to
review, it should be split into separate patches each doing one clerly
described thing (I'm guessing this might be part of why the AllWinner
maintainers haven't reviewed the series).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180517/f12fefa3/attachment-0001.sig>
next prev parent reply other threads:[~2018-05-17 16:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 12:50 [PATCH v2 0/6] spi: Add support for DMA transfers in sun6i SPI driver Sergey Suloev
2018-03-30 12:50 ` Sergey Suloev
2018-03-30 12:50 ` [PATCH v2 1/6] spi: sun6i: coding style/readability improvements Sergey Suloev
2018-03-30 12:50 ` Sergey Suloev
2018-05-17 7:03 ` Mark Brown [this message]
2018-05-17 7:03 ` Mark Brown
2018-05-18 14:29 ` Maxime Ripard
2018-05-18 14:29 ` Maxime Ripard
2018-03-30 12:50 ` [PATCH v2 2/6] spi: sun6i: handle chip select polarity flag Sergey Suloev
2018-03-30 12:50 ` Sergey Suloev
2018-05-17 7:07 ` Mark Brown
2018-05-17 7:07 ` Mark Brown
2018-03-30 12:50 ` [PATCH v2 3/6] spi: sun6i: restrict transfer length in PIO-mode Sergey Suloev
2018-03-30 12:50 ` Sergey Suloev
2018-05-17 7:09 ` Mark Brown
2018-05-17 7:09 ` Mark Brown
2018-03-30 12:50 ` [PATCH v2 4/6] spi: sun6i: use completion provided by SPI core Sergey Suloev
2018-03-30 12:50 ` Sergey Suloev
2018-03-30 12:50 ` [PATCH v2 5/6] spi: sun6i: introduce register set/unset helpers Sergey Suloev
2018-03-30 12:50 ` Sergey Suloev
2018-03-30 12:50 ` [PATCH v2 6/6] spi: sun6i: add DMA transfers support Sergey Suloev
2018-03-30 12:50 ` Sergey Suloev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517070307.GP20254@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=ssuloev@orpaltech.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.