* [PATCH] drm/amd/pp: missing curly braces in smu7_enable_sclk_mclk_dpm()
@ 2018-05-17 12:56 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-05-17 12:56 UTC (permalink / raw)
To: Alex Deucher, Eric Huang
Cc: David (ChunMing) Zhou, David Airlie,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Evan Quan, Rex Zhu,
Christian König
We added some more lines of code to this if statement but forgot to add
curly braces.
Fixes: 0c24e7ef233b ("drm/amd/powerplay: add specific changes for VEGAM in smu7_hwmgr.c")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
index 8eb3f5176646..646c9e9bf681 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
@@ -1018,7 +1018,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
/* enable SCLK dpm */
- if (!data->sclk_dpm_key_disabled)
+ if (!data->sclk_dpm_key_disabled) {
if (hwmgr->chip_id = CHIP_VEGAM)
smu7_disable_sclk_vce_handshake(hwmgr);
@@ -1026,6 +1026,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
(0 = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_DPM_Enable)),
"Failed to enable SCLK DPM during DPM Start Function!",
return -EINVAL);
+ }
/* enable MCLK dpm */
if (0 = data->mclk_dpm_key_disabled) {
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/amd/pp: missing curly braces in smu7_enable_sclk_mclk_dpm()
@ 2018-05-17 12:56 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-05-17 12:56 UTC (permalink / raw)
To: Alex Deucher, Eric Huang
Cc: David (ChunMing) Zhou, David Airlie,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Evan Quan, Rex Zhu,
Christian König
We added some more lines of code to this if statement but forgot to add
curly braces.
Fixes: 0c24e7ef233b ("drm/amd/powerplay: add specific changes for VEGAM in smu7_hwmgr.c")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
index 8eb3f5176646..646c9e9bf681 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
@@ -1018,7 +1018,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
/* enable SCLK dpm */
- if (!data->sclk_dpm_key_disabled)
+ if (!data->sclk_dpm_key_disabled) {
if (hwmgr->chip_id == CHIP_VEGAM)
smu7_disable_sclk_vce_handshake(hwmgr);
@@ -1026,6 +1026,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
(0 == smum_send_msg_to_smc(hwmgr, PPSMC_MSG_DPM_Enable)),
"Failed to enable SCLK DPM during DPM Start Function!",
return -EINVAL);
+ }
/* enable MCLK dpm */
if (0 == data->mclk_dpm_key_disabled) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/pp: missing curly braces in smu7_enable_sclk_mclk_dpm()
2018-05-17 12:56 ` Dan Carpenter
@ 2018-05-17 15:38 ` Alex Deucher
-1 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2018-05-17 15:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: David (ChunMing) Zhou, David Airlie,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, amd-gfx list, Eric Huang,
Alex Deucher, Evan Quan, Rex Zhu, Christian König
On Thu, May 17, 2018 at 8:56 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We added some more lines of code to this if statement but forgot to add
> curly braces.
>
> Fixes: 0c24e7ef233b ("drm/amd/powerplay: add specific changes for VEGAM in smu7_hwmgr.c")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index 8eb3f5176646..646c9e9bf681 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -1018,7 +1018,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
> struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
>
> /* enable SCLK dpm */
> - if (!data->sclk_dpm_key_disabled)
> + if (!data->sclk_dpm_key_disabled) {
> if (hwmgr->chip_id = CHIP_VEGAM)
> smu7_disable_sclk_vce_handshake(hwmgr);
>
> @@ -1026,6 +1026,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
> (0 = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_DPM_Enable)),
> "Failed to enable SCLK DPM during DPM Start Function!",
> return -EINVAL);
> + }
>
> /* enable MCLK dpm */
> if (0 = data->mclk_dpm_key_disabled) {
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/pp: missing curly braces in smu7_enable_sclk_mclk_dpm()
@ 2018-05-17 15:38 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2018-05-17 15:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: David (ChunMing) Zhou, David Airlie,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, amd-gfx list, Eric Huang,
Alex Deucher, Evan Quan, Rex Zhu, Christian König
On Thu, May 17, 2018 at 8:56 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We added some more lines of code to this if statement but forgot to add
> curly braces.
>
> Fixes: 0c24e7ef233b ("drm/amd/powerplay: add specific changes for VEGAM in smu7_hwmgr.c")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index 8eb3f5176646..646c9e9bf681 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -1018,7 +1018,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
> struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
>
> /* enable SCLK dpm */
> - if (!data->sclk_dpm_key_disabled)
> + if (!data->sclk_dpm_key_disabled) {
> if (hwmgr->chip_id == CHIP_VEGAM)
> smu7_disable_sclk_vce_handshake(hwmgr);
>
> @@ -1026,6 +1026,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
> (0 == smum_send_msg_to_smc(hwmgr, PPSMC_MSG_DPM_Enable)),
> "Failed to enable SCLK DPM during DPM Start Function!",
> return -EINVAL);
> + }
>
> /* enable MCLK dpm */
> if (0 == data->mclk_dpm_key_disabled) {
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-17 15:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-17 12:56 [PATCH] drm/amd/pp: missing curly braces in smu7_enable_sclk_mclk_dpm() Dan Carpenter
2018-05-17 12:56 ` Dan Carpenter
2018-05-17 15:38 ` Alex Deucher
2018-05-17 15:38 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.