[U-Boot] [PATCH v2] net: MVGBE don't automatically select PHYLIB

[U-Boot] [PATCH v2] net: MVGBE don't automatically select PHYLIB

[Chris Packham]

When Kconfig support was added for MVGBE it included automatically
selected PHYLIB support. But MVGBE does not need PHYLIB it will build
fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE")
should have been a no-op in terms of build size but because of the
selecting PHYLIB the openrd configs increased in size.

Remove the automatic selection of PHYLIB, boards that need it will have
already enabled it in their config header file.

Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

Changes in v2:
- reword commit message to make the intent a bit clearer

 drivers/net/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index c962d7a72c0c..f2cc75f494e8 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -181,7 +181,6 @@ config FTMAC100
 config MVGBE
 	bool "Marvell Orion5x/Kirkwood network interface support"
 	depends on KIRKWOOD || ORION5X
-	select PHYLIB
 	help
 	  This driver supports the network interface units in the
 	  Marvell Orion5x and Kirkwood SoCs
-- 
2.17.0

[U-Boot] [PATCH v2] net: MVGBE don't automatically select PHYLIB

[Tom Rini]

On Fri, May 18, 2018 at 12:12:04AM +1200, Chris Packham wrote:

> When Kconfig support was added for MVGBE it included automatically
> selected PHYLIB support. But MVGBE does not need PHYLIB it will build
> fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> should have been a no-op in terms of build size but because of the
> selecting PHYLIB the openrd configs increased in size.
> 
> Remove the automatic selection of PHYLIB, boards that need it will have
> already enabled it in their config header file.
> 
> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180517/253bc3b6/attachment.sig>

[U-Boot] [PATCH v2] net: MVGBE don't automatically select PHYLIB

[Joe Hershberger]

On Thu, May 17, 2018 at 7:12 AM, Chris Packham <judge.packham@gmail.com> wrote:
> When Kconfig support was added for MVGBE it included automatically
> selected PHYLIB support. But MVGBE does not need PHYLIB it will build
> fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> should have been a no-op in terms of build size but because of the
> selecting PHYLIB the openrd configs increased in size.
>
> Remove the automatic selection of PHYLIB, boards that need it will have
> already enabled it in their config header file.
>
> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Stefan, feel free to pull this through your branch.

Cheers,
-Joe

[U-Boot] [PATCH v2] net: MVGBE don't automatically select PHYLIB

[Stefan Roese]

On 17.05.2018 17:30, Joe Hershberger wrote:
> On Thu, May 17, 2018 at 7:12 AM, Chris Packham <judge.packham@gmail.com> wrote:
>> When Kconfig support was added for MVGBE it included automatically
>> selected PHYLIB support. But MVGBE does not need PHYLIB it will build
>> fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE")
>> should have been a no-op in terms of build size but because of the
>> selecting PHYLIB the openrd configs increased in size.
>>
>> Remove the automatic selection of PHYLIB, boards that need it will have
>> already enabled it in their config header file.
>>
>> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
>> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> 
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> 
> Stefan, feel free to pull this through your branch.

Thanks, will do.

Thanks,
Stefan