[PATCH 0/1] Handling of serializers

[PATCH 0/1] Handling of serializers

[Vishal Thanki]

On a custom AM33xx based platform, we use 4 channels for audio output (2
* Left/Right) by making use of two TX serializers. The audio input path
only uses 2 channels, hence one RX serializer. If the recording is
started before the playback, the playback cannot make use of all 4
channels because of the imposed max number of channels by recording. And
if playback is started before recording, the hw_params set during
recording stream would disable an active TX serializer which causes
audio distortion. I have tried to fix this unwanted behavior in
following patch. Please comment if this should be done differently.

Vishal Thanki (1):
  ASoC: davinci-mcasp: Only disable inactive serializer

 sound/soc/davinci/davinci-mcasp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.14.3

[PATCH 1/1] ASoC: davinci-mcasp: Only disable inactive serializer

[Vishal Thanki]

As a side effect of the following commit, the active TX
serializer may get disabled which may result in distorted
audio output.

ASoC: davinci-mcasp: Add support for multichannel playback
(2952b27e2e463b28d5c0f04000f96b968137ca42)

For example, if a 4 channel I2S playback with two TX serializers
is activated. Later on, if a recording of 2 channels, with only 1 RX
serializer is started, which will also disable one of the TX
serializer because max_active_serializers is only calculated for
RX (recording) stream. This patch fixes this issue.

Signed-off-by: Vishal Thanki <vishalthanki@gmail.com>
---
 sound/soc/davinci/davinci-mcasp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index 03ba218160ca..f382dd55cae0 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -789,7 +789,7 @@ static int mcasp_common_hw_param(struct davinci_mcasp *mcasp, int stream,
 					rx_ser < max_active_serializers) {
 			mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG, AXR(i));
 			rx_ser++;
-		} else {
+		} else if (mcasp->serial_dir[i] == INACTIVE_MODE) {
 			mcasp_mod_bits(mcasp, DAVINCI_MCASP_XRSRCTL_REG(i),
 				       SRMOD_INACTIVE, SRMOD_MASK);
 		}
-- 
2.14.3

Re: [PATCH 1/1] ASoC: davinci-mcasp: Only disable inactive serializer

[Peter Ujfalusi]

On 2018-02-27 16:51, Vishal Thanki wrote:
> As a side effect of the following commit, the active TX
> serializer may get disabled which may result in distorted
> audio output.
> 
> ASoC: davinci-mcasp: Add support for multichannel playback
> (2952b27e2e463b28d5c0f04000f96b968137ca42)
> 
> For example, if a 4 channel I2S playback with two TX serializers
> is activated. Later on, if a recording of 2 channels, with only 1 RX
> serializer is started, which will also disable one of the TX
> serializer because max_active_serializers is only calculated for
> RX (recording) stream. This patch fixes this issue.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Signed-off-by: Vishal Thanki <vishalthanki@gmail.com>
> ---
>  sound/soc/davinci/davinci-mcasp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 03ba218160ca..f382dd55cae0 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -789,7 +789,7 @@ static int mcasp_common_hw_param(struct davinci_mcasp *mcasp, int stream,
>  					rx_ser < max_active_serializers) {
>  			mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG, AXR(i));
>  			rx_ser++;
> -		} else {
> +		} else if (mcasp->serial_dir[i] == INACTIVE_MODE) {
>  			mcasp_mod_bits(mcasp, DAVINCI_MCASP_XRSRCTL_REG(i),
>  				       SRMOD_INACTIVE, SRMOD_MASK);
>  		}
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 1/1] ASoC: davinci-mcasp: Only disable inactive serializer

[Vishal Thanki]

Hi Mark,

On Mon, Mar 5, 2018 at 1:42 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>
>
> On 2018-02-27 16:51, Vishal Thanki wrote:
>> As a side effect of the following commit, the active TX
>> serializer may get disabled which may result in distorted
>> audio output.
>>
>> ASoC: davinci-mcasp: Add support for multichannel playback
>> (2952b27e2e463b28d5c0f04000f96b968137ca42)
>>
>> For example, if a 4 channel I2S playback with two TX serializers
>> is activated. Later on, if a recording of 2 channels, with only 1 RX
>> serializer is started, which will also disable one of the TX
>> serializer because max_active_serializers is only calculated for
>> RX (recording) stream. This patch fixes this issue.
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
>> Signed-off-by: Vishal Thanki <vishalthanki@gmail.com>

Just a gentle reminder, can this patch be accepted for the next release?

Regards,
Vishal

Re: [PATCH 1/1] ASoC: davinci-mcasp: Only disable inactive serializer

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 666 bytes --]

On Tue, Mar 27, 2018 at 01:34:55PM +0200, Vishal Thanki wrote:

> Just a gentle reminder, can this patch be accepted for the next release?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings just adds to the mail volume (if they are
seen at all) and if something has gone wrong you'll have to resend the
patches anyway.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 1/1] ASoC: davinci-mcasp: Only disable inactive serializer

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 695 bytes --]

On Tue, Mar 27, 2018 at 01:34:55PM +0200, Vishal Thanki wrote:
> On Mon, Mar 5, 2018 at 1:42 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:

> > Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> >> Signed-off-by: Vishal Thanki <vishalthanki@gmail.com>

> Just a gentle reminder, can this patch be accepted for the next release?

Oh, and it was just pointed out to me:

As documented in SubmittingPatches please send patches to the 
maintainers for the code you would like to change.  The normal kernel
workflow is that people apply patches from their inboxes, if they aren't
copied they are likely to not see the patch at all and it is much more
difficult to apply patches.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Applied "ASoC: davinci-mcasp: Only disable inactive serializer" to the asoc tree

[Mark Brown]

The patch

   ASoC: davinci-mcasp: Only disable inactive serializer

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 096a8f835e7d19f0402386353586d285566eee06 Mon Sep 17 00:00:00 2001
From: Vishal Thanki <vishalthanki@gmail.com>
Date: Fri, 11 May 2018 14:33:37 +0200
Subject: [PATCH] ASoC: davinci-mcasp: Only disable inactive serializer

As a side effect of the following commit, the active TX
serializer may get disabled which may result in distorted
audio output.

ASoC: davinci-mcasp: Add support for multichannel playback
(2952b27e2e463b28d5c0f04000f96b968137ca42)

For example, if a 4 channel I2S playback with two TX serializers
is activated. Later on, if a recording of 2 channels, with only 1 RX
serializer is started, which will also disable one of the TX
serializer because max_active_serializers is only calculated for
RX (recording) stream. This patch fixes this issue.

Signed-off-by: Vishal Thanki <vishalthanki@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/davinci/davinci-mcasp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index 79fc4aa2fa29..1f96c9dbe9c4 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -789,7 +789,7 @@ static int mcasp_common_hw_param(struct davinci_mcasp *mcasp, int stream,
 					rx_ser < max_active_serializers) {
 			mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG, AXR(i));
 			rx_ser++;
-		} else {
+		} else if (mcasp->serial_dir[i] == INACTIVE_MODE) {
 			mcasp_mod_bits(mcasp, DAVINCI_MCASP_XRSRCTL_REG(i),
 				       SRMOD_INACTIVE, SRMOD_MASK);
 		}
-- 
2.17.0