From: Nicholas Piggin <npiggin@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>,
Ulf Magnusson <ulfalizer@gmail.com>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Emese Revfy <re.emese@gmail.com>,
x86@kernel.org
Subject: Re: [PATCH v4 00/31] kconfig: move compiler capability tests to Kconfig
Date: Thu, 17 May 2018 17:51:56 +1000 [thread overview]
Message-ID: <20180517175156.4c4246f6@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <1526537830-22606-1-git-send-email-yamada.masahiro@socionext.com>
On Thu, 17 May 2018 15:16:39 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> [Introduction]
>
> The motivation of this work is to move the compiler option tests to
> Kconfig from Makefile. A number of kernel features require the
> compiler support. Enabling such features blindly in Kconfig ends up
> with a lot of nasty build-time testing in Makefiles. If a chosen
> feature turns out unsupported by the compiler, what the build system
> can do is either to disable it (silently!) or to forcibly break the
> build, despite Kconfig has let the user to enable it. By moving the
> compiler capability tests to Kconfig, Kconfig entries will be visible
> only when they are available.
>
> [Major Changes in V4]
Do you have a git tree for v4? I can test it with the powerpc patches.
The new scripting capability in kconfig has allowed us to already
improve the config process on powerpc:
https://marc.info/?l=linuxppc-embedded&m=152648110727868&w=2
I'm sure there's more clever things we can do with it but I haven't
had time to think about it yet. One thing that comes to mind is that
It might be nice to show the option as disabled, then the user could
upgrade their compiler to get the options they want.
Anyway v3 worked fine for me, the documentation is really nice, I
could implement the above patch without any problem despite being a
kbuild dummy. Thanks for the series, ack from me.
Thanks,
Nick
next prev parent reply other threads:[~2018-05-17 7:52 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 6:16 [PATCH v4 00/31] kconfig: move compiler capability tests to Kconfig Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 01/31] kbuild: remove kbuild cache Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 02/31] kbuild: remove CONFIG_CROSS_COMPILE support Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env=' Masahiro Yamada
2018-05-20 15:46 ` Ulf Magnusson
2018-05-21 4:43 ` Masahiro Yamada
2018-05-21 11:06 ` Ulf Magnusson
2018-05-21 11:11 ` Ulf Magnusson
2018-05-24 4:45 ` Masahiro Yamada
2018-05-26 20:47 ` Ulf Magnusson
2018-05-17 6:16 ` [PATCH v4 04/31] kconfig: remove string expansion in file_lookup() Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse() Masahiro Yamada
2018-05-20 14:39 ` Sam Ravnborg
2018-05-21 5:38 ` Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 06/31] kconfig: remove sym_expand_string_value() Masahiro Yamada
2018-05-17 6:28 ` Kees Cook
2018-05-17 6:16 ` [PATCH v4 07/31] kconfig: add built-in function support Masahiro Yamada
2018-05-20 14:50 ` Sam Ravnborg
2018-05-21 5:18 ` Masahiro Yamada
2018-05-21 6:16 ` Sam Ravnborg
2018-05-21 6:41 ` Masahiro Yamada
2018-05-21 7:14 ` Sam Ravnborg
2018-05-21 14:23 ` Ulf Magnusson
2018-05-21 14:32 ` Ulf Magnusson
2018-05-21 15:10 ` Ulf Magnusson
2018-05-22 3:11 ` Masahiro Yamada
2018-05-22 4:50 ` Ulf Magnusson
2018-05-22 4:58 ` Ulf Magnusson
2018-05-17 6:16 ` [PATCH v4 08/31] kconfig: add 'shell' built-in function Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 09/31] kconfig: replace $(UNAME_RELEASE) with function call Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 10/31] kconfig: begin PARAM state only when seeing a command keyword Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 11/31] kconfig: support user-defined function and recursively expanded variable Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 12/31] kconfig: support simply " Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 13/31] kconfig: support append assignment operator Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 14/31] kconfig: expand lefthand side of assignment statement Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 15/31] kconfig: add 'info', 'warning', and 'error' built-in functions Masahiro Yamada
2018-05-17 6:38 ` Kees Cook
2018-05-17 6:16 ` [PATCH v4 16/31] kconfig: add 'if' built-in function Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 17/31] kconfig: add 'filename' and 'lineno' built-in variables Masahiro Yamada
2018-05-17 6:39 ` Kees Cook
2018-05-17 6:16 ` [PATCH v4 18/31] kconfig: error out if a recursive variable references itself Masahiro Yamada
2018-05-17 6:16 ` [PATCH v4 19/31] Documentation: kconfig: document a new Kconfig macro language Masahiro Yamada
2018-05-17 6:38 ` Kees Cook
2018-05-17 6:38 ` Kees Cook
2018-05-17 6:55 ` Masahiro Yamada
2018-05-17 6:55 ` Masahiro Yamada
2018-05-26 2:14 ` Randy Dunlap
2018-05-17 6:16 ` [PATCH v4 20/31] kconfig: test: add Kconfig macro language tests Masahiro Yamada
2018-05-17 6:41 ` Kees Cook
2018-05-17 6:48 ` Masahiro Yamada
2018-05-17 6:17 ` [PATCH v4 21/31] kconfig: show compiler version text in the top comment Masahiro Yamada
2018-05-17 6:17 ` [PATCH v4 22/31] kconfig: add basic helper macros to scripts/Kconfig.include Masahiro Yamada
2018-05-17 6:17 ` [PATCH v4 23/31] stack-protector: test compiler capability in Kconfig and drop AUTO mode Masahiro Yamada
2018-05-17 6:26 ` Kees Cook
2018-05-17 6:17 ` [PATCH v4 24/31] kconfig: add CC_IS_GCC and GCC_VERSION Masahiro Yamada
2018-05-17 6:17 ` [PATCH v4 25/31] kconfig: add CC_IS_CLANG and CLANG_VERSION Masahiro Yamada
2018-05-17 6:17 ` [PATCH v4 26/31] gcov: remove CONFIG_GCOV_FORMAT_AUTODETECT Masahiro Yamada
2018-05-17 6:17 ` [PATCH v4 27/31] kcov: test compiler capability in Kconfig and correct dependency Masahiro Yamada
2018-05-17 6:33 ` Kees Cook
2018-05-17 6:17 ` [PATCH v4 28/31] gcc-plugins: move GCC version check for PowerPC to Kconfig Masahiro Yamada
2018-05-17 6:29 ` Kees Cook
2018-05-17 6:17 ` [PATCH v4 29/31] gcc-plugins: test plugin support in Kconfig and clean up Makefile Masahiro Yamada
2018-05-17 6:32 ` Kees Cook
2018-05-17 6:17 ` [PATCH v4 30/31] gcc-plugins: allow to enable GCC_PLUGINS for COMPILE_TEST Masahiro Yamada
2018-05-17 6:27 ` Kees Cook
2018-05-17 6:17 ` [PATCH v4 31/31] arm64: move GCC version check for ARCH_SUPPORTS_INT128 to Kconfig Masahiro Yamada
2018-05-17 7:51 ` Nicholas Piggin [this message]
2018-05-17 14:22 ` [PATCH v4 00/31] kconfig: move compiler capability tests " Masahiro Yamada
2018-05-22 5:37 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517175156.4c4246f6@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=re.emese@gmail.com \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=ulfalizer@gmail.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.