* [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"
@ 2018-05-18 10:09 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2018-05-18 10:09 UTC (permalink / raw)
To: Jes Sorensen, David S . Miller, linux-hippi, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to spelling mistake in printk message text
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/hippi/rrunner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
index 1ab97d99b9ba..f41116488079 100644
--- a/drivers/net/hippi/rrunner.c
+++ b/drivers/net/hippi/rrunner.c
@@ -867,7 +867,7 @@ static u32 rr_handle_event(struct net_device *dev, u32 prodidx, u32 eidx)
dev->name);
goto drop;
case E_FRM_ERR:
- printk(KERN_WARNING "%s: Framming Error\n",
+ printk(KERN_WARNING "%s: Framing Error\n",
dev->name);
goto drop;
case E_FLG_SYN_ERR:
--
2.17.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"
@ 2018-05-18 10:09 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2018-05-18 10:09 UTC (permalink / raw)
To: Jes Sorensen, David S . Miller, linux-hippi, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to spelling mistake in printk message text
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/hippi/rrunner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
index 1ab97d99b9ba..f41116488079 100644
--- a/drivers/net/hippi/rrunner.c
+++ b/drivers/net/hippi/rrunner.c
@@ -867,7 +867,7 @@ static u32 rr_handle_event(struct net_device *dev, u32 prodidx, u32 eidx)
dev->name);
goto drop;
case E_FRM_ERR:
- printk(KERN_WARNING "%s: Framming Error\n",
+ printk(KERN_WARNING "%s: Framing Error\n",
dev->name);
goto drop;
case E_FLG_SYN_ERR:
--
2.17.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"
2018-05-18 10:09 ` Colin King
@ 2018-05-18 14:33 ` Jes Sorensen
-1 siblings, 0 replies; 8+ messages in thread
From: Jes Sorensen @ 2018-05-18 14:33 UTC (permalink / raw)
To: Colin King, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
On 05/18/2018 06:09 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in printk message text
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/hippi/rrunner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
> index 1ab97d99b9ba..f41116488079 100644
> --- a/drivers/net/hippi/rrunner.c
> +++ b/drivers/net/hippi/rrunner.c
> @@ -867,7 +867,7 @@ static u32 rr_handle_event(struct net_device *dev, u32 prodidx, u32 eidx)
> dev->name);
> goto drop;
> case E_FRM_ERR:
> - printk(KERN_WARNING "%s: Framming Error\n",
> + printk(KERN_WARNING "%s: Framing Error\n",
> dev->name);
> goto drop;
> case E_FLG_SYN_ERR:
>
Fine with me! I do wonder if it's time to retire this driver and the
HIPPI code. I haven't had access to hardware for over a decade so I have
no idea if it even works anymore.
Jes
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"
@ 2018-05-18 14:33 ` Jes Sorensen
0 siblings, 0 replies; 8+ messages in thread
From: Jes Sorensen @ 2018-05-18 14:33 UTC (permalink / raw)
To: Colin King, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
On 05/18/2018 06:09 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in printk message text
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/hippi/rrunner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
> index 1ab97d99b9ba..f41116488079 100644
> --- a/drivers/net/hippi/rrunner.c
> +++ b/drivers/net/hippi/rrunner.c
> @@ -867,7 +867,7 @@ static u32 rr_handle_event(struct net_device *dev, u32 prodidx, u32 eidx)
> dev->name);
> goto drop;
> case E_FRM_ERR:
> - printk(KERN_WARNING "%s: Framming Error\n",
> + printk(KERN_WARNING "%s: Framing Error\n",
> dev->name);
> goto drop;
> case E_FLG_SYN_ERR:
>
Fine with me! I do wonder if it's time to retire this driver and the
HIPPI code. I haven't had access to hardware for over a decade so I have
no idea if it even works anymore.
Jes
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"
2018-05-18 14:33 ` Jes Sorensen
@ 2018-05-18 15:26 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2018-05-18 15:26 UTC (permalink / raw)
To: jes.sorensen; +Cc: colin.king, netdev, kernel-janitors, linux-kernel
From: Jes Sorensen <jes.sorensen@gmail.com>
Date: Fri, 18 May 2018 10:33:50 -0400
> I do wonder if it's time to retire this driver and the HIPPI code. I
> haven't had access to hardware for over a decade so I have no idea
> if it even works anymore.
That's a good question.
If you really think nobody is using this stuff, yes we can remove it.
Then if someone brings it to our attention that there are users, we
can very easily bring it back.
But as the HIPPI maintiner it is really up to you.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"
@ 2018-05-18 15:26 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2018-05-18 15:26 UTC (permalink / raw)
To: jes.sorensen; +Cc: colin.king, netdev, kernel-janitors, linux-kernel
From: Jes Sorensen <jes.sorensen@gmail.com>
Date: Fri, 18 May 2018 10:33:50 -0400
> I do wonder if it's time to retire this driver and the HIPPI code. I
> haven't had access to hardware for over a decade so I have no idea
> if it even works anymore.
That's a good question.
If you really think nobody is using this stuff, yes we can remove it.
Then if someone brings it to our attention that there are users, we
can very easily bring it back.
But as the HIPPI maintiner it is really up to you.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"
2018-05-18 10:09 ` Colin King
@ 2018-05-18 17:46 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2018-05-18 17:46 UTC (permalink / raw)
To: colin.king; +Cc: jes, linux-hippi, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Fri, 18 May 2018 11:09:22 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in printk message text
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"
@ 2018-05-18 17:46 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2018-05-18 17:46 UTC (permalink / raw)
To: colin.king; +Cc: jes, linux-hippi, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Fri, 18 May 2018 11:09:22 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in printk message text
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-05-18 17:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-18 10:09 [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing" Colin King
2018-05-18 10:09 ` Colin King
2018-05-18 14:33 ` Jes Sorensen
2018-05-18 14:33 ` Jes Sorensen
2018-05-18 15:26 ` David Miller
2018-05-18 15:26 ` David Miller
2018-05-18 17:46 ` David Miller
2018-05-18 17:46 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.