All of lore.kernel.org
 help / color / mirror / Atom feed
* [net-next:master 1200/1233] net/ipv4/tcp_recovery.c:24:5: sparse: symbol 'tcp_rack_reo_wnd' was not declared. Should it be static?
@ 2018-05-18  5:14 kbuild test robot
  2018-05-18  5:14 ` [RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-05-18  5:14 UTC (permalink / raw)
  To: Yuchung Cheng
  Cc: kbuild-all, netdev, Neal Cardwell, Eric Dumazet,
	Soheil Hassas Yeganeh, Priyaranjan Jha, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   538e2de104cfb4ef1acb35af42427bff42adbe4d
commit: 20b654dfe1beaca60ab51894ff405a049248433d [1200/1233] tcp: support DUPACK threshold in RACK
reproduce:
        # apt-get install sparse
        git checkout 20b654dfe1beaca60ab51894ff405a049248433d
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   net/ipv4/tcp_recovery.c:46:16: sparse: expression using sizeof(void)
   net/ipv4/tcp_recovery.c:46:16: sparse: expression using sizeof(void)
>> net/ipv4/tcp_recovery.c:24:5: sparse: symbol 'tcp_rack_reo_wnd' was not declared. Should it be static?
   include/net/tcp.h:738:16: sparse: expression using sizeof(void)
   net/ipv4/tcp_recovery.c:102:40: sparse: expression using sizeof(void)
   net/ipv4/tcp_recovery.c:102:40: sparse: expression using sizeof(void)
   include/net/tcp.h:738:16: sparse: expression using sizeof(void)
   net/ipv4/tcp_recovery.c:210:42: sparse: expression using sizeof(void)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static
  2018-05-18  5:14 [net-next:master 1200/1233] net/ipv4/tcp_recovery.c:24:5: sparse: symbol 'tcp_rack_reo_wnd' was not declared. Should it be static? kbuild test robot
@ 2018-05-18  5:14 ` kbuild test robot
  2018-05-18 17:28   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-05-18  5:14 UTC (permalink / raw)
  To: Yuchung Cheng
  Cc: kbuild-all, netdev, Neal Cardwell, Eric Dumazet,
	Soheil Hassas Yeganeh, Priyaranjan Jha, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, linux-kernel


Fixes: 20b654dfe1be ("tcp: support DUPACK threshold in RACK")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 tcp_recovery.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/tcp_recovery.c b/net/ipv4/tcp_recovery.c
index 30cbfb6..71593e4 100644
--- a/net/ipv4/tcp_recovery.c
+++ b/net/ipv4/tcp_recovery.c
@@ -21,7 +21,7 @@ static bool tcp_rack_sent_after(u64 t1, u64 t2, u32 seq1, u32 seq2)
 	return t1 > t2 || (t1 == t2 && after(seq1, seq2));
 }
 
-u32 tcp_rack_reo_wnd(const struct sock *sk)
+static u32 tcp_rack_reo_wnd(const struct sock *sk)
 {
 	struct tcp_sock *tp = tcp_sk(sk);
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static
  2018-05-18  5:14 ` [RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static kbuild test robot
@ 2018-05-18 17:28   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-05-18 17:28 UTC (permalink / raw)
  To: fengguang.wu
  Cc: ycheng, kbuild-all, netdev, ncardwell, edumazet, soheil,
	priyarjha, kuznet, yoshfuji, linux-kernel

From: kbuild test robot <fengguang.wu@intel.com>
Date: Fri, 18 May 2018 13:14:23 +0800

> Fixes: 20b654dfe1be ("tcp: support DUPACK threshold in RACK")
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>

Looks good, applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-18 17:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-18  5:14 [net-next:master 1200/1233] net/ipv4/tcp_recovery.c:24:5: sparse: symbol 'tcp_rack_reo_wnd' was not declared. Should it be static? kbuild test robot
2018-05-18  5:14 ` [RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static kbuild test robot
2018-05-18 17:28   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.