All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] intel-gpu-overlay: Fix some build warnings
@ 2018-05-18 16:12 ` Tvrtko Ursulin
  0 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2018-05-18 16:12 UTC (permalink / raw)
  To: igt-dev; +Cc: intel-gfx

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Trivial "set but unused" cleanup.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 overlay/x11/x11-overlay.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/overlay/x11/x11-overlay.c b/overlay/x11/x11-overlay.c
index ae6494295c5a..ac6b5f39a696 100644
--- a/overlay/x11/x11-overlay.c
+++ b/overlay/x11/x11-overlay.c
@@ -123,7 +123,6 @@ cairo_surface_t *
 x11_overlay_create(struct config *config, int *width, int *height)
 {
 	Display *dpy;
-	Screen *scr;
 	cairo_surface_t *surface;
 	struct drm_i915_gem_create create;
 	struct drm_gem_flink flink;
@@ -135,7 +134,6 @@ x11_overlay_create(struct config *config, int *width, int *height)
 	XvImage *image;
 	XvPortID port = -1;
 	void *ptr, *mem;
-	enum position position;
 
 	dpy = XOpenDisplay(NULL);
 	if (dpy == NULL)
@@ -143,7 +141,7 @@ x11_overlay_create(struct config *config, int *width, int *height)
 
 	XSetErrorHandler(check_error_handler);
 
-	scr = ScreenOfDisplay(dpy, DefaultScreen(dpy));
+	ScreenOfDisplay(dpy, DefaultScreen(dpy));
 
 	fd = dri2_open(dpy);
 	if (fd < 0)
@@ -179,7 +177,7 @@ x11_overlay_create(struct config *config, int *width, int *height)
 
 	XSetErrorHandler(noop);
 
-	position = x11_position(dpy, *width, *height, config, &x, &y, &w, &h);
+	x11_position(dpy, *width, *height, config, &x, &y, &w, &h);
 
 	image = XvCreateImage(dpy, port, FOURCC_RGB565, NULL, w, h);
 	if (image == NULL)
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] [PATCH i-g-t] intel-gpu-overlay: Fix some build warnings
@ 2018-05-18 16:12 ` Tvrtko Ursulin
  0 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2018-05-18 16:12 UTC (permalink / raw)
  To: igt-dev; +Cc: intel-gfx, Tvrtko Ursulin

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Trivial "set but unused" cleanup.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 overlay/x11/x11-overlay.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/overlay/x11/x11-overlay.c b/overlay/x11/x11-overlay.c
index ae6494295c5a..ac6b5f39a696 100644
--- a/overlay/x11/x11-overlay.c
+++ b/overlay/x11/x11-overlay.c
@@ -123,7 +123,6 @@ cairo_surface_t *
 x11_overlay_create(struct config *config, int *width, int *height)
 {
 	Display *dpy;
-	Screen *scr;
 	cairo_surface_t *surface;
 	struct drm_i915_gem_create create;
 	struct drm_gem_flink flink;
@@ -135,7 +134,6 @@ x11_overlay_create(struct config *config, int *width, int *height)
 	XvImage *image;
 	XvPortID port = -1;
 	void *ptr, *mem;
-	enum position position;
 
 	dpy = XOpenDisplay(NULL);
 	if (dpy == NULL)
@@ -143,7 +141,7 @@ x11_overlay_create(struct config *config, int *width, int *height)
 
 	XSetErrorHandler(check_error_handler);
 
-	scr = ScreenOfDisplay(dpy, DefaultScreen(dpy));
+	ScreenOfDisplay(dpy, DefaultScreen(dpy));
 
 	fd = dri2_open(dpy);
 	if (fd < 0)
@@ -179,7 +177,7 @@ x11_overlay_create(struct config *config, int *width, int *height)
 
 	XSetErrorHandler(noop);
 
-	position = x11_position(dpy, *width, *height, config, &x, &y, &w, &h);
+	x11_position(dpy, *width, *height, config, &x, &y, &w, &h);
 
 	image = XvCreateImage(dpy, port, FOURCC_RGB565, NULL, w, h);
 	if (image == NULL)
-- 
2.17.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] intel-gpu-overlay: Fix some build warnings
  2018-05-18 16:12 ` [igt-dev] " Tvrtko Ursulin
@ 2018-05-18 16:27   ` Chris Wilson
  -1 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-05-18 16:27 UTC (permalink / raw)
  To: Tvrtko Ursulin, igt-dev; +Cc: intel-gfx

Quoting Tvrtko Ursulin (2018-05-18 17:12:25)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Trivial "set but unused" cleanup.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel-gpu-overlay: Fix some build warnings
@ 2018-05-18 16:27   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-05-18 16:27 UTC (permalink / raw)
  To: Tvrtko Ursulin, igt-dev; +Cc: intel-gfx

Quoting Tvrtko Ursulin (2018-05-18 17:12:25)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Trivial "set but unused" cleanup.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for intel-gpu-overlay: Fix some build warnings
  2018-05-18 16:12 ` [igt-dev] " Tvrtko Ursulin
  (?)
  (?)
@ 2018-05-18 17:09 ` Patchwork
  -1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-18 17:09 UTC (permalink / raw)
  To: Tvrtko Ursulin; +Cc: igt-dev

== Series Details ==

Series: intel-gpu-overlay: Fix some build warnings
URL   : https://patchwork.freedesktop.org/series/43428/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4193 -> IGTPW_1375 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1375 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1375, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/43428/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1375:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1375 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-skl-6700k2:      PASS -> FAIL (fdo#103191, fdo#104724)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
      fi-cfl-s3:          FAIL (fdo#103481) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-cnl-psr:         DMESG-WARN (fdo#104951) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951


== Participating hosts (41 -> 38) ==

  Additional (3): fi-kbl-guc fi-cfl-guc fi-snb-2520m 
  Missing    (6): fi-ilk-m540 fi-bdw-5557u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-skl-6700hq 


== Build changes ==

    * IGT: IGT_4485 -> IGTPW_1375
    * Piglit: piglit_4485 -> piglit_4487

  CI_DRM_4193: 9322e3903ce6c89bde0c24877fe730b808427caf @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1375: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1375/
  IGT_4485: eccae1360d6d01e73c6af2bd97122cef708207ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4485: 62ef6b0db8967e7021fd3e0b57d03ff164b984fe @ git://anongit.freedesktop.org/piglit
  piglit_4487: 6ab75f7eb5e1dccbb773e1739beeb2d7cbd6ad0d @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1375/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for intel-gpu-overlay: Fix some build warnings
  2018-05-18 16:12 ` [igt-dev] " Tvrtko Ursulin
                   ` (2 preceding siblings ...)
  (?)
@ 2018-05-19  1:29 ` Patchwork
  -1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-19  1:29 UTC (permalink / raw)
  To: Tvrtko Ursulin; +Cc: igt-dev

== Series Details ==

Series: intel-gpu-overlay: Fix some build warnings
URL   : https://patchwork.freedesktop.org/series/43428/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4485_full -> IGTPW_1375_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1375_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1375_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/43428/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1375_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd1:
      shard-kbl:          PASS -> SKIP +2

    igt@gem_exec_schedule@deep-bsd2:
      shard-kbl:          SKIP -> PASS

    igt@kms_cursor_crc@cursor-128x128-random:
      shard-snb:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1375_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_eio@in-flight-1us:
      shard-apl:          PASS -> DMESG-WARN (fdo#106523) +4

    igt@gem_eio@throttle:
      shard-snb:          PASS -> DMESG-WARN (fdo#106523) +4
      shard-hsw:          PASS -> DMESG-WARN (fdo#106523) +4

    igt@gem_eio@unwedge-stress:
      shard-kbl:          PASS -> DMESG-WARN (fdo#106523) +1

    igt@gem_eio@wait-wedge-immediate:
      shard-glk:          PASS -> DMESG-WARN (fdo#106523) +2

    igt@gem_exec_schedule@smoketest-all:
      shard-apl:          PASS -> DMESG-WARN (fdo#103558, fdo#105602)

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
      shard-glk:          PASS -> FAIL (fdo#105703)

    igt@kms_cursor_crc@cursor-256x256-suspend:
      shard-apl:          PASS -> FAIL (fdo#104645, fdo#103191, fdo#103232, fdo#104724)

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105707)

    igt@kms_flip@2x-flip-vs-modeset-interruptible:
      shard-hsw:          PASS -> DMESG-WARN (fdo#102614)

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-hsw:          PASS -> FAIL (fdo#103928)

    igt@kms_flip@dpms-vs-vblank-race:
      shard-glk:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@plain-flip-fb-recreate:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt:
      shard-glk:          PASS -> FAIL (fdo#103167, fdo#104724)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          PASS -> FAIL (fdo#104724, fdo#103166)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@vecs0-s3:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS +1

    igt@gem_eio@in-flight-contexts-10ms:
      shard-kbl:          DMESG-WARN (fdo#106523) -> PASS +4
      shard-snb:          DMESG-WARN (fdo#106523) -> PASS +4

    igt@gem_eio@in-flight-contexts-immediate:
      shard-hsw:          DMESG-WARN (fdo#106523) -> PASS +4

    igt@gem_eio@in-flight-internal-immediate:
      shard-glk:          DMESG-WARN (fdo#106523) -> PASS +4

    igt@gem_eio@in-flight-suspend:
      shard-apl:          DMESG-WARN (fdo#106523) -> PASS +5

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
      shard-glk:          FAIL (fdo#105703) -> PASS

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#106509) -> PASS

    igt@kms_flip@2x-plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#105707) -> PASS +1

    igt@perf_pmu@idle-vcs0:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#104645 https://bugs.freedesktop.org/show_bug.cgi?id=104645
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
  fdo#105707 https://bugs.freedesktop.org/show_bug.cgi?id=105707
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#106523 https://bugs.freedesktop.org/show_bug.cgi?id=106523
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4485 -> IGTPW_1375
    * Linux: CI_DRM_4191 -> CI_DRM_4193
    * Piglit: piglit_4485 -> piglit_4487

  CI_DRM_4191: 70daebf1a83c2ed6eff118d2a2806086c0c89027 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4193: 9322e3903ce6c89bde0c24877fe730b808427caf @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1375: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1375/
  IGT_4485: eccae1360d6d01e73c6af2bd97122cef708207ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4485: 62ef6b0db8967e7021fd3e0b57d03ff164b984fe @ git://anongit.freedesktop.org/piglit
  piglit_4487: 6ab75f7eb5e1dccbb773e1739beeb2d7cbd6ad0d @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1375/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-05-19  1:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-18 16:12 [PATCH i-g-t] intel-gpu-overlay: Fix some build warnings Tvrtko Ursulin
2018-05-18 16:12 ` [igt-dev] " Tvrtko Ursulin
2018-05-18 16:27 ` Chris Wilson
2018-05-18 16:27   ` [Intel-gfx] " Chris Wilson
2018-05-18 17:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-05-19  1:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.