All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] stk1160: Fix typo s/therwise/Otherwise
@ 2018-05-18 21:07 Ezequiel Garcia
  2018-05-18 21:07 ` [PATCH] stk1160: Add missing calls to mutex_destroy Ezequiel Garcia
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2018-05-18 21:07 UTC (permalink / raw)
  To: linux-media; +Cc: kernel, Ezequiel Garcia

Fix a trivial typo.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 drivers/media/usb/stk1160/stk1160-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/stk1160/stk1160-core.c b/drivers/media/usb/stk1160/stk1160-core.c
index bea8bbbb84fb..881ba0283261 100644
--- a/drivers/media/usb/stk1160/stk1160-core.c
+++ b/drivers/media/usb/stk1160/stk1160-core.c
@@ -423,7 +423,7 @@ static void stk1160_disconnect(struct usb_interface *interface)
 
 	/*
 	 * This calls stk1160_release if it's the last reference.
-	 * therwise, release is posponed until there are no users left.
+	 * Otherwise, release is posponed until there are no users left.
 	 */
 	v4l2_device_put(&dev->v4l2_dev);
 }
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] stk1160: Add missing calls to mutex_destroy
  2018-05-18 21:07 [PATCH] stk1160: Fix typo s/therwise/Otherwise Ezequiel Garcia
@ 2018-05-18 21:07 ` Ezequiel Garcia
  2018-05-18 21:07 ` [PATCH] m2m-deinterlace: Remove DMA_ENGINE dependency Ezequiel Garcia
  2018-05-18 21:07 ` [PATCH] tw686x: Fix incorrect vb2_mem_ops GFP flags Ezequiel Garcia
  2 siblings, 0 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2018-05-18 21:07 UTC (permalink / raw)
  To: linux-media; +Cc: kernel, Ezequiel Garcia

The mutexes are not being destroyed in the release path. Fix it.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 drivers/media/usb/stk1160/stk1160-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/usb/stk1160/stk1160-core.c b/drivers/media/usb/stk1160/stk1160-core.c
index 881ba0283261..72bd893c9659 100644
--- a/drivers/media/usb/stk1160/stk1160-core.c
+++ b/drivers/media/usb/stk1160/stk1160-core.c
@@ -167,6 +167,8 @@ static void stk1160_release(struct v4l2_device *v4l2_dev)
 
 	v4l2_ctrl_handler_free(&dev->ctrl_handler);
 	v4l2_device_unregister(&dev->v4l2_dev);
+	mutex_destroy(&dev->v4l_lock);
+	mutex_destroy(&dev->vb_queue_lock);
 	kfree(dev->alt_max_pkt_size);
 	kfree(dev);
 }
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] m2m-deinterlace: Remove DMA_ENGINE dependency
  2018-05-18 21:07 [PATCH] stk1160: Fix typo s/therwise/Otherwise Ezequiel Garcia
  2018-05-18 21:07 ` [PATCH] stk1160: Add missing calls to mutex_destroy Ezequiel Garcia
@ 2018-05-18 21:07 ` Ezequiel Garcia
  2018-05-18 21:07 ` [PATCH] tw686x: Fix incorrect vb2_mem_ops GFP flags Ezequiel Garcia
  2 siblings, 0 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2018-05-18 21:07 UTC (permalink / raw)
  To: linux-media; +Cc: kernel, Ezequiel Garcia

The DMA engine subsystem provides stubs for drivers
to build with !DMA_ENGINE. Drop the config dependency.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 drivers/media/platform/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 46a5431cfac7..a8e0f537cfe9 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -249,7 +249,7 @@ config VIDEO_MEDIATEK_VCODEC
 
 config VIDEO_MEM2MEM_DEINTERLACE
 	tristate "Deinterlace support"
-	depends on VIDEO_DEV && VIDEO_V4L2 && DMA_ENGINE
+	depends on VIDEO_DEV && VIDEO_V4L2
 	depends on HAS_DMA
 	select VIDEOBUF2_DMA_CONTIG
 	select V4L2_MEM2MEM_DEV
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] tw686x: Fix incorrect vb2_mem_ops GFP flags
  2018-05-18 21:07 [PATCH] stk1160: Fix typo s/therwise/Otherwise Ezequiel Garcia
  2018-05-18 21:07 ` [PATCH] stk1160: Add missing calls to mutex_destroy Ezequiel Garcia
  2018-05-18 21:07 ` [PATCH] m2m-deinterlace: Remove DMA_ENGINE dependency Ezequiel Garcia
@ 2018-05-18 21:07 ` Ezequiel Garcia
  2 siblings, 0 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2018-05-18 21:07 UTC (permalink / raw)
  To: linux-media; +Cc: kernel, Ezequiel Garcia

When the driver is configured in the "memcpy" dma-mode,
it uses vb2_vmalloc_memops, which is backed by a SLAB
allocator and so shouldn't be using GFP_DMA32.

Fix it.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 drivers/media/pci/tw686x/tw686x-video.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c
index c3fafa97b2d0..0ea8dd44026c 100644
--- a/drivers/media/pci/tw686x/tw686x-video.c
+++ b/drivers/media/pci/tw686x/tw686x-video.c
@@ -1228,7 +1228,8 @@ int tw686x_video_init(struct tw686x_dev *dev)
 		vc->vidq.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
 		vc->vidq.min_buffers_needed = 2;
 		vc->vidq.lock = &vc->vb_mutex;
-		vc->vidq.gfp_flags = GFP_DMA32;
+		vc->vidq.gfp_flags = dev->dma_mode != TW686X_DMA_MODE_MEMCPY ?
+				     GFP_DMA32 : 0;
 		vc->vidq.dev = &dev->pci_dev->dev;
 
 		err = vb2_queue_init(&vc->vidq);
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-18 21:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-18 21:07 [PATCH] stk1160: Fix typo s/therwise/Otherwise Ezequiel Garcia
2018-05-18 21:07 ` [PATCH] stk1160: Add missing calls to mutex_destroy Ezequiel Garcia
2018-05-18 21:07 ` [PATCH] m2m-deinterlace: Remove DMA_ENGINE dependency Ezequiel Garcia
2018-05-18 21:07 ` [PATCH] tw686x: Fix incorrect vb2_mem_ops GFP flags Ezequiel Garcia

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.