All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	linux-xfs@vger.kernel.org, jack@suse.com, jeffm@suse.com,
	okurz@suse.com, lpechacek@suse.com, jtulak@redhat.com
Subject: Re: [PATCH v2 5/5] mkfs.xfs: add configuration file parsing support using our own parser
Date: Fri, 18 May 2018 16:56:10 -0700	[thread overview]
Message-ID: <20180518235610.GF24680@garbanzo.do-not-panic.com> (raw)
In-Reply-To: <c2e7b213-0dad-7609-7984-e4c897d6bb08@sandeen.net>

On Fri, May 18, 2018 at 12:09:23PM -0500, Eric Sandeen wrote:
> On 5/18/18 10:38 AM, Luis R. Rodriguez wrote:
> > On Thu, May 17, 2018 at 08:46:00PM -0700, Darrick J. Wong wrote:
> > > On Thu, May 17, 2018 at 10:24:13PM -0500, Eric Sandeen wrote:
> 
> ...
> > Let us recall that the reason for -c set in stone on /@sysconfigdir@/mkfs.xfs.d/
> > was to allow clean simple code.
> > 
> > The MKFS_XFS_CONFIG is simply a comopromise to allow flexibility on a
> > full path in case you cannot use the /@sysconfigdir@/mkfs.xfs.d/
> > directory.
> > 
> > Supporting both remains simple.
> > 
> > If we wanted to support what you suggest, if a user specified -c hoogah
> > we'd have to treat multiple possibilities in code, increasing complexity:
> > 
> >    a) Did the user mean the hoogah in the present directory?
> >    b) Did the user mean hoogah in /@sysconfigdir@/mkfs.xfs.d/
> > 
> > Granted, if the user specified a -c /tmp/hoogah its clearer that the
> > full path would be desirable. So, I think what you suggest makes sense
> > provided we get rid of a) option and require only an alternative path
> > *iff* the first character in the path is '/'. Does this work for all
> > cases we wish to support a full path in?
> 
> Possibly include "./" as well. i.e.  mkfs.xfs -c ./configdir/myconfig
> 
> so:
> 
> mkfs.xfs -c hoogah		searches /@sysconfigdir@/mkfs.xfs.d/
> mkfs.xfs -c ./hoogah		or
> mkfs.xfs -c /path/to/hoogah	do exactly what you'd expect.
> 
> > > And the -c
> > > option can be specified once to override the environment variable /
> > > builtin detaults?
> 
> I'd like to drop the environment variable altogether.  If there is a strong
> case to be made for keeping it, please make it. :)  (I don't consider the
> existence of MKE2FS_CONFIG to be a strong argument, FWIW, because our
> semantics & mechanisms are quite different.)

Sounds good. I'll drop the environment variable junk and only support
the above 3 cases.

  Luis

  reply	other threads:[~2018-05-18 23:56 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 19:26 [PATCH v2 0/5] xfsprogs: add mkfs.xfs configuration file parsing support Luis R. Rodriguez
2018-05-17 19:26 ` [PATCH v2 1/5] mkfs: distinguish between struct sb_feat_args and struct cli_params Luis R. Rodriguez
2018-05-17 22:02   ` Dave Chinner
2018-05-17 19:26 ` [PATCH v2 2/5] mkfs: move shared structs and cli params into their own headers Luis R. Rodriguez
2018-05-17 22:40   ` Dave Chinner
2018-05-17 23:54     ` Luis R. Rodriguez
2018-05-18  0:49       ` Dave Chinner
2018-05-19  1:33         ` Luis R. Rodriguez
2018-05-17 19:26 ` [PATCH v2 3/5] mkfs: replace defaults source with an enum Luis R. Rodriguez
2018-05-17 22:48   ` Dave Chinner
2018-05-17 23:09     ` Luis R. Rodriguez
2018-05-18  0:53       ` Dave Chinner
2018-05-17 19:26 ` [PATCH v2 4/5] mkfs: add helpers to process defaults Luis R. Rodriguez
2018-05-17 22:53   ` Dave Chinner
2018-05-18  0:06     ` Luis R. Rodriguez
2018-05-17 19:27 ` [PATCH v2 5/5] mkfs.xfs: add configuration file parsing support using our own parser Luis R. Rodriguez
2018-05-17 21:31   ` Darrick J. Wong
2018-05-18  0:29     ` Luis R. Rodriguez
2018-05-21 18:32     ` Luis R. Rodriguez
2018-05-18  0:44   ` Dave Chinner
2018-05-19  1:32     ` Luis R. Rodriguez
2018-05-21  0:14       ` Dave Chinner
2018-05-21 15:30         ` Darrick J. Wong
2018-05-21 16:58         ` Luis R. Rodriguez
2018-05-22 19:37     ` Luis R. Rodriguez
2018-05-18  3:24   ` Eric Sandeen
2018-05-18  3:46     ` Darrick J. Wong
2018-05-18 15:38       ` Luis R. Rodriguez
2018-05-18 17:09         ` Eric Sandeen
2018-05-18 23:56           ` Luis R. Rodriguez [this message]
2018-05-21  9:40             ` Jan Tulak
2018-05-25  0:50               ` Luis R. Rodriguez
2018-05-20  0:16       ` Dave Chinner
2018-05-21 15:33         ` Darrick J. Wong
2018-05-21 17:05           ` Luis R. Rodriguez
2018-05-21 22:10             ` Dave Chinner
2018-05-21 22:24               ` Eric Sandeen
2018-05-22  0:38                 ` Dave Chinner
2018-05-25  0:51                   ` Luis R. Rodriguez
2018-05-25  0:54           ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180518235610.GF24680@garbanzo.do-not-panic.com \
    --to=mcgrof@kernel.org \
    --cc=darrick.wong@oracle.com \
    --cc=jack@suse.com \
    --cc=jeffm@suse.com \
    --cc=jtulak@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=lpechacek@suse.com \
    --cc=okurz@suse.com \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.