Re: [PATCH v2 5/5] mkfs.xfs: add configuration file parsing support using our own parser

["Luis R. Rodriguez" <mcgrof@kernel.org>]

On Tue, May 22, 2018 at 10:38:57AM +1000, Dave Chinner wrote:
> On Mon, May 21, 2018 at 05:24:34PM -0500, Eric Sandeen wrote:
> > On 5/21/18 5:10 PM, Dave Chinner wrote:
> > >On Mon, May 21, 2018 at 10:05:30AM -0700, Luis R. Rodriguez wrote:
> > >>On Mon, May 21, 2018 at 08:33:54AM -0700, Darrick J. Wong wrote:
> > >>>On Sun, May 20, 2018 at 10:16:48AM +1000, Dave Chinner wrote:
> > >>>>On Thu, May 17, 2018 at 08:46:00PM -0700, Darrick J. Wong wrote:
> > >>>>><shrug> Bikeshedding more, what if either option accepted either an
> > >>>>>absolute path, or a file in $sysconfdir/etc/mkfs.xfs.d/ ?
> > >>>>
> > >>>>I kinda assumed that config files could be located anywhere, but we
> > >>>>only searched the sysconfig path if it didn't point at a local
> > >>>>file...
> > >>>
> > >>><shrug> openat() semantics are fine enough with me, I think.
> > >>
> > >>Well this is a big difference, and I think being clear on this would
> > >>be good. If the user specified:
> > >>
> > >>	-c foo
> > >>	
> > >>and the file 'foo' is present but also exists on
> > >>$sysconfdir/etc/mkfs.xfs.d/foo do we use the local file if the user
> > >>did not pass ./foo ?
> > >
> > >I would have expected "foo" to be considered the same as "./foo".
> > >It's a relative path.
> > 
> > Urgh, so now if foo exists in $PWD /and/ in $sysconfdir/etc/mkfs.xfs.d/foo
> > we have to have a hierarchy between the two?  :/
> 
> Of course there is. The user may not know anything about admin
> configured defaults, and they are well within their rights to have
> their own local files that have names that match global admin
> default files.

Chinner's got a point here. If felt silly to not support this so I just
added support for it.

Will spin out a new set as I think I've taken care of all comments now.

  Luis