* [mmotm:master 149/199] lib/idr.c:583:2: error: implicit declaration of function 'xa_lock_irqsave'; did you mean 'read_lock_irqsave'?
@ 2018-05-18 20:21 kbuild test robot
2018-05-18 22:10 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-05-18 20:21 UTC (permalink / raw)
To: Matthew Wilcox
Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List
[-- Attachment #1: Type: text/plain, Size: 5215 bytes --]
tree: git://git.cmpxchg.org/linux-mmotm.git master
head: 7400fc6942aefa2e009272d0e118284f110c5088
commit: d5f90621ff2af7f139b01b7bcf8649a91665965e [149/199] lib/idr.c: remove simple_ida_lock
config: x86_64-randconfig-i0-201819 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
git checkout d5f90621ff2af7f139b01b7bcf8649a91665965e
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the mmotm/master HEAD 7400fc6942aefa2e009272d0e118284f110c5088 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
lib/idr.c: In function 'ida_simple_get':
>> lib/idr.c:583:2: error: implicit declaration of function 'xa_lock_irqsave'; did you mean 'read_lock_irqsave'? [-Werror=implicit-function-declaration]
xa_lock_irqsave(&ida->ida_rt, flags);
^~~~~~~~~~~~~~~
read_lock_irqsave
>> lib/idr.c:593:2: error: implicit declaration of function 'xa_unlock_irqrestore'; did you mean 'read_unlock_irqrestore'? [-Werror=implicit-function-declaration]
xa_unlock_irqrestore(&ida->ida_rt, flags);
^~~~~~~~~~~~~~~~~~~~
read_unlock_irqrestore
Cyclomatic Complexity 5 include/linux/compiler.h:__read_once_size
Cyclomatic Complexity 5 include/linux/compiler.h:__write_once_size
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:__set_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:__clear_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:constant_test_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:variable_test_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:__ffs
Cyclomatic Complexity 1 include/linux/err.h:ERR_PTR
Cyclomatic Complexity 1 include/linux/err.h:PTR_ERR
Cyclomatic Complexity 1 include/linux/radix-tree.h:radix_tree_is_internal_node
Cyclomatic Complexity 1 include/linux/radix-tree.h:iter_shift
Cyclomatic Complexity 1 include/linux/radix-tree.h:radix_tree_iter_init
Cyclomatic Complexity 1 include/linux/radix-tree.h:__radix_tree_iter_add
Cyclomatic Complexity 1 include/linux/radix-tree.h:radix_tree_chunk_size
Cyclomatic Complexity 1 include/linux/radix-tree.h:__radix_tree_next_slot
Cyclomatic Complexity 9 include/linux/radix-tree.h:radix_tree_next_slot
Cyclomatic Complexity 1 include/linux/err.h:IS_ERR
Cyclomatic Complexity 1 include/linux/radix-tree.h:radix_tree_exception
Cyclomatic Complexity 1 include/linux/radix-tree.h:radix_tree_iter_find
Cyclomatic Complexity 1 include/linux/radix-tree.h:radix_tree_iter_lookup
Cyclomatic Complexity 3 include/linux/bitmap.h:bitmap_full
Cyclomatic Complexity 3 include/linux/bitmap.h:bitmap_empty
Cyclomatic Complexity 7 lib/idr.c:idr_alloc_u32
Cyclomatic Complexity 5 lib/idr.c:idr_alloc
Cyclomatic Complexity 6 lib/idr.c:idr_alloc_cyclic
Cyclomatic Complexity 1 lib/idr.c:idr_remove
Cyclomatic Complexity 1 lib/idr.c:idr_find
Cyclomatic Complexity 6 lib/idr.c:idr_for_each
Cyclomatic Complexity 5 lib/idr.c:idr_get_next
Cyclomatic Complexity 3 lib/idr.c:idr_get_next_ul
Cyclomatic Complexity 5 lib/idr.c:idr_replace
Cyclomatic Complexity 18 lib/idr.c:ida_get_new_above
Cyclomatic Complexity 10 lib/idr.c:ida_remove
Cyclomatic Complexity 4 lib/idr.c:ida_destroy
Cyclomatic Complexity 6 lib/idr.c:ida_simple_get
Cyclomatic Complexity 1 lib/idr.c:ida_simple_remove
cc1: some warnings being treated as errors
vim +583 lib/idr.c
546
547 /**
548 * ida_simple_get - get a new id.
549 * @ida: the (initialized) ida.
550 * @start: the minimum id (inclusive, < 0x8000000)
551 * @end: the maximum id (exclusive, < 0x8000000 or 0)
552 * @gfp_mask: memory allocation flags
553 *
554 * Allocates an id in the range start <= id < end, or returns -ENOSPC.
555 * On memory allocation failure, returns -ENOMEM.
556 *
557 * Compared to ida_get_new_above() this function does its own locking, and
558 * should be used unless there are special requirements.
559 *
560 * Use ida_simple_remove() to get rid of an id.
561 */
562 int ida_simple_get(struct ida *ida, unsigned int start, unsigned int end,
563 gfp_t gfp_mask)
564 {
565 int ret, id;
566 unsigned int max;
567 unsigned long flags;
568
569 BUG_ON((int)start < 0);
570 BUG_ON((int)end < 0);
571
572 if (end == 0)
573 max = 0x80000000;
574 else {
575 BUG_ON(end < start);
576 max = end - 1;
577 }
578
579 again:
580 if (!ida_pre_get(ida, gfp_mask))
581 return -ENOMEM;
582
> 583 xa_lock_irqsave(&ida->ida_rt, flags);
584 ret = ida_get_new_above(ida, start, &id);
585 if (!ret) {
586 if (id > max) {
587 ida_remove(ida, id);
588 ret = -ENOSPC;
589 } else {
590 ret = id;
591 }
592 }
> 593 xa_unlock_irqrestore(&ida->ida_rt, flags);
594
595 if (unlikely(ret == -EAGAIN))
596 goto again;
597
598 return ret;
599 }
600 EXPORT_SYMBOL(ida_simple_get);
601
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27289 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [mmotm:master 149/199] lib/idr.c:583:2: error: implicit declaration of function 'xa_lock_irqsave'; did you mean 'read_lock_irqsave'?
2018-05-18 20:21 [mmotm:master 149/199] lib/idr.c:583:2: error: implicit declaration of function 'xa_lock_irqsave'; did you mean 'read_lock_irqsave'? kbuild test robot
@ 2018-05-18 22:10 ` Andrew Morton
2018-05-19 14:31 ` Fengguang Wu
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2018-05-18 22:10 UTC (permalink / raw)
To: kbuild test robot
Cc: Matthew Wilcox, kbuild-all, Johannes Weiner,
Linux Memory Management List
On Sat, 19 May 2018 04:21:17 +0800 kbuild test robot <lkp@intel.com> wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: 7400fc6942aefa2e009272d0e118284f110c5088
> commit: d5f90621ff2af7f139b01b7bcf8649a91665965e [149/199] lib/idr.c: remove simple_ida_lock
> config: x86_64-randconfig-i0-201819 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
> git checkout d5f90621ff2af7f139b01b7bcf8649a91665965e
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> Note: the mmotm/master HEAD 7400fc6942aefa2e009272d0e118284f110c5088 builds fine.
> It only hurts bisectibility.
>
I'm a bit surprised we're seeing this.
ida-remove-simple_ida_lock.patch introduces this error, and the very
next patch ida-remove-simple_ida_lock-fix.patch fixes it.
I'm pretty sure that the robot software is capable of detecting this
situation and ignoring the error. Did that code get broken?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [mmotm:master 149/199] lib/idr.c:583:2: error: implicit declaration of function 'xa_lock_irqsave'; did you mean 'read_lock_irqsave'?
2018-05-18 22:10 ` Andrew Morton
@ 2018-05-19 14:31 ` Fengguang Wu
2018-05-21 0:48 ` [kbuild-all] " Li, Philip
0 siblings, 1 reply; 4+ messages in thread
From: Fengguang Wu @ 2018-05-19 14:31 UTC (permalink / raw)
To: Andrew Morton
Cc: kbuild test robot, Matthew Wilcox, kbuild-all, Johannes Weiner,
Linux Memory Management List, Hao, Shun
Hi Andrew,
On Fri, May 18, 2018 at 03:10:00PM -0700, Andrew Morton wrote:
>On Sat, 19 May 2018 04:21:17 +0800 kbuild test robot <lkp@intel.com> wrote:
>
>> tree: git://git.cmpxchg.org/linux-mmotm.git master
>> head: 7400fc6942aefa2e009272d0e118284f110c5088
>> commit: d5f90621ff2af7f139b01b7bcf8649a91665965e [149/199] lib/idr.c: remove simple_ida_lock
>> config: x86_64-randconfig-i0-201819 (attached as .config)
>> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
>> reproduce:
>> git checkout d5f90621ff2af7f139b01b7bcf8649a91665965e
>> # save the attached .config to linux build tree
>> make ARCH=x86_64
>>
>> Note: the mmotm/master HEAD 7400fc6942aefa2e009272d0e118284f110c5088 builds fine.
>> It only hurts bisectibility.
>>
>
>I'm a bit surprised we're seeing this.
>ida-remove-simple_ida_lock.patch introduces this error, and the very
>next patch ida-remove-simple_ida_lock-fix.patch fixes it.
>
>I'm pretty sure that the robot software is capable of detecting this
>situation and ignoring the error. Did that code get broken?
Yes sorry, the robot code looks not reliable when testing the follow
up -fix patches. The check is done when first seeing the error instead
of before sending out the final report. In the 2 cases, the next patch
of the error commit could be subtly different.
Shun Hao: to be 100% reliable, we'll also need to check the follow up
-fix patches just before sending out the report.
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [kbuild-all] [mmotm:master 149/199] lib/idr.c:583:2: error: implicit declaration of function 'xa_lock_irqsave'; did you mean 'read_lock_irqsave'?
2018-05-19 14:31 ` Fengguang Wu
@ 2018-05-21 0:48 ` Li, Philip
0 siblings, 0 replies; 4+ messages in thread
From: Li, Philip @ 2018-05-21 0:48 UTC (permalink / raw)
To: Wu, Fengguang, Andrew Morton
Cc: lkp, Matthew Wilcox, Linux Memory Management List, kbuild-all,
Johannes Weiner
> Subject: Re: [kbuild-all] [mmotm:master 149/199] lib/idr.c:583:2: error: implicit
> declaration of function 'xa_lock_irqsave'; did you mean 'read_lock_irqsave'?
>
> Hi Andrew,
>
> On Fri, May 18, 2018 at 03:10:00PM -0700, Andrew Morton wrote:
> >On Sat, 19 May 2018 04:21:17 +0800 kbuild test robot <lkp@intel.com> wrote:
> >
> >> tree: git://git.cmpxchg.org/linux-mmotm.git master
> >> head: 7400fc6942aefa2e009272d0e118284f110c5088
> >> commit: d5f90621ff2af7f139b01b7bcf8649a91665965e [149/199] lib/idr.c:
> remove simple_ida_lock
> >> config: x86_64-randconfig-i0-201819 (attached as .config)
> >> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> >> reproduce:
> >> git checkout d5f90621ff2af7f139b01b7bcf8649a91665965e
> >> # save the attached .config to linux build tree
> >> make ARCH=x86_64
> >>
> >> Note: the mmotm/master HEAD 7400fc6942aefa2e009272d0e118284f110c5088
> builds fine.
> >> It only hurts bisectibility.
> >>
> >
> >I'm a bit surprised we're seeing this.
> >ida-remove-simple_ida_lock.patch introduces this error, and the very
> >next patch ida-remove-simple_ida_lock-fix.patch fixes it.
> >
> >I'm pretty sure that the robot software is capable of detecting this
> >situation and ignoring the error. Did that code get broken?
>
> Yes sorry, the robot code looks not reliable when testing the follow
> up -fix patches. The check is done when first seeing the error instead
> of before sending out the final report. In the 2 cases, the next patch
> of the error commit could be subtly different.
>
> Shun Hao: to be 100% reliable, we'll also need to check the follow up
> -fix patches just before sending out the report.
thanks, we will follow up this to consider this situation.
>
> Thanks,
> Fengguang
> _______________________________________________
> kbuild-all mailing list
> kbuild-all@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-21 0:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-18 20:21 [mmotm:master 149/199] lib/idr.c:583:2: error: implicit declaration of function 'xa_lock_irqsave'; did you mean 'read_lock_irqsave'? kbuild test robot
2018-05-18 22:10 ` Andrew Morton
2018-05-19 14:31 ` Fengguang Wu
2018-05-21 0:48 ` [kbuild-all] " Li, Philip
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.