All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Guido Kiener <guido@kiener-muenchen.de>,
	USB <linux-usb@vger.kernel.org>,
	guido.kiener@rohde-schwarz.com, pankaj.adhikari@ni.com,
	steve_bayless@keysight.com, Dave Penkler <dpenkler@gmail.com>
Subject: [03/12] usb: usbtmc: Add ioctls to set/get usb timeout
Date: Sat, 19 May 2018 09:05:25 +0200	[thread overview]
Message-ID: <20180519070525.GB2943@kroah.com> (raw)

On Fri, May 18, 2018 at 10:48:30PM +0300, Andy Shevchenko wrote:
> On Thu, May 17, 2018 at 8:03 PM, Guido Kiener <guido@kiener-muenchen.de> wrote:
> > Add ioctls USBTMC_IOCTL_GET_TIMEOUT / USBTMC_IOCTL_SET_TIMEOUT to
> > get/set I/O timeout for specific file handle.
> 
> 
> 
> 
> > +static int usbtmc_ioctl_get_timeout(struct usbtmc_file_data *file_data,
> > +                               void __user *arg)
> > +{
> > +       __u32 timeout;
> > +
> > +       timeout = file_data->timeout;
> 
> Why do you need __u32 on kernel side?
> Would plain u32 work?

Yes, on the kernel side that is the correct type to use after you copy
it over from userspace.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-05-19  7:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-19  7:05 Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-18 22:19 [03/12] usb: usbtmc: Add ioctls to set/get usb timeout Guido Kiener
2018-05-18 19:48 Andy Shevchenko
2018-05-18 14:56 Guido Kiener
2018-05-18 13:20 Greg Kroah-Hartman
2018-05-17 17:03 Guido Kiener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180519070525.GB2943@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=dpenkler@gmail.com \
    --cc=guido.kiener@rohde-schwarz.com \
    --cc=guido@kiener-muenchen.de \
    --cc=linux-usb@vger.kernel.org \
    --cc=pankaj.adhikari@ni.com \
    --cc=steve_bayless@keysight.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.