[03/12] usb: usbtmc: Add ioctls to set/get usb timeout

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Guido Kiener <guido@kiener-muenchen.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	USB <linux-usb@vger.kernel.org>,
	guido.kiener@rohde-schwarz.com, pankaj.adhikari@ni.com,
	steve_bayless@keysight.com, Dave Penkler <dpenkler@gmail.com>
Subject: [03/12] usb: usbtmc: Add ioctls to set/get usb timeout
Date: Fri, 18 May 2018 22:48:30 +0300	[thread overview]
Message-ID: <CAHp75VdFx--P98F45y0S9mCUkFe9bg0H_bJ_=m15x5VDO5RSLQ@mail.gmail.com> (raw)

On Thu, May 17, 2018 at 8:03 PM, Guido Kiener <guido@kiener-muenchen.de> wrote:
> Add ioctls USBTMC_IOCTL_GET_TIMEOUT / USBTMC_IOCTL_SET_TIMEOUT to
> get/set I/O timeout for specific file handle.

> +static int usbtmc_ioctl_get_timeout(struct usbtmc_file_data *file_data,
> +                               void __user *arg)
> +{
> +       __u32 timeout;
> +
> +       timeout = file_data->timeout;

Why do you need __u32 on kernel side?
Would plain u32 work?

> +
> +       return put_user(timeout, (__u32 __user *)arg);
> +}

> +static int usbtmc_ioctl_set_timeout(struct usbtmc_file_data *file_data,
> +                               void __user *arg)
> +{
> +       __u32 timeout;

Ditto.

> +       return 0;
> +}