[meta-gnome][PATCH 1/6] network-manager-applet: Package gir-1.0 files into devel package

[meta-gnome][PATCH 1/6] network-manager-applet: Package gir-1.0 files into devel package

[Khem Raj]

Fixes QA errors e.g.

ERROR: network-manager-applet-1.8.10-r0 do_package: QA Issue: network-manager-applet: Files/directories were installed but not shipped in any package:
  /usr/share/gir-1.0

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../network-manager-applet/network-manager-applet_1.8.10.bb   | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
index dc2b964be5..ccfe38d010 100644
--- a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
+++ b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
@@ -43,3 +43,7 @@ FILES_${PN} += " \
     ${datadir}/libnm-gtk/wifi.ui \
     ${datadir}/libnma/wifi.ui \
 "
+
+FILES_${PN}-dev += " \
+    ${datadir}/gir-1.0 \
+"
-- 
2.17.0

[meta-oe][PATCH 2/6] xf86-video-nouveau: Remove obsolete deps

[Khem Raj]

All protos are now in xorgproto

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../recipes-graphics/xorg-driver/xf86-video-nouveau_1.0.15.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-graphics/xorg-driver/xf86-video-nouveau_1.0.15.bb b/meta-oe/recipes-graphics/xorg-driver/xf86-video-nouveau_1.0.15.bb
index 2746821cd2..2b1b87c4d0 100644
--- a/meta-oe/recipes-graphics/xorg-driver/xf86-video-nouveau_1.0.15.bb
+++ b/meta-oe/recipes-graphics/xorg-driver/xf86-video-nouveau_1.0.15.bb
@@ -6,8 +6,8 @@ SUMMARY = "X.Org X server -- nouveau video driver"
 
 DESCRIPTION = "Open-source X.org graphics driver for NVIDIA graphics"
 
-DEPENDS += "virtual/libx11 libxvmc drm xf86driproto glproto \
-            virtual/libgl xineramaproto libpciaccess"
+DEPENDS += "virtual/libx11 libxvmc drm xorgproto \
+            virtual/libgl libpciaccess"
 RDEPENDS_${PN} += "xserver-xorg-module-exa"
 
 inherit distro_features_check
-- 
2.17.0

[meta-oe][PATCH 3/6] poppler: Fix build on musl

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../poppler/poppler/basename-include.patch    | 20 +++++++++++++++++++
 .../recipes-support/poppler/poppler_0.64.0.bb |  1 +
 2 files changed, 21 insertions(+)
 create mode 100644 meta-oe/recipes-support/poppler/poppler/basename-include.patch

diff --git a/meta-oe/recipes-support/poppler/poppler/basename-include.patch b/meta-oe/recipes-support/poppler/poppler/basename-include.patch
new file mode 100644
index 0000000000..528528ae7c
--- /dev/null
+++ b/meta-oe/recipes-support/poppler/poppler/basename-include.patch
@@ -0,0 +1,20 @@
+Minic GNU basename() API for non-glibc library e.g. musl
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+Index: poppler-0.64.0/utils/pdfsig.cc
+===================================================================
+--- poppler-0.64.0.orig/utils/pdfsig.cc
++++ poppler-0.64.0/utils/pdfsig.cc
+@@ -35,6 +35,10 @@
+ #include "Win32Console.h"
+ #include "numberofcharacters.h"
+ 
++#if !defined(__GLIBC__)
++#define basename(src) (strrchr(src,'/') ? strrchr(src,'/')+1 : src)
++#endif
++
+ static const char * getReadableSigState(SignatureValidationStatus sig_vs)
+ {
+   switch(sig_vs) {
diff --git a/meta-oe/recipes-support/poppler/poppler_0.64.0.bb b/meta-oe/recipes-support/poppler/poppler_0.64.0.bb
index 1e87ae6e6c..b90f3fa359 100644
--- a/meta-oe/recipes-support/poppler/poppler_0.64.0.bb
+++ b/meta-oe/recipes-support/poppler/poppler_0.64.0.bb
@@ -6,6 +6,7 @@ SRC_URI = "http://poppler.freedesktop.org/${BP}.tar.xz \
            file://0001-Do-not-overwrite-all-our-build-flags.patch \
            file://0002-CairoOutputDev.cc-fix-build-error-when-using-fixedpo.patch \
            file://0001-glib-CMakeLists.txt-Add-libpoppler-to-link-along-wit.patch \
+           file://basename-include.patch \
            "
 SRC_URI[md5sum] = "f7f687ebb60004f8ad61994575018044"
 SRC_URI[sha256sum] = "b21df92ca99f78067785cf2dc8e06deb04726b62389c0ee1f5d8b103c77f64b1"
-- 
2.17.0

[meta-oe][PATCH 4/6] gtkmathview: Fix build with clang

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 ...formatting-for-modern-c-11-compilers.patch | 31 +++++++++++++++++++
 .../mml-widget/gtkmathview_0.8.0.bb           |  1 +
 2 files changed, 32 insertions(+)
 create mode 100644 meta-oe/recipes-extended/mml-widget/gtkmathview/0001-Fix-formatting-for-modern-c-11-compilers.patch

diff --git a/meta-oe/recipes-extended/mml-widget/gtkmathview/0001-Fix-formatting-for-modern-c-11-compilers.patch b/meta-oe/recipes-extended/mml-widget/gtkmathview/0001-Fix-formatting-for-modern-c-11-compilers.patch
new file mode 100644
index 0000000000..8b0096630d
--- /dev/null
+++ b/meta-oe/recipes-extended/mml-widget/gtkmathview/0001-Fix-formatting-for-modern-c-11-compilers.patch
@@ -0,0 +1,31 @@
+From 90411a7f5e0e9582e79f0a8ccc1e2f158615e451 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Sat, 19 May 2018 23:18:11 -0700
+Subject: [PATCH] Fix formatting for modern c++11 compilers
+
+Fixes
+error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ src/backend/svg/SVG_RenderingContext.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/backend/svg/SVG_RenderingContext.cc b/src/backend/svg/SVG_RenderingContext.cc
+index 55d6097..0d50702 100644
+--- a/src/backend/svg/SVG_RenderingContext.cc
++++ b/src/backend/svg/SVG_RenderingContext.cc
+@@ -68,7 +68,7 @@ void
+ SVG_RenderingContext::documentStart(const BoundingBox& bbox)
+ {
+   beginDocument(bbox);
+-  metadata("Created by "PACKAGE" version "VERSION);
++  metadata("Created by " PACKAGE " version " VERSION);
+ }
+ 
+ void
+-- 
+2.17.0
+
diff --git a/meta-oe/recipes-extended/mml-widget/gtkmathview_0.8.0.bb b/meta-oe/recipes-extended/mml-widget/gtkmathview_0.8.0.bb
index df82bef634..9ee9e30352 100644
--- a/meta-oe/recipes-extended/mml-widget/gtkmathview_0.8.0.bb
+++ b/meta-oe/recipes-extended/mml-widget/gtkmathview_0.8.0.bb
@@ -13,6 +13,7 @@ SRC_URI = "git://github.com/GNOME/gtkmathview.git \
     file://0001-include-cstdio-to-get-printf-definitions.patch \
     file://0002-configure.ac-header-detection-of-hash_map-is-broken-.patch \
     file://0003-gcc-6.0-build-fixes.patch \
+    file://0001-Fix-formatting-for-modern-c-11-compilers.patch \
 "
 
 S = "${WORKDIR}/git"
-- 
2.17.0

[meta-oe][PATCH 5/6] nano: Upgrade 2.9.3 -> 2.9.7

[Khem Raj]

Fix build with musl

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-support/nano/nano_2.9.3.bb | 4 ----
 meta-oe/recipes-support/nano/nano_2.9.7.bb | 8 ++++++++
 2 files changed, 8 insertions(+), 4 deletions(-)
 delete mode 100644 meta-oe/recipes-support/nano/nano_2.9.3.bb
 create mode 100644 meta-oe/recipes-support/nano/nano_2.9.7.bb

diff --git a/meta-oe/recipes-support/nano/nano_2.9.3.bb b/meta-oe/recipes-support/nano/nano_2.9.3.bb
deleted file mode 100644
index afb0cf2e73..0000000000
--- a/meta-oe/recipes-support/nano/nano_2.9.3.bb
+++ /dev/null
@@ -1,4 +0,0 @@
-include nano.inc
-
-SRC_URI[md5sum] = "6dd37f010d6a985bf0e5f8ed091ff919"
-SRC_URI[sha256sum] = "7783bcfd4b2d5dc0bf64d4bd07b1a19e7ba3c91da881a4249772a36b972d4012"
diff --git a/meta-oe/recipes-support/nano/nano_2.9.7.bb b/meta-oe/recipes-support/nano/nano_2.9.7.bb
new file mode 100644
index 0000000000..419e5406ba
--- /dev/null
+++ b/meta-oe/recipes-support/nano/nano_2.9.7.bb
@@ -0,0 +1,8 @@
+include nano.inc
+
+do_install_append_libc-musl () {
+	rm -rf ${D}${libdir}/charset.alias
+	rmdir ${D}${libdir}
+}
+SRC_URI[md5sum] = "e0c6d76c93932f6c41c40842952495f7"
+SRC_URI[sha256sum] = "b64ab017305b1777e97b5b9b07b31db8aeebfc3e8719f61e8da1cf3866d344bd"
-- 
2.17.0

[meta-oe][PATCH 6/6] mariadb: Upgrade to 5.5.60

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../{mariadb-native_5.5.59.bb => mariadb-native_5.5.60.bb}   | 0
 meta-oe/recipes-dbs/mysql/mariadb.inc                        | 5 ++---
 .../mysql/{mariadb_5.5.59.bb => mariadb_5.5.60.bb}           | 0
 3 files changed, 2 insertions(+), 3 deletions(-)
 rename meta-oe/recipes-dbs/mysql/{mariadb-native_5.5.59.bb => mariadb-native_5.5.60.bb} (100%)
 rename meta-oe/recipes-dbs/mysql/{mariadb_5.5.59.bb => mariadb_5.5.60.bb} (100%)

diff --git a/meta-oe/recipes-dbs/mysql/mariadb-native_5.5.59.bb b/meta-oe/recipes-dbs/mysql/mariadb-native_5.5.60.bb
similarity index 100%
rename from meta-oe/recipes-dbs/mysql/mariadb-native_5.5.59.bb
rename to meta-oe/recipes-dbs/mysql/mariadb-native_5.5.60.bb
diff --git a/meta-oe/recipes-dbs/mysql/mariadb.inc b/meta-oe/recipes-dbs/mysql/mariadb.inc
index 99e7050945..8e0e252421 100644
--- a/meta-oe/recipes-dbs/mysql/mariadb.inc
+++ b/meta-oe/recipes-dbs/mysql/mariadb.inc
@@ -18,9 +18,8 @@ SRC_URI = "https://downloads.mariadb.org/f/${BP}/source/${BP}.tar.gz \
            file://change-cc-to-cc-version.patch \
            file://0001-disable-ucontext-on-musl.patch \
           "
-
-SRC_URI[md5sum] = "3cec4afc06b468687ef576c90148d10d"
-SRC_URI[sha256sum] = "c3269ce20b45b177239fd1e3d6d9428a94131711f12758ebf5f65222278bb110"
+SRC_URI[md5sum] = "afbadcf2980ad5aa205084dd401f1b7f"
+SRC_URI[sha256sum] = "4d3d444555416028ce39d3fb4cdc9cf6a658fcd4b0d2d0c45a73f9bf01d07929"
 
 S = "${WORKDIR}/mariadb-${PV}"
 
diff --git a/meta-oe/recipes-dbs/mysql/mariadb_5.5.59.bb b/meta-oe/recipes-dbs/mysql/mariadb_5.5.60.bb
similarity index 100%
rename from meta-oe/recipes-dbs/mysql/mariadb_5.5.59.bb
rename to meta-oe/recipes-dbs/mysql/mariadb_5.5.60.bb
-- 
2.17.0

Re: [meta-gnome][PATCH 1/6] network-manager-applet: Package gir-1.0 files into devel package

[Andreas Müller]

On Mon, May 21, 2018 at 12:35 AM, Khem Raj <raj.khem@gmail.com> wrote:
> Fixes QA errors e.g.
>
> ERROR: network-manager-applet-1.8.10-r0 do_package: QA Issue: network-manager-applet: Files/directories were installed but not shipped in any package:
>   /usr/share/gir-1.0
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  .../network-manager-applet/network-manager-applet_1.8.10.bb   | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
> index dc2b964be5..ccfe38d010 100644
> --- a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
> +++ b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
> @@ -43,3 +43,7 @@ FILES_${PN} += " \
>      ${datadir}/libnm-gtk/wifi.ui \
>      ${datadir}/libnma/wifi.ui \
>  "
> +
> +FILES_${PN}-dev += " \
> +    ${datadir}/gir-1.0 \
> +"
> --
> 2.17.0
>
On sumo I do not see this QA error and gir-files are packed properly
to network-manager-applet-dev.

Sure that this is a correct fix? What changed in oe-core?

Andreas

Re: [meta-gnome][PATCH 1/6] network-manager-applet: Package gir-1.0 files into devel package

[Khem Raj]

On Sun, May 20, 2018 at 3:46 PM, Andreas Müller <schnitzeltony@gmail.com> wrote:
> On Mon, May 21, 2018 at 12:35 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> Fixes QA errors e.g.
>>
>> ERROR: network-manager-applet-1.8.10-r0 do_package: QA Issue: network-manager-applet: Files/directories were installed but not shipped in any package:
>>   /usr/share/gir-1.0
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  .../network-manager-applet/network-manager-applet_1.8.10.bb   | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>> index dc2b964be5..ccfe38d010 100644
>> --- a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>> +++ b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>> @@ -43,3 +43,7 @@ FILES_${PN} += " \
>>      ${datadir}/libnm-gtk/wifi.ui \
>>      ${datadir}/libnma/wifi.ui \
>>  "
>> +
>> +FILES_${PN}-dev += " \
>> +    ${datadir}/gir-1.0 \
>> +"
>> --
>> 2.17.0
>>
> On sumo I do not see this QA error and gir-files are packed properly
> to network-manager-applet-dev.
>
> Sure that this is a correct fix? What changed in oe-core?
>

This is seen with musl builds. In anycase gir files if any should go
into -dev pkgs.

> Andreas

Re: [meta-gnome][PATCH 1/6] network-manager-applet: Package gir-1.0 files into devel package

[Andreas Müller]

On Mon, May 21, 2018 at 12:47 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Sun, May 20, 2018 at 3:46 PM, Andreas Müller <schnitzeltony@gmail.com> wrote:
>> On Mon, May 21, 2018 at 12:35 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>> Fixes QA errors e.g.
>>>
>>> ERROR: network-manager-applet-1.8.10-r0 do_package: QA Issue: network-manager-applet: Files/directories were installed but not shipped in any package:
>>>   /usr/share/gir-1.0
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>>  .../network-manager-applet/network-manager-applet_1.8.10.bb   | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>>> index dc2b964be5..ccfe38d010 100644
>>> --- a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>>> +++ b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>>> @@ -43,3 +43,7 @@ FILES_${PN} += " \
>>>      ${datadir}/libnm-gtk/wifi.ui \
>>>      ${datadir}/libnma/wifi.ui \
>>>  "
>>> +
>>> +FILES_${PN}-dev += " \
>>> +    ${datadir}/gir-1.0 \
>>> +"
>>> --
>>> 2.17.0
>>>
>> On sumo I do not see this QA error and gir-files are packed properly
>> to network-manager-applet-dev.
>>
>> Sure that this is a correct fix? What changed in oe-core?
>>
>
> This is seen with musl builds. In anycase gir files if any should go
> into -dev pkgs.
>
Ahh musl / gir...

So how about dropping a note near FILES_${PN}-dev - otherwise chances
are high it gets removed sooner or later. For non musl this is not
necessary and at least I will not remember during next release
panic...

Andreas