[Intel-wired-lan] [jkirsher-next-queue:dev-queue 25/25] drivers/infiniband/hw/i40iw/i40iw_main.c:110:6: sparse: symbol 'i40iw_open_inc_ref' was not declared. Should it be static?

[Intel-wired-lan] [jkirsher-next-queue:dev-queue 25/25] drivers/infiniband/hw/i40iw/i40iw_main.c:110:6: sparse: symbol 'i40iw_open_inc_ref' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
head:   34a1361d548da593a1bf5937f386f60b07874d6b
commit: 34a1361d548da593a1bf5937f386f60b07874d6b [25/25] i40iw/i40e: Remove link dependency on i40e
reproduce:
        # apt-get install sparse
        git checkout 34a1361d548da593a1bf5937f386f60b07874d6b
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/infiniband/hw/i40iw/i40iw_main.c:110:6: sparse: symbol 'i40iw_open_inc_ref' was not declared. Should it be static?
>> drivers/infiniband/hw/i40iw/i40iw_main.c:118:6: sparse: symbol 'i40iw_open_dec_ref' was not declared. Should it be static?
   drivers/infiniband/hw/i40iw/i40iw_main.c:819:20: sparse: expression using sizeof(void)
   drivers/infiniband/hw/i40iw/i40iw_main.c:819:20: sparse: expression using sizeof(void)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[Intel-wired-lan] [RFC PATCH jkirsher-next-queue] i40iw/i40e: i40iw_open_inc_ref() can be static

[kbuild test robot]

Fixes: 34a1361d548d ("i40iw/i40e: Remove link dependency on i40e")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 i40iw_main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c
index 65e1269..f4c5be1 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_main.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_main.c
@@ -107,7 +107,7 @@ static struct notifier_block i40iw_netdevice_notifier = {
 /**
  * i40iw_open_inc_ref - Increment ref count for a open
  */
-void i40iw_open_inc_ref(void)
+static void i40iw_open_inc_ref(void)
 {
 	atomic_inc(&peer_drv.peer.ref_count);
 }
@@ -115,7 +115,7 @@ void i40iw_open_inc_ref(void)
 /**
  * i40iw_open_dec_ref - Decrement ref count for a open
  */
-void i40iw_open_dec_ref(void)
+static void i40iw_open_dec_ref(void)
 {
 	struct i40iw_peer *peer;
 

[Intel-wired-lan] [RFC PATCH jkirsher-next-queue] i40iw/i40e: i40iw_open_inc_ref() can be static

[Devale, Sindhu]

ACK.

Thank you,
Sindhu





Fixes: 34a1361d548d ("i40iw/i40e: Remove link dependency on i40e")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 i40iw_main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c
index 65e1269..f4c5be1 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_main.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_main.c
@@ -107,7 +107,7 @@ static struct notifier_block i40iw_netdevice_notifier = {
 /**
  * i40iw_open_inc_ref - Increment ref count for a open
  */
-void i40iw_open_inc_ref(void)
+static void i40iw_open_inc_ref(void)
 {
 	atomic_inc(&peer_drv.peer.ref_count);
 }
@@ -115,7 +115,7 @@ void i40iw_open_inc_ref(void)
 /**
  * i40iw_open_dec_ref - Decrement ref count for a open
  */
-void i40iw_open_dec_ref(void)
+static void i40iw_open_dec_ref(void)
 {
 	struct i40iw_peer *peer;