From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Steven Rostedt <rostedt@goodmis.org> Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RT] arm64: fpsimd: use a local_lock() in addition to local_bh_disable() Date: Tue, 22 May 2018 19:33:33 +0200 [thread overview] Message-ID: <20180522173333.aawadhkcekzvrswp@linutronix.de> (raw) In-Reply-To: <20180522132429.6f1dcf92@gandalf.local.home> On 2018-05-22 13:24:29 [-0400], Steven Rostedt wrote: > On Tue, 22 May 2018 19:21:16 +0200 > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > > On 2018-05-22 13:10:04 [-0400], Steven Rostedt wrote: > > > On Thu, 17 May 2018 14:40:06 +0200 > > > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > > > > > > +static DEFINE_LOCAL_IRQ_LOCK(fpsimd_lock); > > > > /* > > > > * Update current's FPSIMD/SVE registers from thread_struct. > > > > * > > > > @@ -594,6 +595,7 @@ int sve_set_vector_length(struct task_struct *task, > > > > * non-SVE thread. > > > > */ > > > > if (task == current) { > > > > + local_lock(fpsimd_lock); > > > > local_bh_disable(); > > > > > > I'm surprised that we don't have a "local_lock_bh()"? > > > > right. Like the last time when we introduced a global lock with no > > locking context? > > > > I meant, we could have local_lock_bh(fpsimd_lock); that would turn into > a local_bh_disable() when !PREEMPT_RT. Oh that part. That could be possible I guess. I need to look into the second part which disables preemption while the FPU is taken. > -- Steve Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RT] arm64: fpsimd: use a local_lock() in addition to local_bh_disable() Date: Tue, 22 May 2018 19:33:33 +0200 [thread overview] Message-ID: <20180522173333.aawadhkcekzvrswp@linutronix.de> (raw) In-Reply-To: <20180522132429.6f1dcf92@gandalf.local.home> On 2018-05-22 13:24:29 [-0400], Steven Rostedt wrote: > On Tue, 22 May 2018 19:21:16 +0200 > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > > On 2018-05-22 13:10:04 [-0400], Steven Rostedt wrote: > > > On Thu, 17 May 2018 14:40:06 +0200 > > > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > > > > > > +static DEFINE_LOCAL_IRQ_LOCK(fpsimd_lock); > > > > /* > > > > * Update current's FPSIMD/SVE registers from thread_struct. > > > > * > > > > @@ -594,6 +595,7 @@ int sve_set_vector_length(struct task_struct *task, > > > > * non-SVE thread. > > > > */ > > > > if (task == current) { > > > > + local_lock(fpsimd_lock); > > > > local_bh_disable(); > > > > > > I'm surprised that we don't have a "local_lock_bh()"? > > > > right. Like the last time when we introduced a global lock with no > > locking context? > > > > I meant, we could have local_lock_bh(fpsimd_lock); that would turn into > a local_bh_disable() when !PREEMPT_RT. Oh that part. That could be possible I guess. I need to look into the second part which disables preemption while the FPU is taken. > -- Steve Sebastian
next prev parent reply other threads:[~2018-05-22 17:33 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-17 12:40 [PATCH RT] arm64: fpsimd: use a local_lock() in addition to local_bh_disable() Sebastian Andrzej Siewior 2018-05-17 12:40 ` Sebastian Andrzej Siewior 2018-05-17 18:19 ` Dave Martin 2018-05-17 18:19 ` Dave Martin 2018-05-18 12:46 ` Dave Martin 2018-05-18 12:46 ` Dave Martin 2018-05-23 14:34 ` Sebastian Andrzej Siewior 2018-05-23 14:34 ` Sebastian Andrzej Siewior 2018-05-23 14:31 ` Sebastian Andrzej Siewior 2018-05-23 14:31 ` Sebastian Andrzej Siewior 2018-05-23 14:55 ` Dave Martin 2018-05-23 14:55 ` Dave Martin 2018-05-22 17:10 ` Steven Rostedt 2018-05-22 17:10 ` Steven Rostedt 2018-05-22 17:21 ` Sebastian Andrzej Siewior 2018-05-22 17:21 ` Sebastian Andrzej Siewior 2018-05-22 17:24 ` Steven Rostedt 2018-05-22 17:24 ` Steven Rostedt 2018-05-22 17:33 ` Sebastian Andrzej Siewior [this message] 2018-05-22 17:33 ` Sebastian Andrzej Siewior 2018-07-11 13:25 ` Steven Rostedt 2018-07-11 13:25 ` Steven Rostedt 2018-07-11 13:31 ` Sebastian Andrzej Siewior 2018-07-11 13:31 ` Sebastian Andrzej Siewior 2018-07-11 13:33 ` Steven Rostedt 2018-07-11 13:33 ` Steven Rostedt 2018-07-13 17:49 ` [PATCH RT v2] " Sebastian Andrzej Siewior 2018-07-13 17:49 ` Sebastian Andrzej Siewior 2018-07-13 17:50 ` [PATCH RT] locallock: add local_lock_bh() Sebastian Andrzej Siewior 2018-07-13 17:50 ` Sebastian Andrzej Siewior 2018-07-13 22:03 ` [PATCH RT v2] arm64: fpsimd: use a local_lock() in addition to local_bh_disable() Mike Galbraith 2018-07-13 22:03 ` Mike Galbraith 2018-07-15 7:22 ` Mike Galbraith 2018-07-15 7:22 ` Mike Galbraith 2018-07-15 7:22 ` Mike Galbraith 2018-07-18 10:30 ` Mike Galbraith 2018-07-18 10:30 ` Mike Galbraith 2018-07-18 10:30 ` Mike Galbraith 2018-07-18 9:27 ` Sebastian Andrzej Siewior 2018-07-18 9:27 ` Sebastian Andrzej Siewior 2018-07-18 10:28 ` Mike Galbraith 2018-07-18 10:28 ` Mike Galbraith 2018-07-18 10:28 ` Mike Galbraith 2018-07-18 10:36 ` Sebastian Andrzej Siewior 2018-07-18 10:36 ` Sebastian Andrzej Siewior 2018-07-16 15:17 ` Dave Martin 2018-07-16 15:17 ` Dave Martin 2018-07-18 9:12 ` Sebastian Andrzej Siewior 2018-07-18 9:24 ` Sebastian Andrzej Siewior 2018-07-18 9:24 ` Sebastian Andrzej Siewior 2018-07-24 14:45 ` Dave Martin 2018-07-24 14:45 ` Dave Martin 2018-07-24 15:15 ` Ard Biesheuvel 2018-07-24 15:15 ` Ard Biesheuvel 2018-07-24 13:46 ` Steven Rostedt 2018-07-24 13:46 ` Steven Rostedt 2018-07-24 13:57 ` Sebastian Andrzej Siewior 2018-07-24 13:57 ` Sebastian Andrzej Siewior 2018-07-26 15:06 ` [PATCH RT v3] arm64: fpsimd: use preemp_disable " Sebastian Andrzej Siewior 2018-07-26 15:06 ` Sebastian Andrzej Siewior 2018-07-27 3:17 ` Mike Galbraith 2018-07-27 3:17 ` Mike Galbraith 2018-07-27 7:56 ` Sebastian Andrzej Siewior 2018-07-27 7:56 ` Sebastian Andrzej Siewior 2018-07-27 15:35 ` Dave Martin 2018-07-27 15:35 ` Dave Martin 2018-07-27 16:26 ` Sebastian Andrzej Siewior 2018-07-27 16:26 ` Sebastian Andrzej Siewior 2018-07-11 17:07 ` [PATCH RT] arm64: fpsimd: use a local_lock() " Mike Galbraith
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180522173333.aawadhkcekzvrswp@linutronix.de \ --to=bigeasy@linutronix.de \ --cc=catalin.marinas@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rt-users@vger.kernel.org \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.